[clang] [clang][analyzer][NFC] Add more information to CallDescriptions in StreamChecker (PR #70540)

https://github.com/benshi001 created https://github.com/llvm/llvm-project/pull/70540 'tmpfile' has only one form that it has no argument. >From 043fbf02975dcc1adb894ae87f6c21dfd5f8479d Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Sat, 28 Oct 2023 14:57:44 +0800 Subject: [PATCH] [clang][analyze

[clang] [clang][analyzer][NFC] Add more information to CallDescriptions in StreamChecker (PR #70540)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Ben Shi (benshi001) Changes 'tmpfile' has only one form that it has no argument. --- Full diff: https://github.com/llvm/llvm-project/pull/70540.diff 1 Files Affected: - (modified) clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp (+1-

[clang] Perf/lexer faster slow get char and size (PR #70543)

https://github.com/serge-sans-paille created https://github.com/llvm/llvm-project/pull/70543 None >From 3fe63f81fcb999681daa11b2890c82fda3aaeef5 Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Thu, 26 Oct 2023 22:31:43 +0200 Subject: [PATCH 1/2] [clang] Change representation of CurLexer

[clang] Perf/lexer faster slow get char and size (PR #70543)

https://github.com/serge-sans-paille updated https://github.com/llvm/llvm-project/pull/70543 >From c9d34dae319de3eed1a23c23ff7b6d7673a04b79 Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Fri, 27 Oct 2023 22:48:08 +0200 Subject: [PATCH] [clang] Change GetCharAndSizeSlow interface to by-v

[clang] 8db38bd - [analyzer] Extend EnumCastOutOfRange diagnostics (#68191)

Author: Endre Fülöp Date: 2023-10-28T10:22:46+02:00 New Revision: 8db38bd34421f87cbe7813aeeca81bcbd935025d URL: https://github.com/llvm/llvm-project/commit/8db38bd34421f87cbe7813aeeca81bcbd935025d DIFF: https://github.com/llvm/llvm-project/commit/8db38bd34421f87cbe7813aeeca81bcbd935025d.diff L

[clang] [analyzer] Extend EnumCastOutOfRange diagnostics (PR #68191)

https://github.com/gamesh411 closed https://github.com/llvm/llvm-project/pull/68191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Perf/lexer faster slow get char and size (PR #70543)

cor3ntin wrote: Do you have benchmarks? I wonder if we should use a small struct instead of pair, it would be slightly easier to maintain I think. Looks good otherwise. https://github.com/llvm/llvm-project/pull/70543 ___ cfe-commits mailing list cfe-c

[clang] 4f6757c - [JITLink][RISCV] Implement eh_frame handling (#68253)

Author: Jonas Hahnfeld Date: 2023-10-28T11:30:43+02:00 New Revision: 4f6757ce4bc78b7f56e4cb2a84c35444cd71c145 URL: https://github.com/llvm/llvm-project/commit/4f6757ce4bc78b7f56e4cb2a84c35444cd71c145 DIFF: https://github.com/llvm/llvm-project/commit/4f6757ce4bc78b7f56e4cb2a84c35444cd71c145.diff

[clang] [JITLink][RISCV] Implement eh_frame handling (PR #68253)

https://github.com/hahnjo closed https://github.com/llvm/llvm-project/pull/68253 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/66583 >From 8b8acedc0e6c432545744a113128cfcb4f2da7e5 Mon Sep 17 00:00:00 2001 From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com> Date: Sat, 16 Sep 2023 16:24:13 +0200 Subject: [PATCH 01/19] [clang-tidy]

[clang] [Driver] Handle Flang in same manner between Gnu and *BSD/Solaris ToolChain (PR #70429)

https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/70429 >From 8e3e053c7b8048387efb39808429cef9802ea68f Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Fri, 27 Oct 2023 04:53:19 -0400 Subject: [PATCH] [Driver] Handle Flang in same manner between Gnu and *BSD/Solaris Tool

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

5chmidti wrote: I rebased and force-pushed my branch to fix the formatting CI (fetch depth for comparison with head was too big). I pushed no actual changes in that force-push (one documentation ordering change in `fix lexicographical ordering in some places after rename` became redundant). @E

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

5chmidti wrote: Nice, the rebase fixed the Windows failure https://github.com/llvm/llvm-project/pull/66583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D86993: Document Clang's expectations of the C standard library.

RalfJung added a comment. With everything moving to github PRs, what are the next steps for this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86993/new/ https://reviews.llvm.org/D86993 ___ cfe-co

[clang] [clang-format][NFC] Delete TT_LambdaArrow (PR #70519)

https://github.com/mydeveloperday approved this pull request. https://github.com/llvm/llvm-project/pull/70519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Change LLVM style to BreakAfterAttributes == ABS_Leave (PR #70360)

https://github.com/mydeveloperday approved this pull request. https://github.com/llvm/llvm-project/pull/70360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/LYP951018 created https://github.com/llvm/llvm-project/pull/70548 Modifications: - Skipped the instantiation of the explicit-specifier during Decl substitution if we were deducing template arguments and the explicit-specifier was value dependent. - Instantiated the explici

[clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

llvmbot wrote: @llvm/pr-subscribers-clang Author: 刘雨培 (LYP951018) Changes Modifications: - Skipped the instantiation of the explicit-specifier during Decl substitution if we were deducing template arguments and the explicit-specifier was value dependent. - Instantiated the explicit-spe

[clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/LYP951018 edited https://github.com/llvm/llvm-project/pull/70548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/LYP951018 edited https://github.com/llvm/llvm-project/pull/70548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/LYP951018 updated https://github.com/llvm/llvm-project/pull/70548 From 4f8111b58324d5b670311717d36654f64e6dac01 Mon Sep 17 00:00:00 2001 From: letrec Date: Sat, 28 Oct 2023 18:05:36 +0800 Subject: [PATCH] Defer the instantiation of explicit-specifier after constraint checkin

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/LYP951018 updated https://github.com/llvm/llvm-project/pull/70548 From a5929ddc33057416cee75d91f13a1252f4357524 Mon Sep 17 00:00:00 2001 From: letrec Date: Sat, 28 Oct 2023 18:05:36 +0800 Subject: [PATCH] Defer the instantiation of explicit-specifier after constraint checkin

[clang] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70551)

https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/70551 When an LLDB user asks for the value of a static data member, LLDB starts by searching the Names accelerator table for the corresponding variable definition DIE. For static data members with out-of-class defini

[clang] 497b2eb - [clang-format] Change LLVM style to BreakAfterAttributes == ABS_Leave (#70360)

Author: Vlad Serebrennikov Date: 2023-10-28T16:02:03+04:00 New Revision: 497b2ebb9edcfd5315586b796f47589e9820b4b9 URL: https://github.com/llvm/llvm-project/commit/497b2ebb9edcfd5315586b796f47589e9820b4b9 DIFF: https://github.com/llvm/llvm-project/commit/497b2ebb9edcfd5315586b796f47589e9820b4b9.

[clang] [clang-format] Change LLVM style to BreakAfterAttributes == ABS_Leave (PR #70360)

https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/70360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Assert not llvm_unreachable (PR #70149)

https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/70149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Add sched model for XiangShan-NanHu (PR #70232)

https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/70232 >From b34055dca42c23682bb9f0e9e022f17e9dbf2aca Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Sat, 28 Oct 2023 20:46:37 +0800 Subject: [PATCH] [RISCV] Add sched model for XiangShan-NanHu Co-authored-by: SFor

[clang] [RISCV] Add sched model for XiangShan-NanHu (PR #70232)

dtcxzyw wrote: Rebased on top of #70241. https://github.com/llvm/llvm-project/pull/70232 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Diagnose defaulted assignment operator with incompatible object parameter (PR #70176)

https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/70176 >From 9b559ac5504593ab7aa21539b49ece7eea944eb5 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Wed, 25 Oct 2023 10:08:24 +0200 Subject: [PATCH 1/3] [Clang] Diagnose defaulted assignment operator with incomp

[clang] [Driver] Handle Flang in same manner between Gnu and *BSD/Solaris ToolChain (PR #70429)

banach-space wrote: @brad0 Thanks for sending this - could you provide some context in the summary? Why update the GNU Toolchain rather than *BSD - as in, what should be source of truth here? Also, could you add tests? I will be OK next week, but am happy for this to be merged once my comment

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:2525 + + OMPClause *FailMemoryOrderClause = nullptr; + SourceLocation ArgumentLoc; I don't like the idea of a reference to another clause here, it may lead to many issues with se

[clang] Perf/lexer faster slow get char and size (PR #70543)

tbaederr wrote: > Do you have benchmarks? I wonder if we should use a small struct instead of > pair, it would be slightly easier to maintain I think. Looks good otherwise. See the commit: https://github.com/llvm/llvm-project/pull/70543/commits/c9d34dae319de3eed1a23c23ff7b6d7673a04b79 https:/

[clang] [clang][Interp] Implement builtin_expect (PR #69713)

Timm =?utf-8?q?B=C3=A4der?= Message-ID: In-Reply-To: tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/69713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Implement ranges::iota (PR #68494)

https://github.com/jamesETsmith updated https://github.com/llvm/llvm-project/pull/68494 >From c4a3ccfbad090ad8314aa8ad53092edc8d5432bc Mon Sep 17 00:00:00 2001 From: James Smith Date: Thu, 28 Sep 2023 10:11:15 -0400 Subject: [PATCH 01/12] [libc++] Implement ranges::iota and ranges::out_value_r

[clang] [Driver] Handle Flang in same manner between Gnu and *BSD/Solaris ToolChain (PR #70429)

MaskRay wrote: Seems fine to me once a test is added:) https://github.com/llvm/llvm-project/pull/70429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes

jaredgrubb updated this revision to Diff 557922. jaredgrubb added a comment. Address review feedback from @owenpan on Oct23. Thanks for helping me tune this patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150083/new/ https://reviews.llvm.org/D150083 Files: clang/docs/ClangForma

[PATCH] D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes

jaredgrubb added a comment. Should I open a GitHub issue for this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150083/new/ https://reviews.llvm.org/D150083 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang-tools-extra] [clang-tidy] fix match for binaryOperator in ExprMutationAnalyzer for misc-const-correctness (PR #70559)

https://github.com/5chmidti created https://github.com/llvm/llvm-project/pull/70559 The `ExprMutationAnalyzer`s matcher of `binaryOperator`s that contained the variable expr, were previously narrowing the variable to be type dependent, when the `binaryOperator` should have been narrowed as depen

[clang-tools-extra] [clang-tidy] fix match for binaryOperator in ExprMutationAnalyzer for misc-const-correctness (PR #70559)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Julian Schmidt (5chmidti) Changes The `ExprMutationAnalyzer`s matcher of `binaryOperator`s that contained the variable expr, were previously narrowing the variable to be type dependent, when the `binaryOperator` should have been narrowed as

[clang-tools-extra] [clang-tidy] fix match for binaryOperator in ExprMutationAnalyzer for misc-const-correctness (PR #70559)

5chmidti wrote: CC @JonasToth for your work on `ExprMutationAnalyzer` https://github.com/llvm/llvm-project/pull/70559 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] fix match for binaryOperator in ExprMutationAnalyzer for misc-const-correctness (PR #70559)

@@ -683,6 +683,9 @@ Bug Fixes to AST Handling - Fixed a bug where RecursiveASTVisitor fails to visit the initializer of a bitfield. `Issue 64916 `_ +- Fixed a bug where ``ExprMutationAnalyzer`` did not find a potential muta

[clang-tools-extra] [clang-tidy] fix match for binaryOperator in ExprMutationAnalyzer for misc-const-correctness (PR #70559)

https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/70559 >From b29eb35fe8597ceefc4c615817174181a16f3c4c Mon Sep 17 00:00:00 2001 From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com> Date: Sat, 28 Oct 2023 18:08:51 +0200 Subject: [PATCH 1/2] [clang-tidy] fi

[clang] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70551)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/70551 >From e02939572877cdc839894454a6fab36ab143d924 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 27 Oct 2023 16:33:07 +0100 Subject: [PATCH 1/3] [clang][DebugInfo][NFC] Add createConstantValueExpression

[clang-tools-extra] [clang-tidy] fix match for binaryOperator in ExprMutationAnalyzer for misc-const-correctness (PR #70559)

@@ -683,6 +683,9 @@ Bug Fixes to AST Handling - Fixed a bug where RecursiveASTVisitor fails to visit the initializer of a bitfield. `Issue 64916 `_ +- Fixed a bug where ``ExprMutationAnalyzer`` did not find a potential muta

[clang] [clang-tidy] fix match for binaryOperator in ExprMutationAnalyzer for misc-const-correctness (PR #70559)

5chmidti wrote: The top-level Linux and Windows tests work, but inside the `Trigger Build`/`clang-ci` run, the windows test step fails. I'm not sure what the difference is between these two Windows tests. https://github.com/llvm/llvm-project/pull/70559 _

[clang] Bfi precision (PR #66285)

dexonsmith wrote: Interesting. Probably `Value::getMetadata()` could/should call `DenseMap::find()` instead of `operator[]()` and assert that it's found before dereferencing, because `Value::hasMetadata()` (which, IIRC, consults a bit stored in `Value`) has already promised something will be t

[clang] [clang] Robustify openmp test (PR #69739)

https://github.com/jdoerfert approved this pull request. LG, thx https://github.com/llvm/llvm-project/pull/69739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AArch64] Pass down stack clash protection options to LLVM/Backend (PR #68993)

https://github.com/momchil-velikov updated https://github.com/llvm/llvm-project/pull/68993 >From ed580b95157d7f423c5384fa2d51af00f1359a10 Mon Sep 17 00:00:00 2001 From: Momchil Velikov Date: Mon, 2 Oct 2023 14:46:27 +0100 Subject: [PATCH 1/3] [CFIFixup] Allow function prologues to span more tha

[clang] [clang][AArch64] Pass down stack clash protection options to LLVM/Backend (PR #68993)

@@ -85,17 +90,32 @@ static bool isPrologueCFIInstruction(const MachineInstr &MI) { MI.getFlag(MachineInstr::FrameSetup); } -static bool containsPrologue(const MachineBasicBlock &MBB) { - return llvm::any_of(MBB.instrs(), isPrologueCFIInstruction); -} - static bool

[clang] [OpenMP] Unify the min/max thread/teams pathways (PR #70273)

@@ -1,68 +1,20 @@ -// RUN: %clang_cc1 -verify -fopenmp -fopenmp-targets=powerpc64le-ibm-linux-gnu -x c++ -triple powerpc64le-unknown-unknown -emit-llvm %s -o - | FileCheck -allow-deprecated-dag-overlap %s -check-prefix=CHECK1 -// RUN: %clang_cc1 -fopenmp -fopenmp-targets=powerp

[clang] [clang-format][NFC] Delete TT_LambdaArrow (PR #70519)

https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/70519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Warn against unused parameters in C++ coroutines with `-Wunused-parameters` (PR #70567)

https://github.com/yuxuanchen1997 created https://github.com/llvm/llvm-project/pull/70567 This PR is proposing a fix for https://github.com/llvm/llvm-project/issues/65971. Previously, given a coroutine like this ``` task foo(int a) { co_return; } ``` Parameter `a` is never used. However, bec

[clang] [Clang] Warn against unused parameters in C++ coroutines with `-Wunused-parameters` (PR #70567)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff b1554fe080e8b074a30f2a4cb88666bdb7b1ce9e ba6c43cc63e9ae3c8d174406ced4df839af3e0a7 --

[clang] [Clang] Warn against unused parameters in C++ coroutines with `-Wunused-parameters` (PR #70567)

https://github.com/yuxuanchen1997 updated https://github.com/llvm/llvm-project/pull/70567 >From ba6c43cc63e9ae3c8d174406ced4df839af3e0a7 Mon Sep 17 00:00:00 2001 From: Yuxuan Chen Date: Fri, 27 Oct 2023 16:37:40 -0700 Subject: [PATCH 1/2] [Clang] Coroutines: warn against unused parameters in C+

[PATCH] D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes

owenpan added a comment. In D150083#4655479 , @jaredgrubb wrote: > Should I open a GitHub issue for this patch? That'd be great. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150083/new/ https://reviews.llvm.org/D150083 _

[clang] [Clang] Warn against unused parameters in C++ coroutines with `-Wunused-parameters` (PR #70567)

https://github.com/yuxuanchen1997 updated https://github.com/llvm/llvm-project/pull/70567 >From ba6c43cc63e9ae3c8d174406ced4df839af3e0a7 Mon Sep 17 00:00:00 2001 From: Yuxuan Chen Date: Fri, 27 Oct 2023 16:37:40 -0700 Subject: [PATCH 1/3] [Clang] Coroutines: warn against unused parameters in C+

[clang] e00d32a - [clang-format][NFC] Delete TT_LambdaArrow (#70519)

Author: Owen Pan Date: 2023-10-28T12:48:00-07:00 New Revision: e00d32afb9d33a1eca48e2b041c9688436706c5b URL: https://github.com/llvm/llvm-project/commit/e00d32afb9d33a1eca48e2b041c9688436706c5b DIFF: https://github.com/llvm/llvm-project/commit/e00d32afb9d33a1eca48e2b041c9688436706c5b.diff LOG:

[clang] [clang-format][NFC] Delete TT_LambdaArrow (PR #70519)

https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/70519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Perf/lexer faster slow get char and size (PR #70543)

https://github.com/serge-sans-paille updated https://github.com/llvm/llvm-project/pull/70543 >From 7bbcabd82edc1736cc22243e109dc0858036c6ac Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Fri, 27 Oct 2023 22:48:08 +0200 Subject: [PATCH] [clang] Change GetCharAndSizeSlow interface to by-v

[clang] Perf/lexer faster slow get char and size (PR #70543)

serge-sans-paille wrote: @cor3ntin yep, looks better with a small struct, updated pushed https://github.com/llvm/llvm-project/pull/70543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70551)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/70551 >From e02939572877cdc839894454a6fab36ab143d924 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 27 Oct 2023 16:33:07 +0100 Subject: [PATCH 1/4] [clang][DebugInfo][NFC] Add createConstantValueExpression

[clang] Perf/lexer faster slow get char and size (PR #70543)

@@ -1964,11 +1969,14 @@ bool Lexer::LexIdentifierContinue(Token &Result, const char *CurPtr) { /// isHexaLiteral - Return true if Start points to a hex constant. /// in microsoft mode (where this is supposed to be several different tokens). bool Lexer::isHexaLiteral(const char

[clang] Perf/lexer faster slow get char and size (PR #70543)

@@ -2012,15 +2020,15 @@ bool Lexer::LexNumericConstant(Token &Result, const char *CurPtr) { // If we have a digit separator, continue. if (C == '\'' && (LangOpts.CPlusPlus14 || LangOpts.C23)) { -unsigned NextSize; -char Next = getCharAndSizeNoWarn(CurPtr + Size, N

[clang] Perf/lexer faster slow get char and size (PR #70543)

@@ -2085,8 +2093,9 @@ const char *Lexer::LexUDSuffix(Token &Result, const char *CurPtr, unsigned Consumed = Size; unsigned Chars = 1; while (true) { -unsigned NextSize; -char Next = getCharAndSizeNoWarn(CurPtr + Consumed, NextSize, LangOpts);

[clang] Perf/lexer faster slow get char and size (PR #70543)

@@ -565,10 +565,9 @@ Scanner::cleanStringIfNeeded(const dependency_directives_scan::Token &Tok) { const char *BufPtr = Input.begin() + Tok.Offset; const char *AfterIdent = Input.begin() + Tok.getEnd(); while (BufPtr < AfterIdent) { -unsigned Size; -Spelling[Spell

[clang] [OpenMP] Unify the min/max thread/teams pathways (PR #70273)

https://github.com/shiltian approved this pull request. LG https://github.com/llvm/llvm-project/pull/70273 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [MLIR] Update convert-gpu-to-spirv pass to prepare using GPU compilat… (PR #69941)

https://github.com/antiagainst requested changes to this pull request. Nice. Just one final request. https://github.com/llvm/llvm-project/pull/69941 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang-tools-extra] [MLIR] Update convert-gpu-to-spirv pass to prepare using GPU compilat… (PR #69941)

https://github.com/antiagainst edited https://github.com/llvm/llvm-project/pull/69941 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MLIR] Update convert-gpu-to-spirv pass to prepare using GPU compilat… (PR #69941)

https://github.com/antiagainst requested changes to this pull request. Nice. Just one final request. https://github.com/llvm/llvm-project/pull/69941 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [MLIR] Update convert-gpu-to-spirv pass to prepare using GPU compilat… (PR #69941)

@@ -54,22 +55,52 @@ void GPUToSPIRVPass::runOnOperation() { SmallVector gpuModules; OpBuilder builder(context); + + auto targetEnvSupportsKernelCapability = [](gpu::GPUModuleOp moduleOp) { +Operation *gpuModule = moduleOp.getOperation(); +auto targetAttr = spirv::

[clang-tools-extra] Bfi precision (PR #66285)

david-xl wrote: > And digging even deeper: > > * FWIW I noticed that I only used `clang -c` as benchmark previously, should > have used `clang -c -O3` resulting in this: > > ``` > Old-BFI: insn: 37,821,687,947 (baseline) > New-BFI: insn: 38,133,312,923 +0.82% > Old-BFI, no-

[clang] Bfi precision (PR #66285)

david-xl wrote: > And digging even deeper: > > * FWIW I noticed that I only used `clang -c` as benchmark previously, should > have used `clang -c -O3` resulting in this: > > ``` > Old-BFI: insn: 37,821,687,947 (baseline) > New-BFI: insn: 38,133,312,923 +0.82% > Old-BFI, no-

[clang] [MLIR] SPIRV Target Attribute (PR #69949)

@@ -0,0 +1,117 @@ +//===- Target.cpp - MLIR SPIRV target compilation ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [MLIR] SPIRV Target Attribute (PR #69949)

https://github.com/antiagainst edited https://github.com/llvm/llvm-project/pull/69949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MLIR] SPIRV Target Attribute (PR #69949)

@@ -166,4 +166,35 @@ def SPIRV_ResourceLimitsAttr : SPIRV_Attr<"ResourceLimits", "resource_limits"> { let assemblyFormat = "`<` struct(params) `>`"; } +//===--===// +// SPIRV target attribute. +//===---

[clang-tools-extra] [MLIR] SPIRV Target Attribute (PR #69949)

@@ -0,0 +1,117 @@ +//===- Target.cpp - MLIR SPIRV target compilation ---*- C++ -*-===// antiagainst wrote: Nit: again, please use SPIR-V in docs and comments. Please make sure everywhere follows the convention. :) https://github.com/llvm/llvm-proje

[clang] [MLIR] SPIRV Target Attribute (PR #69949)

@@ -0,0 +1,7 @@ +// RUN: mlir-opt %s --spirv-attach-target='module=spirv.* ver=v1.0 caps=Kernel' | FileCheck %s + +module attributes {gpu.container_module} { +// CHECK: @spirv_module_1 [#spirv.target, resource_limits = <>>] +gpu.module @spirv_module_1 { antiagai

[clang] [MLIR] SPIRV Target Attribute (PR #69949)

@@ -0,0 +1,117 @@ +//===- Target.cpp - MLIR SPIRV target compilation ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [MLIR] SPIRV Target Attribute (PR #69949)

@@ -188,4 +188,46 @@ def GpuROCDLAttachTarget: Pass<"rocdl-attach-target", ""> { ]; } +def GpuSPIRVAttachTarget: Pass<"spirv-attach-target", ""> { + let summary = "Attaches an SPIRV target attribute to a GPU Module."; + let description = [{ +This pass searches for all

[clang-tools-extra] [MLIR] SPIRV Target Attribute (PR #69949)

@@ -0,0 +1,117 @@ +//===- Target.cpp - MLIR SPIRV target compilation ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [MLIR] SPIRV Target Attribute (PR #69949)

@@ -0,0 +1,117 @@ +//===- Target.cpp - MLIR SPIRV target compilation ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [MLIR] SPIRV Target Attribute (PR #69949)

@@ -0,0 +1,94 @@ +//===- SPIRVAttachTarget.cpp - Attach an SPIRV target -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [MLIR] SPIRV Target Attribute (PR #69949)

@@ -166,4 +166,35 @@ def SPIRV_ResourceLimitsAttr : SPIRV_Attr<"ResourceLimits", "resource_limits"> { let assemblyFormat = "`<` struct(params) `>`"; } +//===--===// +// SPIRV target attribute. -

[clang-tools-extra] [MLIR] SPIRV Target Attribute (PR #69949)

@@ -0,0 +1,94 @@ +//===- SPIRVAttachTarget.cpp - Attach an SPIRV target -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [MLIR] SPIRV Target Attribute (PR #69949)

@@ -188,4 +188,46 @@ def GpuROCDLAttachTarget: Pass<"rocdl-attach-target", ""> { ]; } +def GpuSPIRVAttachTarget: Pass<"spirv-attach-target", ""> { + let summary = "Attaches an SPIRV target attribute to a GPU Module."; + let description = [{ +This pass searches for all

[clang] [MLIR] SPIRV Target Attribute (PR #69949)

@@ -0,0 +1,117 @@ +//===- Target.cpp - MLIR SPIRV target compilation ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [MLIR] SPIRV Target Attribute (PR #69949)

@@ -188,4 +188,46 @@ def GpuROCDLAttachTarget: Pass<"rocdl-attach-target", ""> { ]; } +def GpuSPIRVAttachTarget: Pass<"spirv-attach-target", ""> { + let summary = "Attaches an SPIRV target attribute to a GPU Module."; antiagainst wrote: Nit: s/SPIRV/SPIR-V

[clang-tools-extra] [MLIR] SPIRV Target Attribute (PR #69949)

@@ -166,4 +166,35 @@ def SPIRV_ResourceLimitsAttr : SPIRV_Attr<"ResourceLimits", "resource_limits"> { let assemblyFormat = "`<` struct(params) `>`"; } +//===--===// +// SPIRV target attribute. +//===---

[clang-tools-extra] [MLIR] SPIRV Target Attribute (PR #69949)

@@ -0,0 +1,30 @@ +//===- Target.h - MLIR SPIRV target registration *- C++ -*-===// antiagainst wrote: Nit: again, please use SPIR-V in docs and comments. https://github.com/llvm/llvm-project/pull/69949 ___

[clang] [MLIR] SPIRV Target Attribute (PR #69949)

https://github.com/antiagainst requested changes to this pull request. Thanks again for the contribution! A couple of comments inlined. My main concern is the duplication of `spirv.target` attribute. We should avoid the duplication and confusion there. https://github.com/llvm/llvm-project/pull

[clang-tools-extra] [MLIR] SPIRV Target Attribute (PR #69949)

@@ -0,0 +1,117 @@ +//===- Target.cpp - MLIR SPIRV target compilation ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [MLIR] SPIRV Target Attribute (PR #69949)

@@ -188,4 +188,46 @@ def GpuROCDLAttachTarget: Pass<"rocdl-attach-target", ""> { ]; } +def GpuSPIRVAttachTarget: Pass<"spirv-attach-target", ""> { + let summary = "Attaches an SPIRV target attribute to a GPU Module."; + let description = [{ +This pass searches for all

[clang] [MLIR] SPIRV Target Attribute (PR #69949)

@@ -188,4 +188,46 @@ def GpuROCDLAttachTarget: Pass<"rocdl-attach-target", ""> { ]; } +def GpuSPIRVAttachTarget: Pass<"spirv-attach-target", ""> { + let summary = "Attaches an SPIRV target attribute to a GPU Module."; antiagainst wrote: Nit: s/SPIRV/SPIR-V

[clang] [MLIR] SPIRV Target Attribute (PR #69949)

@@ -0,0 +1,30 @@ +//===- Target.h - MLIR SPIRV target registration *- C++ -*-===// antiagainst wrote: Nit: again, please use SPIR-V in docs and comments. https://github.com/llvm/llvm-project/pull/69949 ___

[clang] [Clang] Warn against unused parameters in C++ coroutines with `-Wunused-parameters` (PR #70567)

https://github.com/yuxuanchen1997 ready_for_review https://github.com/llvm/llvm-project/pull/70567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Implement dynamic memory allocation handling (PR #70306)

Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/70306 >From f1bb89bf7cfe8940726a1c51edaaf73d5bd74c4e Mon Sep 17 00:00:00 2001 From: =?UTF-8?

[clang] [clang][Interp] IndirectMember initializers (PR #69900)

https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/69900 >From af4c29cfef620476c0d922d6ee9628f95cefc2b5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sun, 22 Oct 2023 19:47:33 +0200 Subject: [PATCH] [clang][Interp] IndirectMember initializers ---

[PATCH] D86993: Document Clang's expectations of the C standard library.

rsmith added a comment. In D86993#4655474 , @RalfJung wrote: > With everything moving to github PRs, what are the next steps for this patch? I'm unlikely to have cycles to work on this in the near future. If someone else wants to take over here, you woul

[clang] [clang-format][NFC] Reduce indent (PR #70583)

https://github.com/HazardyKnusperkeks created https://github.com/llvm/llvm-project/pull/70583 By using if init statement. From b1af9c060cc5dca1f3bbc551d6a77e73451ffa06 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Sch=C3=A4pers?= Date: Sun, 29 Oct 2023 07:18:06 +0100 Subject: [PATCH] [

[clang] [clang-format][NFC] Reduce indent (PR #70583)

llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Björn Schäpers (HazardyKnusperkeks) Changes By using if init statement. --- Full diff: https://github.com/llvm/llvm-project/pull/70583.diff 1 Files Affected: - (modified) clang/lib/Format/TokenAnnotator.cpp (+10-12) ``

  1   2   >