ABataev added inline comments.
================ Comment at: clang/include/clang/AST/OpenMPClause.h:2525 + + OMPClause *FailMemoryOrderClause = nullptr; + SourceLocation ArgumentLoc; ---------------- I don't like the idea of a reference to another clause here, it may lead to many issues with serialization/deserialization, use-after-free etc. Better to keep a flag (kind of memory order clause?) that there is associated clause here and then just find it in the list of clauses, where required. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
