[PATCH] D131879: [clang][analyzer] Errno modeling code refactor (NFC).

This revision was automatically updated to reflect the committed changes. Closed by commit rGd56a1c682477: [clang][analyzer] Errno modeling code refactor (NFC). (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131879/new/ https:

[clang] d56a1c6 - [clang][analyzer] Errno modeling code refactor (NFC).

Author: Balázs Kéri Date: 2022-09-01T09:05:59+02:00 New Revision: d56a1c68247751e94c4fc46dda282643d3739689 URL: https://github.com/llvm/llvm-project/commit/d56a1c68247751e94c4fc46dda282643d3739689 DIFF: https://github.com/llvm/llvm-project/commit/d56a1c68247751e94c4fc46dda282643d3739689.diff L

[PATCH] D132831: [clang][Interp] Handle SubstNonTypeTemplateParmExprs

tbaeder marked 3 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:273 +const SubstNonTypeTemplateParmExpr *E) { + return this->visit(E->getReplacement()); +} tbaeder wrote: > tahonermann wrote: > >

[PATCH] D131386: [clang-tidy] Added `ConstAlignment` option to `misc-const-correctness`

JonasToth added a comment. during the original implementation of the fix-util I had the plan to provide an option for east-vs-west const, but during the discussions we came to the conclusion that `clang-format` should do this (the patches were already pending at that point in time). if this op

[PATCH] D131386: [clang-tidy] Added `ConstAlignment` option to `misc-const-correctness`

JonasToth added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc/const-correctness-alignment.cpp:43 + // of the `*`. + int *IPtr = &I; + // CHECK-MESSAGES: [[@LINE-1]]:3: warning: variable 'IPtr' of type 'int *' can be declared 'const' ---

[PATCH] D125655: [HLSL] add -P option for dxc mode.

python3kgae updated this revision to Diff 457191. python3kgae marked an inline comment as done. python3kgae added a comment. Switch to CLMode -P and -Fi. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125655/new/ https://reviews.llvm.org/D125655 Fi

[PATCH] D132142: [analyzer] Prefer wrapping SymbolicRegions by ElementRegions

steakhal added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:799 + /// we actually know their types. + QualType getApproximatedType() const { +return sym->getType()->getPointeeType(); martong wrote: > I thin

[PATCH] D132945: [clang] Skip re-building lambda expressions in parameters to consteval fns.

usaxena95 added a comment. Gentle ping for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132945/new/ https://reviews.llvm.org/D132945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D132997: [clang][Interp] Handle DeclRefExpr of reference types

tbaeder updated this revision to Diff 457193. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132997/new/ https://reviews.llvm.org/D132997 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/arrays.cpp clang/test/AST/Interp/references.cpp Index: clang/test/AST/Inte

[PATCH] D132997: [clang][Interp] Handle DeclRefExpr of reference types

tbaeder added a comment. In D132997#3763094 , @shafik wrote: > I think like @aaron.ballman was saying in another PR you should aim for as > complete set of tests as possible even if you have to comment one that can't > work yet. For example cases that w

[PATCH] D130181: [clang-tidy] Add readability-use-early-exits check

njames93 updated this revision to Diff 457199. njames93 marked 3 inline comments as done. njames93 added a comment. Fix documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130181/new/ https://reviews.llvm.org/D130181 Files: clang-tools-

[PATCH] D130181: [clang-tidy] Add readability-use-early-exits check

njames93 added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability/use-early-exits.rst:63 +void Process(bool A, bool B) { + if (A && B) { +// Long processing. JonasToth wrote: > njames93 wrote: > > JonasToth wrote:

[clang] 7e19d53 - [NFC] Emit builtin coroutine calls uniforally

Author: Chuanqi Xu Date: 2022-09-01T16:31:51+08:00 New Revision: 7e19d53da44942de9b373028828c276648a8f2a4 URL: https://github.com/llvm/llvm-project/commit/7e19d53da44942de9b373028828c276648a8f2a4 DIFF: https://github.com/llvm/llvm-project/commit/7e19d53da44942de9b373028828c276648a8f2a4.diff LO

[PATCH] D132945: [clang] Skip re-building lambda expressions in parameters to consteval fns.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. Thanks, that's a nice find! Could you also add a test that mentions uses `consteval` functions in lambda captures inside immediate invocations? Something like `consteval_foo([x =

[PATCH] D132473: [Docs][OpenCL][SPIR-V] Release 15 notes for Clang

Anastasia closed this revision. Anastasia added a comment. Committed in https://github.com/llvm/llvm-project/commit/5e1b36ced538cfc80f2400b27e346d2175b04092. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132473/new/ https://reviews.llvm.org/D132473

[clang] c640b8c - [NFC][clang] LLVM_FALLTHROUGH => [[fallthrough]]

Author: Sheng Date: 2022-09-01T09:19:00Z New Revision: c640b8ce33f7d128c4d25c282bd245ae7177cf04 URL: https://github.com/llvm/llvm-project/commit/c640b8ce33f7d128c4d25c282bd245ae7177cf04 DIFF: https://github.com/llvm/llvm-project/commit/c640b8ce33f7d128c4d25c282bd245ae7177cf04.diff LOG: [NFC][c

[PATCH] D130768: [OpenCL][SPIR-V] Add test for extern functions with a pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b1a04529c8f: [OpenCL][SPIR-V] Test extern functions with a pointer arg. (authored by Anastasia). Herald added a subscriber: ldrumm. Herald added a project: clang. Changed prior to commit: https://revie

[clang] 6b1a045 - [OpenCL][SPIR-V] Test extern functions with a pointer arg.

Author: Anastasia Stulova Date: 2022-09-01T10:22:47+01:00 New Revision: 6b1a04529c8fba4019b3a7f56fe6e4938f3a188a URL: https://github.com/llvm/llvm-project/commit/6b1a04529c8fba4019b3a7f56fe6e4938f3a188a DIFF: https://github.com/llvm/llvm-project/commit/6b1a04529c8fba4019b3a7f56fe6e4938f3a188a.d

[PATCH] D131217: [clang][WebAssembly] Pass `-Wl,-no-type-check` through to the MC layer

This revision was automatically updated to reflect the committed changes. Closed by commit rG849df8f6f0a6: [clang][WebAssembly] Pass `-Wa,--no-type-check` through to the MC layer (authored by sbc100). Changed prior to commit: https://reviews.llvm.org/D131217?vs=454128&id=457215#toc Repository:

[clang] 849df8f - [clang][WebAssembly] Pass `-Wa,--no-type-check` through to the MC layer

Author: Sam Clegg Date: 2022-09-01T02:56:58-07:00 New Revision: 849df8f6f0a6ded83e36aa52b6daa6b950289804 URL: https://github.com/llvm/llvm-project/commit/849df8f6f0a6ded83e36aa52b6daa6b950289804 DIFF: https://github.com/llvm/llvm-project/commit/849df8f6f0a6ded83e36aa52b6daa6b950289804.diff LOG

[clang] d931ac9 - [clang][dataflow] Generalise match switch utility to other AST types and add a `CFGMatchSwitch` which currently handles `CFGStmt` and `CFGInitializer`.

Author: Wei Yi Tee Date: 2022-09-01T10:15:53Z New Revision: d931ac9e27cab964c65078c80e4488185c62b3d8 URL: https://github.com/llvm/llvm-project/commit/d931ac9e27cab964c65078c80e4488185c62b3d8 DIFF: https://github.com/llvm/llvm-project/commit/d931ac9e27cab964c65078c80e4488185c62b3d8.diff LOG: [c

[PATCH] D131616: [clang][dataflow] Generalise match switch utility to other AST types and add a `CFGMatchSwitch` which currently handles `CFGStmt` and `CFGInitializer`.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd931ac9e27ca: [clang][dataflow] Generalise match switch utility to other AST types and add a… (authored by wyt). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D132855: [OpenMP] Extend the lit test for uses_allocators in target region

animeshk-amd updated this revision to Diff 457219. animeshk-amd added a comment. Extended the LIT test for `defaultmap` clause in the target region with respect to the default OpenMP version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132855/new/

[PATCH] D133085: [clang] trim trailing space in format tests. NFC

aaron.ballman added a comment. In D133085#3763233 , @inclyc wrote: > In D133085#3763198 , @ChuanqiXu > wrote: > >> Do you have commit access? If you have, I remember LLVM encourages to land >> such fixes directl

[clang-tools-extra] cc09b81 - [CTE][docs] Fix bad links in ReleaseNotes

Author: Nathan James Date: 2022-09-01T12:10:53+01:00 New Revision: cc09b81265e9543b9b78a2687e7b5c818a137a59 URL: https://github.com/llvm/llvm-project/commit/cc09b81265e9543b9b78a2687e7b5c818a137a59 DIFF: https://github.com/llvm/llvm-project/commit/cc09b81265e9543b9b78a2687e7b5c818a137a59.diff

[PATCH] D132142: [analyzer] Prefer wrapping SymbolicRegions by ElementRegions

martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:799 + /// we actually know their types. + QualType getApproximatedType() const { +return sym->getType()->getPointeeType(); steakhal wrote: > marton

[PATCH] D133102: [clang-tidy] Extend simplify-boolean-expr check

njames93 created this revision. njames93 added reviewers: aaron.ballman, JonasToth, LegalizeAdulthood, alexfh. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subsc

[PATCH] D131858: [clang] Track the templated entity in type substitution.

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3748-3751 + // If it is a template, import all related things. + if (Error Err = ImportTemplateInformation(D, ToFunction)) +return std::move(Err); + What's the reason of moving this hu

[PATCH] D133102: [clang-tidy] Extend simplify-boolean-expr check

njames93 updated this revision to Diff 457228. njames93 added a comment. Remove unnecessary includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133102/new/ https://reviews.llvm.org/D133102 Files: clang-tools-extra/clang-tidy/readability/Simpl

[PATCH] D132109: [analyzer] Dump the environment entry kind as well

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132109/new/ https://reviews.llvm.org/D132109 _

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3748-3751 + // If it is a template, import all related things. + if (Error Err = ImportTemplateInformation(D, ToFunction)) +return std::move(Err); + martong wrote: > What's the reason

[PATCH] D133029: [Sema] Allow to diagnose the references to std::vector with incomplete T

ilya-biryukov added a comment. In D133029#3763120 , @shafik wrote: > Do you have an idea of how common this might be? I don't have the numbers yet, but this broke the builds in C++20 mode inside the core libraries we are using after libc++ change

[PATCH] D132756: [clang][dataflow] Refactor `TypeErasedDataflowAnalysisTest` - replace usage of the deprecated overload of `checkDataflow`.

wyt updated this revision to Diff 457231. wyt added a comment. Update build target dependency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132756/new/ https://reviews.llvm.org/D132756 Files: clang/unittests/Analysis/FlowSensitive/TestingSuppor

[PATCH] D132851: Further update -Wbitfield-constant-conversion for 1-bit bitfield

bjope added inline comments. Comment at: clang/test/Sema/constant-conversion.c:30 + s.b = 1; // one-bit-warning {{implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1}} + s.b = true; // no-warning (we suppress it manually to reduce false

[clang] 0cb0809 - [Clang][Comments] Parse `` in doc comments correctly

Author: Egor Zhdan Date: 2022-09-01T13:17:42+01:00 New Revision: 0cb08093365478224f2a58cece42527fb8e1199e URL: https://github.com/llvm/llvm-project/commit/0cb08093365478224f2a58cece42527fb8e1199e DIFF: https://github.com/llvm/llvm-project/commit/0cb08093365478224f2a58cece42527fb8e1199e.diff LO

[PATCH] D132932: [Clang][Comments] Parse `` in doc comments correctly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0cb080933654: [Clang][Comments] Parse `` in doc comments correctly (authored by egorzhdan). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D133009: [libclang] Fix conversion from `StringRef` to `CXString`

egorzhdan added inline comments. Comment at: clang/test/Index/comment-lots-of-unknown-commands.c:3 +// XFAIL: * + aaronpuchert wrote: > egorzhdan wrote: > > gribozavr2 wrote: > > > egorzhdan wrote: > > > > This test was never properly passing. Because of the bu

[PATCH] D133105: [Clang][Comments] Fix `Index/comment-lots-of-unknown-commands.c`

egorzhdan created this revision. egorzhdan added a reviewer: aaronpuchert. Herald added a subscriber: arphaman. Herald added a project: All. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This re-enables a test after it was disab

[PATCH] D132962: [clangd][ObjC] Improve completions for protocols + category names

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:3228 + + Results = completions(R"objc( + Fo^ nit: just `completions("Fo^", ...)` Comment at: clang-tools-extra/clangd/unittests/CodeCompl

[clang] e0746a8 - [clang] cleanup -fstrict-flex-arrays implementation

Author: serge-sans-paille Date: 2022-09-01T15:06:21+02:00 New Revision: e0746a8a8d647ccee41accf16df895c9b03552c2 URL: https://github.com/llvm/llvm-project/commit/e0746a8a8d647ccee41accf16df895c9b03552c2 DIFF: https://github.com/llvm/llvm-project/commit/e0746a8a8d647ccee41accf16df895c9b03552c2.d

[PATCH] D132944: [clang] cleanup -fstrict-flex-arrays implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rGe0746a8a8d64: [clang] cleanup -fstrict-flex-arrays implementation (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132944/new/

[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

erichkeane added a comment. I don't mind the idea, but wonder if some level of RFC/project-wide decision should be made here? WDYT @aaron.ballman ? Comment at: clang/lib/Driver/Driver.cpp:5425 Arg *A = C.getArgs().getLastArg(options::OPT_fcrash_diagnostics_dir); - if (CCG

[PATCH] D133108: [clang] Rework IsTailPaddedMemberArray into isFlexibleArrayMemberExpr

serge-sans-paille created this revision. serge-sans-paille added a reviewer: jyknight. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes a bunch of FIXME within IsTailPaddedMemberArray

[PATCH] D133072: [clang] fix profiling of template arguments of template and declaration kind

erichkeane added a comment. Generally happy here. Two quick suggestions, otherewise LGTM. Comment at: clang/lib/AST/ASTContext.cpp:5119 // Find the insert position again. -DependentTemplateSpecializationTypes.FindNodeOrInsertPos(ID, InsertPos); +[[maybe_unused]] a

[PATCH] D129488: [Sema] Delay evaluation of std::source_location::current() in default arguments

ilya-biryukov added a comment. In D129488#3762490 , @jyknight wrote: > The more I look at this, the more I feel like, if all the above behaviors are > correct, source_location::current() simply shouldn't be marked consteval at > all. If it was constexpr

[clang] db898d4 - [clang][dataflow] Refactor `TestingSupport.h`

Author: Wei Yi Tee Date: 2022-09-01T13:21:34Z New Revision: db898d43b08e13f5c1fda92b8341cd1709f5af21 URL: https://github.com/llvm/llvm-project/commit/db898d43b08e13f5c1fda92b8341cd1709f5af21 DIFF: https://github.com/llvm/llvm-project/commit/db898d43b08e13f5c1fda92b8341cd1709f5af21.diff LOG: [c

[PATCH] D132147: [clang][dataflow] Refactor `TestingSupport.h`

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb898d43b08e: [clang][dataflow] Refactor `TestingSupport.h` (authored by wyt). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132147/new/ https://reviews.llv

[PATCH] D131858: [clang] Track the templated entity in type substitution.

erichkeane added a comment. Just did a quick scroll through this (as it is quite large!), but the general idea seems like a fine one to me. I AM concerned about how it interacts with the deferred concepts instantiation that I've been working on (https://reviews.llvm.org/D126907), particularly

[PATCH] D132689: [Object] Refactor code for extracting offload binaries

jhuber6 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132689/new/ https://reviews.llvm.org/D132689 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D133072: [clang] fix profiling of template arguments of template and declaration kind

mizvekov added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:5119 // Find the insert position again. -DependentTemplateSpecializationTypes.FindNodeOrInsertPos(ID, InsertPos); +[[maybe_unused]] auto *Nothing = +DependentTemplateSpecializationTypes.

[PATCH] D133072: [clang] fix profiling of template arguments of template and declaration kind

erichkeane accepted this revision. erichkeane added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:5119 // Find the insert position again. -DependentTemplateSpecializationTypes.FindNodeOrInsertPos(ID, InsertPos); +[[maybe_unused]] auto *Nothing = +

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov added a comment. In D131858#3763851 , @erichkeane wrote: > Just did a quick scroll through this (as it is quite large!), but the general > idea seems like a fine one to me. I AM concerned about how it interacts with > the deferred concepts in

[PATCH] D133072: [clang] fix profiling of template arguments of template and declaration kind

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:5817 // fall back to just producing individual arguments. - Converted.insert(Converted.end(), - ArgumentPack.begin(), ArgumentPack.end()); + for (con

[PATCH] D131858: [clang] Track the templated entity in type substitution.

erichkeane added a comment. In D131858#3763878 , @mizvekov wrote: > In D131858#3763851 , @erichkeane > wrote: > >> Just did a quick scroll through this (as it is quite large!), but the >> general idea seems like

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

Orlando added subscribers: probinson, Orlando. Orlando added a comment. When constructing the compiler command line (here in Clang.cpp ) there's a special case for SCE

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov added a comment. In D131858#3763892 , @erichkeane wrote: > In D131858#3763878 , @mizvekov > wrote: > >> In D131858#3763851 , @erichkeane >> wrote: >> >>> Just

[clang] 5a4aece - [clang][dataflow] Add `SetupTest` parameter for `AnalysisInputs`.

Author: Wei Yi Tee Date: 2022-09-01T13:48:29Z New Revision: 5a4aece76de7c73b9adf29b0c3f4e8641575cee1 URL: https://github.com/llvm/llvm-project/commit/5a4aece76de7c73b9adf29b0c3f4e8641575cee1 DIFF: https://github.com/llvm/llvm-project/commit/5a4aece76de7c73b9adf29b0c3f4e8641575cee1.diff LOG: [c

[PATCH] D132377: [clang][dataflow] Add `SetupTest` parameter for `AnalysisInputs`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a4aece76de7: [clang][dataflow] Add `SetupTest` parameter for `AnalysisInputs`. (authored by wyt). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132377/new/

[PATCH] D131979: [clang][UBSan] Fix __builtin_assume_aligned crash

yihanaa added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:7671 + AllArgs, CallType)) +return true; + rjmccall wrote: > yihanaa wrote: > > rjmccall wrote: > > > You can just pull the argument expressions out of the

[PATCH] D133109: [LLVM][ARM] Remove options for armv2, 2A, 3 and 3M

DavidSpickett created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Fixes #57486 These pre v4 architectures a

[PATCH] D133109: [LLVM][ARM] Remove options for armv2, 2A, 3 and 3M

DavidSpickett added a comment. https://github.com/llvm/llvm-project/issues/57486 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133109/new/ https://reviews.llvm.org/D133109 ___ cfe-commits mailing list cf

[PATCH] D132962: [clangd][ObjC] Improve completions for protocols + category names

dgoldman updated this revision to Diff 457257. dgoldman added a comment. Fix strings + test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132962/new/ https://reviews.llvm.org/D132962 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools

[PATCH] D132962: [clangd][ObjC] Improve completions for protocols + category names

dgoldman updated this revision to Diff 457258. dgoldman added a comment. Run clang-format again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132962/new/ https://reviews.llvm.org/D132962 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-t

[PATCH] D133109: [LLVM][ARM] Remove options for armv2, 2A, 3 and 3M

DavidSpickett added reviewers: psmith, easyaspi314. DavidSpickett added a comment. The remaining reference in the repo is a #define in `openmp/runtime/src/kmp_platform.h` which seems harmless. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133109/ne

[PATCH] D132689: [Object] Refactor code for extracting offload binaries

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132689/new/ https://reviews.llvm.org/D132689 __

[clang] 8dd14c4 - [clang][dataflow] Use `StringMap` for storing analysis states at annotated points instead of `vector>`.

Author: Wei Yi Tee Date: 2022-09-01T14:09:43Z New Revision: 8dd14c427ae5c86cc2af4b8cac05b41bc4a49e86 URL: https://github.com/llvm/llvm-project/commit/8dd14c427ae5c86cc2af4b8cac05b41bc4a49e86 DIFF: https://github.com/llvm/llvm-project/commit/8dd14c427ae5c86cc2af4b8cac05b41bc4a49e86.diff LOG: [c

[PATCH] D132763: [clang][dataflow] Use `StringMap` for storing analysis states at annotated points instead of `vector>`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8dd14c427ae5: [clang][dataflow] Use `StringMap` for storing analysis states at annotated… (authored by wyt). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

luken-google updated this revision to Diff 457262. luken-google added a comment. Refactor to use CodeSynthesisContexts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133052/new/ https://reviews.llvm.org/D133052 Files: clang/docs/ReleaseNotes.rst

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

luken-google updated this revision to Diff 457264. luken-google added a comment. Remove debugging cruft Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133052/new/ https://reviews.llvm.org/D133052 Files: clang/docs/ReleaseNotes.rst clang/lib/Sem

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

luken-google added a comment. In D133052#3763201 , @ychen wrote: > In D133052#3763041 , @luken-google > wrote: > >> In D133052#3762596 , @ychen wrote: >> >>> Like mention

[PATCH] D133085: [clang] trim trailing space in format tests. NFC

inclyc added a comment. Thank you for your patience and detailed explanation! Sorry for waste your time though ( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133085/new/ https://reviews.llvm.org/D133085 __

[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

mizvekov added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5425 Arg *A = C.getArgs().getLastArg(options::OPT_fcrash_diagnostics_dir); - if (CCGenDiagnostics && A) { -SmallString<128> CrashDirectory(A->getValue()); + const char *CrashDirectory = CCGenDiagnost

[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

erichkeane added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5425 Arg *A = C.getArgs().getLastArg(options::OPT_fcrash_diagnostics_dir); - if (CCGenDiagnostics && A) { -SmallString<128> CrashDirectory(A->getValue()); + const char *CrashDirectory = CCGenDiagno

[PATCH] D133085: [clang] trim trailing space in format tests. NFC

aaron.ballman added a comment. In D133085#3764067 , @inclyc wrote: > Thank you for your patience and detailed explanation! Sorry for waste your > time though ( No worries, it's definitely not a waste of time to explain this sort of stuff! :-) Reposit

[PATCH] D133109: [LLVM][ARM] Remove options for armv2, 2A, 3 and 3M

peter.smith accepted this revision. peter.smith added a comment. This revision is now accepted and ready to land. LGTM. GCC no longer supports Arm architecture prior to v4 so it is likely the alternative of adding support for v3 is not worth it. The only Arm machines running v2 are likely to be

[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

mizvekov added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5425 Arg *A = C.getArgs().getLastArg(options::OPT_fcrash_diagnostics_dir); - if (CCGenDiagnostics && A) { -SmallString<128> CrashDirectory(A->getValue()); + const char *CrashDirectory = CCGenDiagnost

[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

erichkeane added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5425 Arg *A = C.getArgs().getLastArg(options::OPT_fcrash_diagnostics_dir); - if (CCGenDiagnostics && A) { -SmallString<128> CrashDirectory(A->getValue()); + const char *CrashDirectory = CCGenDiagno

[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

mizvekov added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5425 Arg *A = C.getArgs().getLastArg(options::OPT_fcrash_diagnostics_dir); - if (CCGenDiagnostics && A) { -SmallString<128> CrashDirectory(A->getValue()); + const char *CrashDirectory = CCGenDiagnost

[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

mizvekov added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5425 Arg *A = C.getArgs().getLastArg(options::OPT_fcrash_diagnostics_dir); - if (CCGenDiagnostics && A) { -SmallString<128> CrashDirectory(A->getValue()); + const char *CrashDirectory = CCGenDiagnost

[PATCH] D132550: Changes to code ownership in clang and clang-tidy

aaron.ballman updated this revision to Diff 457289. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Herald added subscribers: sstefan1, arphaman. Herald added a reviewer: jdoerfert. Because I'm touching this file so much anyway to add the GitHub handles, I had some

[PATCH] D133119: [clang-tidy] Add checker 'bugprone-suspicious-realloc-usage'.

balazske created this revision. Herald added subscribers: carlosgalvezp, steakhal, martong, gamesh411, Szelethus, dkrupp, xazax.hun, mgorny. Herald added a project: All. balazske requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits.

[clang] fb38bae - Removing an accidentally duplicated heading; NFC

Author: Aaron Ballman Date: 2022-09-01T11:44:11-04:00 New Revision: fb38baef8727fbdee0babbe74620f4f6755a9fda URL: https://github.com/llvm/llvm-project/commit/fb38baef8727fbdee0babbe74620f4f6755a9fda DIFF: https://github.com/llvm/llvm-project/commit/fb38baef8727fbdee0babbe74620f4f6755a9fda.diff

[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

erichkeane accepted this revision. erichkeane added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5425 Arg *A = C.getArgs().getLastArg(options::OPT_fcrash_diagnostics_dir); - if (CCGenDiagnostics && A) { -SmallString<128> CrashDirectory(A->getValue()); + const

[clang] 9599393 - Revert "[Pipelines] Introduce DAE after ArgumentPromotion"

Author: Arthur Eubanks Date: 2022-09-01T08:52:19-07:00 New Revision: 9599393eebf7b5ef46a144938f593e812dd01a18 URL: https://github.com/llvm/llvm-project/commit/9599393eebf7b5ef46a144938f593e812dd01a18 DIFF: https://github.com/llvm/llvm-project/commit/9599393eebf7b5ef46a144938f593e812dd01a18.diff

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

aeubanks added a comment. I've run into https://github.com/llvm/llvm-project/issues/56503 after this patch so I've reverted this for now while I'm fixing that. Sorry for this patch exposing so many pre-existing issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

mizvekov added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5425 Arg *A = C.getArgs().getLastArg(options::OPT_fcrash_diagnostics_dir); - if (CCGenDiagnostics && A) { -SmallString<128> CrashDirectory(A->getValue()); + const char *CrashDirectory = CCGenDiagnost

[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

aaron.ballman added subscribers: cor3ntin, tahonermann. aaron.ballman added a comment. In D133082#3763829 , @erichkeane wrote: > I don't mind the idea, but wonder if some level of RFC/project-wide decision > should be made here? WDYT @aaron.ballman ?

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

yusuke-kadowaki updated this revision to Diff 457294. yusuke-kadowaki added a comment. - Update tests - Fix document Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132131/new/ https://reviews.llvm.org/D132131 Files: clang/docs/ClangFormatStyleOpt

[PATCH] D133119: [clang-tidy] Add checker 'bugprone-suspicious-realloc-usage'.

steakhal added a comment. Consider adding a test case demonstrating if the checker recognizes and suppresses the check if there are multiple variables referring to the memory being reallocated. If the check does not handle that case, we should probably state this limitation explicitly. And mark

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

yusuke-kadowaki marked an inline comment as done. yusuke-kadowaki added inline comments. Comment at: clang/include/clang/Format/Format.h:141 - /// Alignment options. - /// - /// They can also be read as a whole for compatibility. The choices are: + /// Alignment styles of `

[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

mizvekov added a comment. In D133082#3764256 , @aaron.ballman wrote: > We use environment variables in several other places within the driver, but I > am a bit skittish about adding new ones to correspond to feature flags as > that seems to be somewhat

[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

aaron.ballman added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5427 + ? A->getValue() + : std::getenv("CLANG_CRASH_DIAGNOSTICS_DIR"); + if (CrashDirectory) { mizvekov wrote: > aar

[PATCH] D131979: [clang][UBSan] Fix __builtin_assume_aligned crash

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:7671 + AllArgs, CallType)) +return true; + yihanaa wrote: > rjmccall wrote: > > yihanaa wrote: > > > rjmccall wrote: > > > > You can just pull the argument

[PATCH] D131979: [clang][UBSan] Fix __builtin_assume_aligned crash

yihanaa added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:7671 + AllArgs, CallType)) +return true; + rjmccall wrote: > yihanaa wrote: > > rjmccall wrote: > > > yihanaa wrote: > > > > rjmccall wrote: > > > > > You c

[PATCH] D133066: fix a typo in comment of AddConversionCandidate

aaron.ballman added a comment. The existing comment is correct according to my copy of the C++11 standard, but the standard has changed since C++11 and those words no longer appear in http://eel.is/c++draft/dcl.init.ref#5. Some more investigation is needed, but I suspect the correct action to t

[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

Mordante added a comment. Thanks for working on this! It's really great to get the crash report as an artifact. Comment at: libcxx/test/libcxx/crash.sh.cpp:15 + +#pragma clang __debug parser_crash The libc++ build seems to be green. I assume it was intended to

[PATCH] D133109: [LLVM][ARM] Remove options for armv2, 2A, 3 and 3M

nickdesaulniers accepted this revision. nickdesaulniers added a comment. For the Linux kernel, we're only building v5+ continuously. It looks like the Linux kernel supports v4+ and v3m (for Acorn Risc-PC (Intel StrongARM(R) SA-110)). We've never been able to build that target, and it's not high

[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

mizvekov added inline comments. Comment at: libcxx/test/libcxx/crash.sh.cpp:15 + +#pragma clang __debug parser_crash Mordante wrote: > The libc++ build seems to be green. I assume it was intended to be red so we > can validate the artifact is available in the CI

[PATCH] D133043: [clangd] Fix tests for implicit C function declaration

aaron.ballman added a comment. LGTM, but someone with more clangd experience should do the final sign off (seeing as how I caused the issue in the first place, sorry about that!). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133043/new/ https://r

[PATCH] D125655: [HLSL] add -P option for dxc mode.

python3kgae updated this revision to Diff 457313. python3kgae added a comment. Not need to send -P and -Fi to cc1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125655/new/ https://reviews.llvm.org/D125655 Files: clang/include/clang/Basic/Diagno

  1   2   3   >