kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:3228
+
+ Results = completions(R"objc(
+ Fo^
----------------
nit: just `completions("Fo^", ...)`
================
Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:3274
+ EXPECT_EQ(Reqs2[0], Reqs1[0]);
+ EXPECT_THAT(C, ElementsAre(AllOf(named("Food"),
+ kind(CompletionItemKind::Interface))));
----------------
we actually need to issue the new request in a context that can show
`FoodClass`, as ATM if we were to do filtering during speculative query
response, this test would still pass.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132962/new/
https://reviews.llvm.org/D132962
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
