[PATCH] D105426: [clangd] IWYU as a library: Find all references to symbols in the file

kbobyrev updated this revision to Diff 364709. kbobyrev added a comment. Improve comments, refactor some pieces, add more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105426/new/ https://reviews.llvm.org/D105426 Files: clang-tools-extra/

[PATCH] D96324: [clangd] Rename references to function arguments within the same file

kbobyrev added a comment. Herald added a project: clang-tools-extra. Ping! Do you think this is a reasonable idea? I think if we just check whether there aren't any references to the function outside of the main file we should be safe enough to rename args. Repository: rG LLVM Github Monorep

[PATCH] D106401: [CUDA, MemCpyOpt] Add a flag to force-enable memcpyopt and use it for CUDA.

asbirlea accepted this revision. asbirlea added a comment. This revision is now accepted and ready to land. lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106401/new/ https://reviews.llvm.org/D106401 __

[PATCH] D105426: [clangd] IWYU as a library: Find all references to symbols in the file

kbobyrev updated this revision to Diff 364714. kbobyrev added a comment. Remove some code from the next chunk of IWYU work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105426/new/ https://reviews.llvm.org/D105426 Files: clang-tools-extra/clang

[PATCH] D107624: [clangd] Rename Features.h -> Feature.h to avoid confilct with libstdc++

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, mgorny. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Fixes https://github.

[PATCH] D107559: [clang] Fix libclang linking on Solaris

ro added inline comments. Comment at: clang/tools/libclang/libclang.map:1 -/* If you add a symbol to this file, make sure to add it with the correct - * version. For example, if the LLVM main branch is LLVM 14.0.0, add new - * symbols with the version LLVM_14. - * On platforms w

[PATCH] D107559: [clang] Fix libclang linking on Solaris

ro added a comment. Ah, I forgot: I've meanwhile tested the patch on `x86-64-pc-linux-gnu` (Ubuntu 20.04) where `/usr/bin/ld` is from binutils 2.34: `libclang.so` was versioned just the same without and with the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D106216: Disallow narrowing conversions to bool in noexcept specififers.

cor3ntin updated this revision to Diff 364719. cor3ntin added a comment. Remove whitespace only change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106216/new/ https://reviews.llvm.org/D106216 Files: clang/include/clang/Basic/DiagnosticSemaKind

[PATCH] D106262: [clang][analyzer] Use generic note tag in alpha.unix.Stream .

balazske updated this revision to Diff 364730. balazske added a comment. Using "joined" note tag messages to have bugtype independent note tag functions. New note tags at `ferror` and `feof`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106262/new/

[clang] 22fdf61 - [OpenCL][Docs] Adding builtins requires adding to both now

Author: Sven van Haastregt Date: 2021-08-06T10:21:26+01:00 New Revision: 22fdf617b6103df30ffae6cf469b78036e4ba615 URL: https://github.com/llvm/llvm-project/commit/22fdf617b6103df30ffae6cf469b78036e4ba615 DIFF: https://github.com/llvm/llvm-project/commit/22fdf617b6103df30ffae6cf469b78036e4ba615.

[clang] a5a2f05 - [C++4OpenCL] Introduces __remove_address_space utility

Author: Justas Janickas Date: 2021-08-06T10:40:22+01:00 New Revision: a5a2f05dcc803e79a797fb82dc0932a1a00ac46f URL: https://github.com/llvm/llvm-project/commit/a5a2f05dcc803e79a797fb82dc0932a1a00ac46f DIFF: https://github.com/llvm/llvm-project/commit/a5a2f05dcc803e79a797fb82dc0932a1a00ac46f.dif

[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa5a2f05dcc80: [C++4OpenCL] Introduces __remove_address_space utility (authored by Topotuna). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D105426: [clangd] IWYU as a library: Find all references to symbols in the file

kbobyrev updated this revision to Diff 364735. kbobyrev added a comment. Rebase on top of main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105426/new/ https://reviews.llvm.org/D105426 Files: clang-tools-extra/clangd/CMakeLists.txt clang-too

[PATCH] D107632: [clangd] Avoid "expected one compiler job" by picking the first eligible job.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-extra. This happens in createI

[PATCH] D107633: Set supported target for asan-use-callbacks test

thopre created this revision. thopre added reviewers: kstoimenov, vitalybuka. Herald added subscribers: pengfei, krytarowski. thopre requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Explicitely set x86_64-linux-gnu as a target for asan-use-c

[PATCH] D107595: [clang] fix transformation of template arguments for concept specializations

mizvekov updated this revision to Diff 364742. mizvekov added a comment. - Better naming - Stop casting `SmallString` to `StringRef`, use `.str()` method instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107595/new/ https://reviews.llvm.org/D1

[PATCH] D107624: [clangd] Rename Features.h -> Feature.h to avoid confilct with libstdc++

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107624/new/ https://reviews.llvm.org/D107624 __

[PATCH] D105426: [clangd] IWYU as a library: Find all references to symbols in the file

tschuett added a subscriber: kimgr. tschuett added a comment. @kimgr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105426/new/ https://reviews.llvm.org/D105426 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D107632: [clangd] Avoid "expected one compiler job" by picking the first eligible job.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/CompilerTests.cpp:59 + +TEST(BuildCompilerInvocation, MultiArch) { + TestTU TU = TestTU::withHeaderCode(R"cpp( maybe move this test to `clang/unittests/Frontend/ASTUnitTest.cpp`? some

[PATCH] D107634: [clangd] Strip mutliple arch options

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman, mgrang. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This patch strips all t

[PATCH] D106644: [clang][analyzer] Add standard streams to alpha.unix.Stream checker.

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:227-236 + for (Decl *D : LookupRes) { +D = D->getCanonicalDecl(); +if (!C.getSourceManager().isInSystemHeader(D->getLocation())) + continue; +if (auto *VD = dyn_cast(

[clang] 6385abd - Split 'qualifier on reference type has no effect' out into a new flag

Author: Luna Kirkby Date: 2021-08-06T07:09:16-04:00 New Revision: 6385abd0c4490e0516cb31c0b86c0fbcc052f815 URL: https://github.com/llvm/llvm-project/commit/6385abd0c4490e0516cb31c0b86c0fbcc052f815 DIFF: https://github.com/llvm/llvm-project/commit/6385abd0c4490e0516cb31c0b86c0fbcc052f815.diff L

[PATCH] D107125: [Diagnostic] Split 'qualifier on reference type has no effect' out into a new flag

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit on your behalf in 6385abd0c4490e0516cb31c0b86c0fbcc052f815 , thank you for the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107125

[PATCH] D107636: [analyzer][solver] Compute adjustment for unsupported symbols as well

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, ASDenysPetrov, manas, RedDocMD. Herald added subscribers: dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision.

[PATCH] D107613: [Clang][DiagnosticSemaKinds] combine diagnostic texts

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with some minor tweaks to avoid `hasAttr` followed by `getAttr`. Thanks! Comment at: clang/lib/Sema/SemaDecl.cpp:3356-3359 if (New->hasAttr() &&

[PATCH] D96324: [clangd] Rename references to function arguments within the same file

kadircet added a comment. I think this is a great use case for pseudo parser actually (unfortunately requires some multi-file interactions). In theory we can just fetch all the references, pseudo-parse the files, and update all the declarations & definitions to have the same parameter name. My

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

arsenm added a comment. I think getting too specific as to why in the messages may confuse people. Especially "might not update memory" is not super helpful. It sounds like the instruction is just entirely unreliable Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12212

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

gandhi21299 updated this revision to Diff 364608. gandhi21299 marked 2 inline comments as done. gandhi21299 added a comment. - code formatting - @arsenm Being specific can be useful to some users. I don't see generating optimization remarks as a popular thing that every user will trigger so only

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

gandhi21299 updated this revision to Diff 364609. gandhi21299 added a comment. - removed unnecessary header includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 Files: clang/test/CodeGenCUDA/fp-atom

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

gandhi21299 updated this revision to Diff 364619. gandhi21299 added a comment. - eliminated trailing whitespaces in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 Files: clang/test/CodeGenCUDA/fp

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

rampitec added inline comments. Comment at: clang/test/CodeGenOpenCL/fp-atomics-optremarks-gfx90a.cl:23 + +// GFX90A-HW: A floating-point atomic instruction will generate an unsafe hardware instruction which may fail to update memory [-Rpass=si-lower] +// GFX90A-HW-LABEL: test_a

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

gandhi21299 added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12120 + OptimizationRemarkEmitter *ORE, + OptimizationRemark OptRemark) { + ORE->emit([&]() { return OptRemark; }); rampitec wrote: > Why

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

gandhi21299 updated this revision to Diff 364687. gandhi21299 added a comment. - changed remarks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 Files: clang/test/CodeGenCUDA/fp-atomics-optremarks.cu

[PATCH] D107637: [clangd] Canonicalize inputs provided with `--`

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. We already strip all the inputs

[PATCH] D104351: [HeaderSearch] Use `isImport` only for imported headers and not for `#pragma once`.

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. Ok, this makes sense. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104351/new/ https://reviews.llvm.org/D104351

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

kito-cheng updated this revision to Diff 364758. kito-cheng marked an inline comment as done. kito-cheng added a comment. Changes: - Forbid copy ctor and operator= for RISCVISAInfo. - Move RISCVISAInfo's constructor to private. - Refine RISCVISAInfo::parse* and made they become static function. -

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

kito-cheng added inline comments. Comment at: llvm/include/llvm/Support/RISCVISAInfo.h:31 +public: + RISCVISAInfo() : XLen(0), FLen(0) {} + jrtc27 wrote: > Does Exts need initialising to be empty here? I can never remember std::map has default construct that wil

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

jrtc27 added inline comments. Comment at: llvm/include/llvm/Support/RISCVISAInfo.h:49-50 + /// Parse RISCV ISA info from arch string. + static std::unique_ptr + parseArchString(llvm::Error &Error, StringRef Arch, + bool EnableExperimentalExtension, ---

[PATCH] D107634: [clangd] Strip mutliple arch options

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:225 + llvm::SmallVector IndicesToDrop; + // Having multiple architecture options (e.g. when building FA

[PATCH] D107637: [clangd] Canonicalize inputs provided with `--`

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:250 + ArgList.getLastArgNoClaim(driver::options::OPT__DASH_DASH)) { +for (auto I = 0U; I <= Da

[PATCH] D107365: clangd: Make documentation property of completion items more similar

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG but could you please add a test showing this difference? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107365/new/ https://reviews.llvm

[clang] 4aafd5f - [clang] Remove misleading assertion in FullSourceLoc

Author: Jan Svoboda Date: 2021-08-06T14:48:28+02:00 New Revision: 4aafd5f00c2a772337ec065d4542ef158453a343 URL: https://github.com/llvm/llvm-project/commit/4aafd5f00c2a772337ec065d4542ef158453a343 DIFF: https://github.com/llvm/llvm-project/commit/4aafd5f00c2a772337ec065d4542ef158453a343.diff L

[PATCH] D106862: [clang] Remove misleading assertion in FullSourceLoc

This revision was automatically updated to reflect the committed changes. Closed by commit rG4aafd5f00c2a: [clang] Remove misleading assertion in FullSourceLoc (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106862/new/ htt

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

aaron.ballman added inline comments. Comment at: clang/test/CXX/basic/basic.def.odr/p2-typeid.cpp:53-62 +consteval T *make_t() { return new T; } + +void func() { + (void)typeid(*null_s()); + (void)typeid(*make_s()); + (void)typeid(*null_t()); // expected-warning {{expression w

[PATCH] D107634: [clangd] Strip mutliple arch options

kadircet marked 3 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:225 + llvm::SmallVector IndicesToDrop; + // Having multiple architecture options (e.g. when building FAT binaries) sammccall wr

[PATCH] D107634: [clangd] Strip mutliple arch options

kadircet updated this revision to Diff 364763. kadircet marked an inline comment as done. kadircet added a comment. - Update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107634/new/ https://reviews.llvm.org/D107634 Files: clang-tools-e

[PATCH] D107637: [clangd] Canonicalize inputs provided with `--`

kadircet updated this revision to Diff 364764. kadircet marked an inline comment as done. kadircet added a comment. - Cmd.resize instead of dropping arguments trailing `--` one by one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107637/new/ https

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin updated this revision to Diff 364765. cor3ntin added a comment. Remove WS changes and cleanup tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106302/new/ https://reviews.llvm.org/D106302 Files: clang/lib/Sema/SemaExpr.cpp clang/te

[PATCH] D105426: [clangd] IWYU as a library: Find all references to symbols in the file

sammccall added a comment. First some thoughts on names... (hopefully to avoid some confusion) IWYU might be used here to mean three things: - the IWYU coding style/policy that says you should `#include` headers for the symbols you make use of, and no others - the IWYU

[PATCH] D107244: [AIX] Define _ARCH_PPC64 macro for 32-bit

Jake-Egan updated this revision to Diff 364766. Jake-Egan added a comment. Updated the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107244/new/ https://reviews.llvm.org/D107244 Files: clang/lib/Basic/Targets/PPC.cpp clang/test/Prepro

[clang-tools-extra] 3bf7798 - [clangd] Strip mutliple arch options

Author: Kadir Cetinkaya Date: 2021-08-06T15:04:04+02:00 New Revision: 3bf77980d934c4aa383e4ea9a9a5de86598bea9b URL: https://github.com/llvm/llvm-project/commit/3bf77980d934c4aa383e4ea9a9a5de86598bea9b DIFF: https://github.com/llvm/llvm-project/commit/3bf77980d934c4aa383e4ea9a9a5de86598bea9b.dif

[clang-tools-extra] 79c2616 - [clangd] Canonicalize inputs provided with `--`

Author: Kadir Cetinkaya Date: 2021-08-06T15:04:04+02:00 New Revision: 79c2616d315f54d72bcdeebb6576c84be7b585d8 URL: https://github.com/llvm/llvm-project/commit/79c2616d315f54d72bcdeebb6576c84be7b585d8 DIFF: https://github.com/llvm/llvm-project/commit/79c2616d315f54d72bcdeebb6576c84be7b585d8.dif

[PATCH] D107634: [clangd] Strip mutliple arch options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3bf77980d934: [clangd] Strip mutliple arch options (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D107637: [clangd] Canonicalize inputs provided with `--`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG79c2616d315f: [clangd] Canonicalize inputs provided with `--` (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D107637: [clangd] Canonicalize inputs provided with `--`

kadircet added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:250 + ArgList.getLastArgNoClaim(driver::options::OPT__DASH_DASH)) { +for (auto I = 0U; I <= DashDash->getNumValues(); ++I) + IndicesToDrop.push_back(DashDash->getIndex() + I

[PATCH] D107641: [clang-tidy] fix duplicate '{}' in cppcoreguidelines-pro-type-member-init

Sockke created this revision. Sockke added reviewers: aaron.ballman, gribozavr, flx, whisperity, steven.zhang, MTC. Herald added subscribers: shchenz, rnkovacs, kbarton, xazax.hun, nemanjai. Sockke requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscri

[PATCH] D106216: Disallow narrowing conversions to bool in noexcept specififers.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExceptionSpec.cpp:81 -ExprResult Sema::ActOnNoexceptSpec(SourceLocation NoexceptLoc, - Expr *NoexceptExpr, +ExprResult Sema::ActOnNoexceptSpec(SourceLocation, Expr *NoexceptExp

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin updated this revision to Diff 364778. cor3ntin added a comment. Changing release version to clang 14 in cxx_status Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106302/new/ https://reviews.llvm.org/D106302 Files: clang/lib/Sema/SemaExpr

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106302/new/ https://reviews.llvm.org/D106302

[PATCH] D107242: [AIX] Define __HOS_AIX__ macro

Jake-Egan updated this revision to Diff 364779. Jake-Egan added a comment. Use a temp rather than a local var. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107242/new/ https://reviews.llvm.org/D107242 Files: clang/lib/Basic/Targets/PPC.cpp cl

[PATCH] D106216: Disallow narrowing conversions to bool in noexcept specififers.

cor3ntin added inline comments. Comment at: clang/unittests/ASTMatchers/ASTMatchersNodeTest.cpp:879 EXPECT_TRUE(notMatches("void foo() noexcept;", NoExcept)); - EXPECT_TRUE(notMatches("void foo() noexcept(1+1);", NoExcept)); + EXPECT_TRUE(notMatches("void foo() noexcept(0+1)

[PATCH] D107506: [PowerPC][AIX] Warn when using pragma align(packed) on AIX.

sfertile updated this revision to Diff 364782. sfertile added a comment. Moved the diagnostic emission to ` Sema::ActOnTagFinishDefinition` as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107506/new/ https://reviews.llvm.org/D107506 Fi

[PATCH] D106216: Disallow narrowing conversions to bool in noexcept specififers.

aaron.ballman added inline comments. Comment at: clang/unittests/ASTMatchers/ASTMatchersNodeTest.cpp:879 EXPECT_TRUE(notMatches("void foo() noexcept;", NoExcept)); - EXPECT_TRUE(notMatches("void foo() noexcept(1+1);", NoExcept)); + EXPECT_TRUE(notMatches("void foo() noexcept

[PATCH] D106216: Disallow narrowing conversions to bool in noexcept specififers.

cor3ntin updated this revision to Diff 364783. cor3ntin added a comment. - Update the release version to Clang 14 in cxx_status - Remove unused parameter - Remove WS only changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106216/new/ https://rev

[clang] 420e1d4 - [AIX] Define __THW_BIG_ENDIAN__ macro

Author: Jake Egan Date: 2021-08-06T09:46:59-04:00 New Revision: 420e1d4cf45d78a6f9edb935f44dfa4249de16f4 URL: https://github.com/llvm/llvm-project/commit/420e1d4cf45d78a6f9edb935f44dfa4249de16f4 DIFF: https://github.com/llvm/llvm-project/commit/420e1d4cf45d78a6f9edb935f44dfa4249de16f4.diff LOG

[PATCH] D107241: [AIX] Define __THW_BIG_ENDIAN__ macro

This revision was automatically updated to reflect the committed changes. Closed by commit rG420e1d4cf45d: [AIX] Define __THW_BIG_ENDIAN__ macro (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107241/new/ https://reviews.llvm.

[PATCH] D106216: Disallow narrowing conversions to bool in noexcept specififers.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106216/new/ https://reviews.llvm.org/D106216

[PATCH] D107506: [PowerPC][AIX] Warn when using pragma align(packed) on AIX.

sfertile added a comment. In D107506#2931095 , @sfertile wrote: > Moved the diagnostic emission to ` Sema::ActOnTagFinishDefinition` as > suggested. Sorry, uploaded wrong diff. Will updated again shortly. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D107244: [AIX] Define _ARCH_PPC64 macro for 32-bit

cebowleratibm accepted this revision. cebowleratibm added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107244/new/ https://reviews.llvm.org/D107244

[clang] 3189dd2 - [AIX] Define __THW_PPC__ macro

Author: Jake Egan Date: 2021-08-06T09:52:26-04:00 New Revision: 3189dd205a581272b9a0cfc614e8f341495fc716 URL: https://github.com/llvm/llvm-project/commit/3189dd205a581272b9a0cfc614e8f341495fc716 DIFF: https://github.com/llvm/llvm-project/commit/3189dd205a581272b9a0cfc614e8f341495fc716.diff LOG

[PATCH] D107243: [AIX] Define __THW_PPC__ macro

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3189dd205a58: [AIX] Define __THW_PPC__ macro (authored by Jake-Egan). Changed prior to commit: https://reviews.llvm.org/D107243?vs=363354&id=36478

[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86InstrAVX512.td:82 + PatFrags ScalarIntMemFrags = !if (!eq (EltTypeName, "f16"), + !cast("sse_load_f16"), + !if (!eq (EltTypeName, "f32"), -

[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

LuoYuanke added inline comments. Comment at: llvm/test/CodeGen/X86/vector-reduce-fmax-nnan.ll:374 +; SSE-NEXT:movl %edi, %ebp +; SSE-NEXT:movzwl %bx, %edi ; SSE-NEXT:callq __gnu_h2f_ieee@PLT Why this test case changes? Shall we add -mattr=+avx512fp16

[PATCH] D106644: [clang][analyzer] Add standard streams to alpha.unix.Stream checker.

balazske updated this revision to Diff 364787. balazske added a comment. Init std declarations and FILE type only once. Make a lambda not operate on captured data. Simplify test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106644/new/ https://rev

[PATCH] D107242: [AIX] Define __HOS_AIX__ macro

cebowleratibm accepted this revision. cebowleratibm added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107242/new/ https://reviews.llvm.org/D107242 _

[clang] 3c8e94b - Disallow narrowing conversions to bool in noexcept specififers

Author: Corentin Jabot Date: 2021-08-06T10:26:39-04:00 New Revision: 3c8e94bc20e5829ab5167d21d242b6b624dd934e URL: https://github.com/llvm/llvm-project/commit/3c8e94bc20e5829ab5167d21d242b6b624dd934e DIFF: https://github.com/llvm/llvm-project/commit/3c8e94bc20e5829ab5167d21d242b6b624dd934e.diff

[PATCH] D106216: Disallow narrowing conversions to bool in noexcept specififers.

aaron.ballman closed this revision. aaron.ballman added a comment. I've committed on your behalf in 3c8e94bc20e5829ab5167d21d242b6b624dd934e , thank you for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D107365: clangd: Make documentation property of completion items more similar

ckandeler updated this revision to Diff 364790. ckandeler added a comment. Added test coverage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107365/new/ https://reviews.llvm.org/D107365 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-t

[clang] 131b462 - Implement P1937 consteval in unevaluated contexts

Author: Corentin Jabot Date: 2021-08-06T10:29:28-04:00 New Revision: 131b4620ee7847102479f399ce3e35a3c1cb5461 URL: https://github.com/llvm/llvm-project/commit/131b4620ee7847102479f399ce3e35a3c1cb5461 DIFF: https://github.com/llvm/llvm-project/commit/131b4620ee7847102479f399ce3e35a3c1cb5461.diff

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

aaron.ballman closed this revision. aaron.ballman added a comment. I have commit on your behalf in 131b4620ee7847102479f399ce3e35a3c1cb5461 , thank you for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D107138: [PowerPC] Implement cmplxl builtins

NeHuang added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-complex.c:45 + // CHECK-AIX-NEXT: ret { double, double } %.fca.1.insert + return __cmplxl(lda, ldb); +} nemanjai wrote: > We really only need this test case and we should be abl

[PATCH] D107646: [PowerPC] Fix the frame addresss computing return address for `__builtin_return_address`

NeHuang created this revision. NeHuang added reviewers: nemanjai, stefanp, PowerPC. NeHuang added a project: LLVM. Herald added subscribers: shchenz, kbarton, hiraditya. NeHuang requested review of this revision. When depth > 0, callee frame address is used to compute the return address of callee

[clang] 869d07e - [AIX] Define __HOS_AIX__ macro

Author: Jake Egan Date: 2021-08-06T10:40:13-04:00 New Revision: 869d07ee88a4355f5954ef9e2b2e79ceff225ddb URL: https://github.com/llvm/llvm-project/commit/869d07ee88a4355f5954ef9e2b2e79ceff225ddb DIFF: https://github.com/llvm/llvm-project/commit/869d07ee88a4355f5954ef9e2b2e79ceff225ddb.diff LOG

[PATCH] D107242: [AIX] Define __HOS_AIX__ macro

This revision was automatically updated to reflect the committed changes. Closed by commit rG869d07ee88a4: [AIX] Define __HOS_AIX__ macro (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107242/new/ https://reviews.llvm.org/D10

[clang] 41bcfe8 - [AIX] Define _ARCH_PPC64 macro for 32-bit

Author: Jake Egan Date: 2021-08-06T10:42:44-04:00 New Revision: 41bcfe81742ed6462096ccb42aa5f2b9d67027fc URL: https://github.com/llvm/llvm-project/commit/41bcfe81742ed6462096ccb42aa5f2b9d67027fc DIFF: https://github.com/llvm/llvm-project/commit/41bcfe81742ed6462096ccb42aa5f2b9d67027fc.diff LOG

[PATCH] D107244: [AIX] Define _ARCH_PPC64 macro for 32-bit

This revision was automatically updated to reflect the committed changes. Closed by commit rG41bcfe81742e: [AIX] Define _ARCH_PPC64 macro for 32-bit (authored by Jake-Egan). Changed prior to commit: https://reviews.llvm.org/D107244?vs=364766&id=364793#toc Repository: rG LLVM Github Monorepo

[PATCH] D107647: Remove depracated built-ins for MMA and replace with new built-ins

saghir created this revision. Herald added subscribers: kbarton, hiraditya, nemanjai, qcolombet, MatzeB. saghir requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.or

[PATCH] D107648: [OpenCL] Clang diagnostics allow reporting C++ for OpenCL version.

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Herald added a reviewer: aaron.ballman. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some Clang diagnostics could on

[PATCH] D107648: [OpenCL] Clang diagnostics allow reporting C++ for OpenCL version.

Topotuna updated this revision to Diff 364796. Topotuna added a comment. Diagnostic argument index updated (from `%1` to `%2`) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107648/new/ https://reviews.llvm.org/D107648 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clan

[PATCH] D107649: [OpenMP]Fix PR51349: Remove AlwaysInline for if regions.

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, mikerice. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. After D94315 we add

[PATCH] D106644: [clang][analyzer] Add standard streams to alpha.unix.Stream checker.

steakhal added a comment. Let's see if we can cache the stream symbols across top-level analyses. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:476 + + for (Decl *D : LookupRes) { +D = D->getCanonicalDecl(); Comment at

[PATCH] D107636: [analyzer][solver] Compute adjustment for unsupported symbols as well

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Seems reasonable to me. Let's wait for someone else as well. This is a really elegant patch, I should tell! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D107636: [analyzer][solver] Compute adjustment for unsupported symbols as well

vsavchenko added a comment. In D107636#2931302 , @steakhal wrote: > Seems reasonable to me. Let's wait for someone else as well. Sure, NP. > This is a really elegant patch, I should tell! Thanks! I guess my take on this, that this path to the solver j

[PATCH] D107611: [ARC] Add codegen for llvm.ctlz intrinsic for the ARC backend

thomasjohns updated this revision to Diff 364806. thomasjohns added a comment. llvm clang-tidy rule: prefer `Register` over `unsinged int`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107611/new/ https://reviews.llvm.org/D107611 Files: clang/lib/Basic/Targets/ARC.h llvm/lib/Targe

[PATCH] D107539: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images

Anastasia added a subscriber: svenvh. Anastasia added a comment. LGTM! Thanks. CC to @azabaznov for any final feedback. FYI this has not been officially announced but in `clang-14` we would like to transition away from using the huge hard to maintain `opencl-c.h` in favour of a more concise an

[PATCH] D106644: [clang][analyzer] Add standard streams to alpha.unix.Stream checker.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:504 + + OrigStdin = findStdStream("stdin", C); + OrigStdout = findStdStream("stdout", C); steakhal wrote: > balazske wrote

[PATCH] D106644: [clang][analyzer] Add standard streams to alpha.unix.Stream checker.

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:504 + + OrigStdin = findStdStream("stdin", C); + OrigStdout = findStdStream("stdout", C); balazske wrote: > steakhal wrote: > > balazske wrote: > > > steakhal wrote:

[PATCH] D105426: [clangd] IWYU as a library: Find all references to symbols in the file

sammccall added a comment. Thanks, this scope looks good for a first patch! Comment at: clang-tools-extra/clangd/IWYU.cpp:18 + +/// Main "driver" of the IWYU symbol usage discovery mechanism. Crawler +/// traverses the AST and feeds in the locations of (sometimes implicitly) us

[PATCH] D107611: [ARC] Add codegen for llvm.ctlz intrinsic for the ARC backend

marksl added inline comments. Comment at: llvm/lib/Target/ARC/ARCExpandPseudos.cpp:86 + // %R2 = RSUB_cc_rru6 %R2, 31, pred:2, %STATUS + MachineInstr &SI = *SII; + const MachineOperand &Dest = SI.getOperand(0); I know you're following ExpandStore above in us

[PATCH] D107553: [C++4OpenCL] Initialize temporaries in the private address space

Anastasia added inline comments. Comment at: clang/include/clang/Sema/Initialization.h:341 +QualType Type = TypeInfo->getType(); +if (Context.getLangOpts().OpenCL && !Type.hasAddressSpace()) + Type = Context.getAddrSpaceQualType(Type, LangAS::opencl_private); ---

  1   2   >