[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence updated this revision to Diff 312395. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 Files: llvm/lib/Target/RISCV/Disassembler/RISCVDisassembler.cpp llvm/lib/Target/RISCV/RI

[clang] 7f19712 - [clang][nfc] Update comment to match the opening `{`

Author: Andrzej Warzynski Date: 2020-12-17T09:04:41Z New Revision: 7f19712a6a9e65bdc9a9843ea488030bc12f3acc URL: https://github.com/llvm/llvm-project/commit/7f19712a6a9e65bdc9a9843ea488030bc12f3acc DIFF: https://github.com/llvm/llvm-project/commit/7f19712a6a9e65bdc9a9843ea488030bc12f3acc.diff

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

awarzynski updated this revision to Diff 312400. awarzynski added a comment. Rebased on top of main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92854/new/ https://reviews.llvm.org/D92854 Files: clang/include/clang/Driver/Options.td flang/inc

[PATCH] D93296: [clang-format] PR35514 brace-init member initializers in function-try-blocks are not formatted correctly

MyDeveloperDay updated this revision to Diff 312407. MyDeveloperDay added a comment. Add additional unit test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93296/new/ https://reviews.llvm.org/D93296 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.c

[clang] db41c0b - [clang-format] PR35514 brace-init member initializers in function-try-blocks are not formatted correctly

Author: mydeveloperday Date: 2020-12-17T09:39:37Z New Revision: db41c0b357d55ccd6206ff262dc50ed38f0d5474 URL: https://github.com/llvm/llvm-project/commit/db41c0b357d55ccd6206ff262dc50ed38f0d5474 DIFF: https://github.com/llvm/llvm-project/commit/db41c0b357d55ccd6206ff262dc50ed38f0d5474.diff LOG

[PATCH] D93296: [clang-format] PR35514 brace-init member initializers in function-try-blocks are not formatted correctly

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb41c0b357d5: [clang-format] PR35514 brace-init member initializers in function-try-blocks… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D93221: [ARM] Add clang command line support for -mharden-sls=

ostannard added a comment. Why is this restricted to v7-A or later? The DSB and ISB instructions have existed since v6T2 and v6M. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93221/new/ https://reviews.llvm.org/D93221 ___

[PATCH] D93231: [ARM] Adding v8.7-A command-line support for the ARM target

ostannard accepted this revision. ostannard added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93231/new/ https://reviews.llvm.org/D93231 ___

[clang] 9231045 - Make LLVM build in C++20 mode

Author: Barry Revzin Date: 2020-12-17T10:44:10Z New Revision: 92310454bf0f1f9686f38afd11756c7d046495c9 URL: https://github.com/llvm/llvm-project/commit/92310454bf0f1f9686f38afd11756c7d046495c9 DIFF: https://github.com/llvm/llvm-project/commit/92310454bf0f1f9686f38afd11756c7d046495c9.diff LOG:

[PATCH] D78938: Make LLVM build in C++20 mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG92310454bf0f: Make LLVM build in C++20 mode (authored by BRevzin, committed by nlopes). Changed prior to commit: https://reviews.llvm.org/D78938?v

[clang] 9ed8e0c - [NFC] Reduce include files dependency and AA header cleanup (part 2).

Author: dfukalov Date: 2020-12-17T14:04:48+03:00 New Revision: 9ed8e0caab9b6f638e82979f6fdf60d67ce65b92 URL: https://github.com/llvm/llvm-project/commit/9ed8e0caab9b6f638e82979f6fdf60d67ce65b92 DIFF: https://github.com/llvm/llvm-project/commit/9ed8e0caab9b6f638e82979f6fdf60d67ce65b92.diff LOG:

[PATCH] D92852: [NFC] Reduce include files dependency and AA header cleanup (part 2).

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ed8e0caab9b: [NFC] Reduce include files dependency and AA header cleanup (part 2). (authored by dfukalov). Changed prior to commit: https://revie

[PATCH] D78938: Make LLVM build in C++20 mode

RKSimon added a comment. @BRevzin @nlopes This is causing MSVC build failure please can you take a look? E:\llvm\llvm-project\llvm\include\llvm/DebugInfo/DWARF/DWARFDie.h(405): note: see declaration of 'std::reverse_iterator' E:\llvm\llvm-project\llvm\lib\DWARFLinker\DWARFLinker.cpp(383): no

[PATCH] D93227: [clangd] Smarter hover on auto and decltype

qchateau updated this revision to Diff 312432. qchateau added a comment. - Rebase on master after D92041 - Remove the usage of the "Documentation" field - Use the `TypeAlias` Kind on auto and decltype - Move code related to hover on `this` in a new function - Upda

[PATCH] D93102: [Clang][Sema] Detect section type conflicts between functions and variables

tmatheson updated this revision to Diff 312434. tmatheson added a comment. Minor syntax change, fix CodeGen/attributes.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93102/new/ https://reviews.llvm.org/D93102 Files: clang/include/clang/AST/ASTC

[PATCH] D93227: [clangd] Smarter hover on auto and decltype

qchateau added a comment. > We can't easily add new SymbolKinds (it's an enum we don't own, which we > should fix, but that's a yak-shave). But `TypeAlias` almost fits these roles > for auto. Yes I originally wanted to have "deduced-type `auto`" but I realized it would not be easy. I did not t

[clang-tools-extra] 894c476 - [clangd] Add llvm:: qualifier to work around GCC bug. NFC

Author: Sam McCall Date: 2020-12-17T12:51:12+01:00 New Revision: 894c4761c67ac850e156a26aa427035a811d7aed URL: https://github.com/llvm/llvm-project/commit/894c4761c67ac850e156a26aa427035a811d7aed DIFF: https://github.com/llvm/llvm-project/commit/894c4761c67ac850e156a26aa427035a811d7aed.diff LO

[PATCH] D93428: [AArch64] Add bti note property when compiling asm files with -mbranch-protection=bti

danielkiss added a comment. The `.note.gnu.property` is already generated when C/C++ files are compiled with `-mbranch-protection=bti`. `-mmark-bti-property` is only for assembly file where the `.note.gnu.property` should be added manually otherwise. Do you have any reproducer where C/C++ beh

[PATCH] D93102: [Clang][Sema] Detect section type conflicts between functions and variables

tmatheson added a comment. In D93102#2458433 , @aaron.ballman wrote: > LGTM aside from a minor nit. Thank you for the patch! Do you need me to > commit on your behalf? If so, are you okay with `Tomas Matheson > ` for patch attribution? Thanks for the r

[PATCH] D92788: [clangd] NFC: Use SmallVector where possible

sammccall added a comment. Should be fixed in 894c4761c67ac850e156a26aa427035a811d7aed , LMK if this workaround doesn't work Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92788/n

[PATCH] D93393: [clangd] Ignore the static index refs from the dynamic index files.

ArcsinX updated this revision to Diff 312440. ArcsinX added a comment. bool SymbolIndex::hasFile(llvm::StringRef) => llvm::unique_function SymbolIndex::indexedFiles() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93393/new/ https://reviews.llvm.or

[PATCH] D93393: [clangd] Ignore the static index refs from the dynamic index files.

ArcsinX added a comment. Thanks for your reply. I have updated the patch (changed signature of `hasFile`), but remote-index scenario is not clear for me yet. In D93393#2458168 , @sammccall wrote: > Implementing a pseudo-batch form of hasFiles as an RPC f

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence updated this revision to Diff 312444. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 Files: llvm/lib/Target/RISCV/Disassembler/RISCVDisassembler.cpp llvm/lib/Target/RISCV/RISCV.td llvm/lib/Target/RISCV/RISCVIns

[PATCH] D93393: [clangd] Ignore the static index refs from the dynamic index files.

sammccall added a comment. Thanks, this should work with some slight tweaks. Biggest question is if we really need/want to allow this function to be null. Comment at: clang-tools-extra/clangd/index/Index.h:127 + /// index or not. + virtual llvm::unique_function indexedFiles()

[PATCH] D93393: [clangd] Ignore the static index refs from the dynamic index files.

sammccall added a subscriber: kbobyrev. sammccall added a comment. In D93393#2460066 , @ArcsinX wrote: > Thanks for your reply. I have updated the patch (changed signature of > `hasFile`), but remote-index scenario is not clear for me yet. Sorry, I didn'

[PATCH] D93452: [clangd] Trim memory after buildINdex

qchateau created this revision. qchateau added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. qchateau requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This diff addresses the issue of

[PATCH] D86137: Add -Wno-error=unknown flag to clang-format.

njames93 added a comment. Herald added a subscriber: dexonsmith. I think the `=` in the option name is confusing the option parser, ➜ clang-format --Wno-error=unknown clang-format: Unknown command line argument '--Wno-error=unknown'. Try: 'clang-format --help' clang-format: Did you mean

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence added a comment. Thanks. I've updated it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D92445: [PowerPC] Add powerpcle target.

q66 added a comment. I've tested the patch (applied to LLVM11) and can confirm it works. There have been some changes/fixes I needed to do, which I already reported on IRC, so I will not include them here (Bdragon28 should just be able to apply them and push them out) Right now, I have a full

[PATCH] D92445: [PowerPC] Add powerpcle target.

MaskRay added inline comments. Comment at: clang/lib/Basic/Targets/PPC.h:358 resetDataLayout("E-m:a-p:32:32-i64:64-n32"); +else if ((Triple.getArch() == llvm::Triple::ppcle)) + resetDataLayout("e-m:e-p:32:32-i64:64-n32"); redundant `()`

[PATCH] D93453: [flang][driver] Add support for `-I`

FarisRehman created this revision. Herald added a reviewer: sscalpone. Herald added a subscriber: dang. FarisRehman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add support for option -I in the Flang driver. This will allow for included

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

awarzynski marked an inline comment as done. awarzynski added a comment. @clementval & @SouraVX - thank you for your comments! I will upload an updated version shortly. Comment at: clang/include/clang/Driver/Options.td:4329 HelpText<"Generate machine code, but discard outpu

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

awarzynski updated this revision to Diff 312457. awarzynski added a comment. Address PR comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93301/new/ https://reviews.llvm.org/D93301 Files: clang/include/clang/Driver/Options.td clang/lib/Dr

[PATCH] D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Thank you for this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92800/new/ https://reviews.llvm.org/D92800 __

[PATCH] D91776: [ARM][AAarch64] Initial command-line support for v8.7-A

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc4d851b07903: [ARM][AAarch64] Initial command-line support for v8.7-A (authored by pratlucas). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] c4d851b - [ARM][AAarch64] Initial command-line support for v8.7-A

Author: Lucas Prates Date: 2020-12-17T13:47:28Z New Revision: c4d851b079037e9b7dd3f8613dd1c8a4f3db99fa URL: https://github.com/llvm/llvm-project/commit/c4d851b079037e9b7dd3f8613dd1c8a4f3db99fa DIFF: https://github.com/llvm/llvm-project/commit/c4d851b079037e9b7dd3f8613dd1c8a4f3db99fa.diff LOG:

[PATCH] D93231: [ARM] Adding v8.7-A command-line support for the ARM target

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc5046ebdf6e4: [ARM] Adding v8.7-A command-line support for the ARM target (authored by pratlucas). Repository: rG LLVM Github Monorepo CHANGES SI

[clang] c5046eb - [ARM] Adding v8.7-A command-line support for the ARM target

Author: Lucas Prates Date: 2020-12-17T13:48:54Z New Revision: c5046ebdf6e4be9300677c538ecaa61648c31248 URL: https://github.com/llvm/llvm-project/commit/c5046ebdf6e4be9300677c538ecaa61648c31248 DIFF: https://github.com/llvm/llvm-project/commit/c5046ebdf6e4be9300677c538ecaa61648c31248.diff LOG:

[PATCH] D93110: [analyzer] Implement a first version of suppressions via attributes

vsavchenko added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2366 let Args = [VariadicStringArgument<"DiagnosticIdentifiers">]; let Documentation = [SuppressDocs]; } aaron.ballman wrote: > The documentation will need to be updated for th

[clang-tools-extra] 64badec - [clang-tidy][NFC] Reduce copies of Intrusive..FileSystem

Author: Nathan James Date: 2020-12-17T14:09:08Z New Revision: 64badecd447f2358812a2e747b2683d34071f5a5 URL: https://github.com/llvm/llvm-project/commit/64badecd447f2358812a2e747b2683d34071f5a5 DIFF: https://github.com/llvm/llvm-project/commit/64badecd447f2358812a2e747b2683d34071f5a5.diff LOG:

[PATCH] D78938: Make LLVM build in C++20 mode

nlopes added a comment. In D78938#2459973 , @RKSimon wrote: > @BRevzin @nlopes This is causing MSVC build failure please can you take a > look? > > E:\llvm\llvm-project\llvm\include\llvm/DebugInfo/DWARF/DWARFDie.h(405): > note: see declaration of 'std:

[PATCH] D93110: [analyzer] Implement a first version of suppressions via attributes

vsavchenko added a comment. In D93110#2458613 , @aaron.ballman wrote: > Have you explored how this attribute will work with clang frontend > diagnostics or clang-tidy diagnostics? Actually, this attribute is not used anywhere in the codebase (even in `

[PATCH] D93458: clang-cl: Remove /Zd flag

thakis created this revision. thakis added a reviewer: aeubanks. Herald added a subscriber: dang. thakis requested review of this revision. cl.exe doesn't understand Zd (in either MSVC 2017 or 2019), so neiter should we. It used to do the same as `-gline-tables-only` which is exposed as clang-cl f

[PATCH] D86137: Add -Wno-error=unknown flag to clang-format.

fodinabor added a comment. I can reproduce the issue, but not sure what introduced this. In D86137#2460135 , @njames93 wrote: > Should the name be changed to `Wno-error-unknown`? I don't think this should be the solution, as we aimed for the common synta

[PATCH] D93452: [clangd] Trim memory after buildINdex

njames93 added a comment. `malloc_trim` isn't available on windows so this wont work, so this should likely be ifdef'd out on windows builds. Side note is this memory failing to free behaviour observed on windows? Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:51 +v

[clang] 5e31e22 - Remove Python2 fallback and only advertise Python3 in the doc

Author: serge-sans-paille Date: 2020-12-17T15:40:16+01:00 New Revision: 5e31e226b5b2b682607a6578ff5adb33daf4fe39 URL: https://github.com/llvm/llvm-project/commit/5e31e226b5b2b682607a6578ff5adb33daf4fe39 DIFF: https://github.com/llvm/llvm-project/commit/5e31e226b5b2b682607a6578ff5adb33daf4fe39.d

[PATCH] D93227: [clangd] Smarter hover on auto and decltype

sammccall added a comment. Agree with all the conclusions you've come to here. Main two issues are: - the new traversal added to patch up some cases isn't the right approach IMO. - some accidental regressions I'd also like to distinguish decltype(auto) from other decltypes, but it's a problem w

[PATCH] D78938: Make LLVM build in C++20 mode

RKSimon added a comment. In D78938#2460360 , @nlopes wrote: > Just saw that you fixed it already. Thank you! 'Avoided' might be a better term than 'fixed' tbh - I didn't delve much into why it was breaking, or what effect it has on C++20 work. Reposit

[PATCH] D93459: Fix -Wno-error= parsing in clang-format.

fodinabor created this revision. fodinabor added reviewers: MyDeveloperDay, JakeMerdichAMD. fodinabor requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As noted in https://reviews.llvm.org/D86137#2460135 parsing of the clang-format parameter

[PATCH] D93459: Fix -Wno-error= parsing in clang-format.

fodinabor added a comment. Quoting my questions from the other review, as it should be more appropriate to discuss this here: The formatting of the `--help` page is still slightly off (I guess `cl::values` descriptions are supposed to be single line), so I guess I have to investigate my format

[clang] 01089c8 - [InstCombine] Preserve !annotation on newly created instructions.

Author: Florian Hahn Date: 2020-12-17T15:20:23Z New Revision: 01089c876bff43a7cde1cb9b1ef8c128169ec5b4 URL: https://github.com/llvm/llvm-project/commit/01089c876bff43a7cde1cb9b1ef8c128169ec5b4 DIFF: https://github.com/llvm/llvm-project/commit/01089c876bff43a7cde1cb9b1ef8c128169ec5b4.diff LOG:

[PATCH] D91444: [InstCombine] Preserve !annotation on newly created instructions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG01089c876bff: [InstCombine] Preserve !annotation on newly created instructions. (authored by fhahn). Changed prior to commit: https://reviews.llvm

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

StephenFan added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZfinx.td:102 +: InstAlias; + use GPR as instruction operand may cause the codegen part of zfinx report errors. Because the GPR has data type i32 or i64, However, the zfinx will

[PATCH] D92577: Don't reject tag declarations in for loop clause-1

aaron.ballman updated this revision to Diff 312494. aaron.ballman added a comment. Updating based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92577/new/ https://reviews.llvm.org/D92577 Files: clang/lib/Sema/SemaStmt.cpp clang/test/Sema/for.c Index: clang/tes

[PATCH] D92577: Don't reject tag declarations in for loop clause-1

aaron.ballman added a comment. In D92577#2458903 , @rjmccall wrote: > Please test that there's actually an object declared and that it's not *just* > a tag declaration. Good catch, I've corrected this and added some more test coverage. CHANGES SINCE LA

[PATCH] D93452: [clangd] Trim memory after buildINdex

qchateau added a comment. > Side note is this memory failing to free behaviour observed on windows? No idea, I only develop on linux. Looking at the the github issues, it seems people that had the issue were also using the linux version...so we can't conclude anything about windows =

[PATCH] D93393: [clangd] Ignore the static index refs from the dynamic index files.

ArcsinX updated this revision to Diff 312497. ArcsinX added a comment. Make `indexedFiles()` to return `[](StringRef){return false;}` instead of `nullptr`. Add comments. Do not call `indexedFiles()` at every file check for `MergeIndex`. Consume error if `URI::resolve()` fails. Repository: rG

[clang] fb0f728 - [Clang] Make nomerge attribute a function attribute as well as a statement attribute.

Author: Zequan Wu Date: 2020-12-17T07:45:38-08:00 New Revision: fb0f7288051eb2745bb9211306f53ff9aa6f73e2 URL: https://github.com/llvm/llvm-project/commit/fb0f7288051eb2745bb9211306f53ff9aa6f73e2 DIFF: https://github.com/llvm/llvm-project/commit/fb0f7288051eb2745bb9211306f53ff9aa6f73e2.diff LOG

[PATCH] D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfb0f7288051e: [Clang] Make nomerge attribute a function attribute as well as a statement… (authored by zequanwu). Repository: rG LLVM Github Monor

[PATCH] D93103: Enable the _ExtInt extension on the BPF Target

seanyoung added a comment. Patch submitted https://lore.kernel.org/bpf/20201217150102.ga13...@gofer.mess.org/T/#u Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93103/new/ https://reviews.llvm.org/D93103 ___

[PATCH] D93459: Fix -Wno-error= parsing in clang-format.

njames93 added a comment. In D93459#2460445 , @fodinabor wrote: > Btw. is there a way to add tests for command-line options, so this won't > happen unnoticed again? I'd guess some lit tests could be used to verify the command line syntax is correct /

[PATCH] D93452: [clangd] Trim memory after buildINdex

qchateau updated this revision to Diff 312500. qchateau added a comment. Herald added a subscriber: mgorny. Add macro to use malloc_trim only if available Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93452/new/ https://reviews.llvm.org/D93452 Fil

[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

awarzynski added a comment. @FarisRehman, thank you for working on this! This looks really good and I think that it's almost ready. I did leave a few comments, but most are a matter of style and should be easy to address. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:70-7

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

Quuxplusone added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:6502 + // except that it has a non-trivial member *with* the trivial_abi attribute. + for (auto Base : D->bases()) { +if (auto CxxRecord = Base.getType()->getAsCXXRecordDecl()) zo

[PATCH] D93452: [clangd] Trim memory after buildINdex

sammccall added a comment. Wow, all abstractions truly are lies. Thanks for the investigation! After doing some reading[1], my understanding is roughly: - our pattern of allocations causes glibc malloc to retain a *much* larger heap than our outstanding allocations, growing without (or with lar

[clang] daf39e3 - [amdgpu] Default to code object v3

Author: Jon Chesterfield Date: 2020-12-17T16:09:33Z New Revision: daf39e3f2dba18bd39cd89a1c91bae126a31d4fe URL: https://github.com/llvm/llvm-project/commit/daf39e3f2dba18bd39cd89a1c91bae126a31d4fe DIFF: https://github.com/llvm/llvm-project/commit/daf39e3f2dba18bd39cd89a1c91bae126a31d4fe.diff L

[PATCH] D93258: [amdgpu] Default to code object v3

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdaf39e3f2dba: [amdgpu] Default to code object v3 (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D93393: [clangd] Ignore the static index refs from the dynamic index files.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Fantastic, thanks so much! Comment at: clang-tools-extra/clangd/index/Merge.cpp:129 +StaticContainsFile{Static->indexedFiles()} + ](llvm::StringRef FileURI) mutabl

[PATCH] D93393: [clangd] Ignore the static index refs from the dynamic index files.

ArcsinX updated this revision to Diff 312508. ArcsinX added a comment. Fix comment inside IndexClient::indexedFiles() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93393/new/ https://reviews.llvm.org/D93393 Files: clang-tools-extra/clangd/index/

[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

tskeith added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:228 + // Note: GCC drops anything following an end-of-line character. + llvm::StringRef::size_type End = MacroBody.find_first_of("\n\r"); + MacroBody = MacroBody.substr(0, End); --

[PATCH] D93428: [AArch64] Add bti note property when compiling asm files with -mbranch-protection=bti

steplong added a comment. In D93428#2460032 , @danielkiss wrote: > The `.note.gnu.property` is already generated when C/C++ files are compiled > with `-mbranch-protection=bti`. > `-mmark-bti-property` is only for assembly file where the > `.note.gnu.pr

[PATCH] D93459: Fix -Wno-error= parsing in clang-format.

fodinabor updated this revision to Diff 312518. fodinabor added a comment. Add lit test to ensure behaviour of the -Wno-error=unkown flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93459/new/ https://reviews.llvm.org/D93459 Files: clang/test

[PATCH] D93453: [flang][driver] Add support for `-I`

awarzynski added a comment. Hi @FarisRehman ! Thank you for working on this! Could you add tests? Comment at: clang/lib/Driver/ToolChains/Flang.cpp:75 + Args.AddAllArgs(CmdArgs, options::OPT_I); + This would ideally go to a dedicated method for parsing prepr

[PATCH] D93452: [clangd] Trim memory after buildINdex

qchateau planned changes to this revision. qchateau added a comment. > Periodic malloc_trim seems like it solves a real problem, one I don't > personally fully understand but we may never do - I feel convinced we should > use it anyway. It probably has some overhead, who knows how much. It does

[clang] f500662 - Detect section type conflicts between functions and variables

Author: Tomas Matheson Date: 2020-12-17T11:43:47-05:00 New Revision: f50066292477fb26806336e5604615d0eddde399 URL: https://github.com/llvm/llvm-project/commit/f50066292477fb26806336e5604615d0eddde399 DIFF: https://github.com/llvm/llvm-project/commit/f50066292477fb26806336e5604615d0eddde399.diff

[PATCH] D93102: [Clang][Sema] Detect section type conflicts between functions and variables

aaron.ballman closed this revision. aaron.ballman added a comment. In D93102#2460034 , @tmatheson wrote: > In D93102#2458433 , @aaron.ballman > wrote: > >> LGTM aside from a minor nit. Thank you for the patch! Do y

[PATCH] D93428: [AArch64] Add bti note property when compiling asm files with -mbranch-protection=bti

apazos added a comment. Thanks for clarifying - so the property is being set for C/C++ files but not for assembly files. I think it should be set automatically for both when one uses clang driver to compile/assemble. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D84669: [clang][cli] Port CodeGenOpts simple string flags to new option parsing system

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm with the comment. Comment at: clang/include/clang/Driver/Options.td:2123-2125 def fpatchable_function_entry_EQ : Joined<["-"], "fpatchable-function-entry=">, Gro

[PATCH] D93464: [analyzer] Refine suppression mechanism to better support AST checks

vsavchenko created this revision. Herald added subscribers: steakhal, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, mgorny. vsavchenko requested review of this revision. Herald added a project: clang. Herald add

[PATCH] D92290: [clangd] Use clangd's Context mechanism to make the ASTContext of the AST being operated on available everywhere

sammccall added a comment. Sorry for taking a while to get to this... I'm not sure this is really a helpful use of Context. (Though some would argue that there are no good uses, my manager was appalled when we added it...) Does this enable some future work, or is it reasonable to evaluate this p

[PATCH] D93393: [clangd] Ignore the static index refs from the dynamic index files.

ArcsinX updated this revision to Diff 312530. ArcsinX added a comment. `unique_function indexedFiles() const` => `unique_function indexedFiles() const` `StringRef` => `llvm::StringRef` for consistency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[PATCH] D84668: [clang][cli] Port TargetOpts simple string based options to new option parsing system

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm with the fix above. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:264-265 +template ::value, bool> = true> +static void denormalizeSimpleEnum(SmallVector

[PATCH] D93393: [clangd] Ignore the static index refs from the dynamic index files.

ArcsinX marked an inline comment as done. ArcsinX added a comment. Thank you for review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93393/new/ https://reviews.llvm.org/D93393 ___ cfe-commits mailing l

[PATCH] D84670: [clang][cli] Port HeaderSearch simple string options to new option parsing system

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm with nit. Comment at: clang/include/clang/Driver/Options.td:1815 + HelpText<"Specify the interval (in seconds) after which a module file will be considered unuse

[PATCH] D93458: clang-cl: Remove /Zd flag

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. lgtm, but perhaps Reid should take a look Comment at: clang/docs/ReleaseNotes.rst:127 + +- clang-cl's ``/Zd`` flag no longer exist. But ``-gline-tables-only`` still + ex

[PATCH] D84671: [clang][cli] Port LangOpts simple string based options to new option parsing system

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84671/new/ https://reviews.llvm.org/D84671 __

[PATCH] D93079: [OpenMP] Introduce an assumption to ignore possible external callers

jdoerfert updated this revision to Diff 312535. jdoerfert added a comment. Rebase on top of D93439 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93079/new/ https://reviews.llvm.org/D93079 Files: clang/include/cl

[PATCH] D84672: [clang][cli] Port PreprocessorOpts simple string based options to new option parsing system

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84672/new/ https://reviews.llvm.org/D84672 ___

[PATCH] D93436: [clangd] Print .clang-tidy configuration parsing errors using [ev]?log.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! From here it seems like mostly a question of plumbing/refactoring on the clangd side to be able to surface these diagnostics, similar to how you did it with config files. At some

[PATCH] D93395: [clang][cli] Remove -f[no-]trapping-math from -cc1 command line

Bigcheese added a comment. This looks fine to be as that code is definitely dead. I would wait for @SjoerdMeijer in case there's a bug in the existing code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93395/new/ https://reviews.llvm.org/D93395

[PATCH] D93393: [clangd] Ignore the static index refs from the dynamic index files.

ArcsinX updated this revision to Diff 312538. ArcsinX added a comment. `StringRef` => `llvm::StringRef` in one more place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93393/new/ https://reviews.llvm.org/D93393 Files: clang-tools-extra/clangd/i

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

rjmccall added a comment. Oh yes, somehow I overlooked that, sorry. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92361/new/ https://reviews.llvm.org/D92361 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

zoecarver added a comment. In D92361#2459655 , @rjmccall wrote: > In D92361#2459513 , @zoecarver wrote: > >>> I think that as long as the class leaves a copy/move constructor defaulted, >>> there's no need for a ne

[PATCH] D93227: [clangd] Smarter hover on auto and decltype

qchateau updated this revision to Diff 312545. qchateau marked 3 inline comments as done. qchateau added a comment. I updated this diff according to your review. There are a few things that may still need change but I need your input, see my other comments :) Repository: rG LLVM Github Monore

[PATCH] D93227: [clangd] Smarter hover on auto and decltype

qchateau added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:618 + } else { +CXXRecordDecl *D = QT->getAsCXXRecordDecl(); +if (D && D->isLambda()) sammccall wrote: > You've rewritten this logic compared to the old `getHoverContents(Qual

[PATCH] D93428: [AArch64] Add bti note property when compiling asm files with -mbranch-protection=bti

danielkiss added a comment. > Is there a reason why assembly files have a different flag (i.e. > -mmark-bti-property) to create the .note.gnu.property with the BTI entry? In assembly the compiler can't guarantee the landing pads are in place, therefore it doesn't add it automatically. The origi

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

awarzynski updated this revision to Diff 312547. awarzynski added a comment. Tidy-up include paths This was pointed out by @CarolineConcatto offline, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92854/new/ https://reviews.llvm.org/D928

[clang] c289297 - [PowerPC] Rename the vector pair intrinsics and builtins to replace the _mma_ prefix by _vsx_

Author: Baptiste Saleil Date: 2020-12-17T13:19:27-05:00 New Revision: c2892978e919bf66535729c70fba73c4c3224548 URL: https://github.com/llvm/llvm-project/commit/c2892978e919bf66535729c70fba73c4c3224548 DIFF: https://github.com/llvm/llvm-project/commit/c2892978e919bf66535729c70fba73c4c3224548.dif

[PATCH] D91974: [PowerPC] Rename the vector pair intrinsics and builtins to replace the _mma_ prefix by _vsx_

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc2892978e919: [PowerPC] Rename the vector pair intrinsics and builtins to replace the _mma_… (authored by bsaleil, committed by Conanap). Repository

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

CarolineConcatto accepted this revision. CarolineConcatto added a comment. Thank you @awarzynski for implementing fsyntax-only. It is another feature that the new driver provides, it is nice to see thing falling into place. The patch looks good to me! Comment at: flang/includ

  1   2   >