[clang] 47ef09e - Revert "clang-format: support aligned nested conditionals formatting"

Author: Haojian Wu Date: 2020-04-23T09:25:01+02:00 New Revision: 47ef09e4848a970c530928496b54085cfdba5a76 URL: https://github.com/llvm/llvm-project/commit/47ef09e4848a970c530928496b54085cfdba5a76 DIFF: https://github.com/llvm/llvm-project/commit/47ef09e4848a970c530928496b54085cfdba5a76.diff LO

[PATCH] D74813: [RFC] Add hash of block contents to function block names

jhenderson added inline comments. Comment at: llvm/test/tools/llvm-cxxfilt/invalid.test:1 -RUN: llvm-cxxfilt -n _Z1fi __Z1fi f ___ZSt1ff_block_invoke | FileCheck %s +RUN: llvm-cxxfilt -n _Z1fi __Z1fi f ___ZSt1ff_block_invoke ___Z7my_mainv_block_invoke_ZTSi_ZTSj_ZTSPVK3sss | File

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

hokein added a comment. In D50078#1998520 , @Typz wrote: > In D50078#1998398 , @dyung wrote: > > > Hi, this change that you submitted in commit > > 5daa25fd7a184524759b6ad065a8bd7e95aa149a > >

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware marked 2 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1044 +class ParamWithoutVarRegion : public TypedValueRegion { + friend class MemRegionManager;

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

fiesh added a comment. @JonasToth could you please clarify if the original author's comment is sufficient grants of rights? If so, from what I can tell if the commit message was adapted to reflect that this removes false positives with system macros like `assert`, this would be good to go? C

[PATCH] D77940: [AArch64] Add NVIDIA Carmel support

tambre added a comment. sdesmalen: Could you please take another look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77940/new/ https://reviews.llvm.org/D77940 ___ cfe-commits mailing list cfe-commits@

[PATCH] D78374: [Analyzer][StreamChecker] Added evaluation of fread and fwrite.

balazske updated this revision to Diff 259491. balazske added a comment. - Stream error is stored in separate boolean flags instead of enum. - Removed `PossibleErrors`. - Added "FilePositionIndeterminate". - Updated fread, fwrite, fseek, clearerr. - Added tests. Repository: rG LLVM Github Mono

[PATCH] D78192: Support compiler extensions as a normal component

serge-sans-paille added a comment. In D78192#1997698 , @Meinersbur wrote: > Is this ready to try out? It is! > > > In D78192#1996859 , > @serge-sans-paille wrote: > >> Note that this should solve in an elegan

[PATCH] D78192: Support compiler extensions as a normal component

serge-sans-paille updated this revision to Diff 259495. serge-sans-paille added a comment. Fix dependency order for extension libraries, as spotted by @Meinersbur CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78192/new/ https://reviews.llvm.org/D78192 Files: clang/lib/CodeGen/CMakeLi

[clang-tools-extra] bbb7921 - [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`

Author: Andi-Bogdan Postelnicu Date: 2020-04-23T11:36:50+03:00 New Revision: bbb7921da97ce03d2933e185a525c4e452b146b0 URL: https://github.com/llvm/llvm-project/commit/bbb7921da97ce03d2933e185a525c4e452b146b0 DIFF: https://github.com/llvm/llvm-project/commit/bbb7921da97ce03d2933e185a525c4e452b14

[PATCH] D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`

This revision was automatically updated to reflect the committed changes. Closed by commit rGbbb7921da97c: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using… (authored by Andi-Bogdan Postelnicu ). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D76996: [analyzer] Improve PlacementNewChecker

f00kat updated this revision to Diff 259499. f00kat added a comment. 1. Rewroted ElementRegion processing and fixed tests for this cases. 2. Simplified the code a bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76996/new/ https://reviews.llvm.or

[PATCH] D77871: [AArch64] Armv8.6-a Matrix Mult Assembly + Intrinsics

kmclaughlin accepted this revision. kmclaughlin added a comment. This revision is now accepted and ready to land. Thanks for the updates, @LukeGeeson, LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77871/new/ https://reviews.llvm.org/D77871 ___

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1044 +class ParamWithoutVarRegion : public TypedValueRegion { + friend class MemRegionManager;

[clang] 0021644 - [SveEmitter] Add builtins for FP conversions

Author: Sander de Smalen Date: 2020-04-23T10:49:06+01:00 New Revision: 002164461b52e0ff13fa677a535991f89da0f633 URL: https://github.com/llvm/llvm-project/commit/002164461b52e0ff13fa677a535991f89da0f633 DIFF: https://github.com/llvm/llvm-project/commit/002164461b52e0ff13fa677a535991f89da0f633.di

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

whisperity added inline comments. Comment at: clang/docs/analyzer/user-docs/CrossTranslationUnit.rst:391 +Currently On-demand analysis is not supported with `scan-build-py`. \ No newline at end of file What's this line? Is this added by Phab, or is this a weird

[PATCH] D78642: [clang-format] Handle C# property accessors when parsing lines

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78642/new/ https://reviews.llvm.org/D78642 ___ cfe-commits mailing list cfe

[PATCH] D78239: [SveEmitter] Add builtins for FP conversions

This revision was automatically updated to reflect the committed changes. Closed by commit rG002164461b52: [SveEmitter] Add builtins for FP conversions (authored by sdesmalen). Changed prior to commit: https://reviews.llvm.org/D78239?vs=258426&id=259504#toc Repository: rG LLVM Github Monorep

[PATCH] D78569: [SVE][CodeGen] Lower SDIV & UDIV to SVE intrinsics

sdesmalen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:7670 + Mask, Op.getOperand(0), Op.getOperand(1)); +} + efriedma wrote: > sdesmalen wrote: > > efriedma wrote: > > > If we're going to support these op

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

whisperity updated this revision to Diff 259508. whisperity retitled this revision from "[clang-tidy] Suspicious Call Argument checker" to "[clang-tidy] Add 'readability-suspicious-call-argument' check". whisperity edited the summary of this revision. whisperity removed reviewers: varjujan, baranc

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

whisperity commandeered this revision. whisperity added a reviewer: barancsuk. whisperity added a comment. Herald added subscribers: martong, Charusso, gamesh411, Szelethus. Assuming direct control. Previous colleagues and university mates departed for snowier pastures, time to try to do somethin

[PATCH] D78694: [clang-format] Fix lambda with ellipsis in return type

krasimir added a comment. Could you please update the patch with full context: https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface This helps out when reviewing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78694/new/

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

balazske updated this revision to Diff 259513. balazske marked 5 inline comments as done. balazske added a comment. Updated tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77809/new/ https://reviews.llvm.org/D77809 Files: clang/lib/Analysis

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

hokein updated this revision to Diff 259514. hokein added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78350/new/ https://reviews.llvm.org/D78350 Files: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp clang/include/

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. I agree with the sentiment that it's annoying when clang doesn't just work out of the box. But it will still do, except for asan and profile info etc, for which I think it's reasonable to add to t

[PATCH] D78214: [libclang]: visit C++17 if init statements

milianw added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78214/new/ https://reviews.llvm.org/D78214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Thanks, this looks much better now. Could you also update the description of the revision to match the current status? (E.g. type aliases are now supported.) If you do not plan to solve t

[PATCH] D78213: [libclang]: visit BindingDecl in DecompositionDecl

milianw added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78213/new/ https://reviews.llvm.org/D78213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D78289: [analyzer] Stability improvements for IteratorModeling functions

ASDenysPetrov updated this revision to Diff 259521. ASDenysPetrov edited the summary of this revision. ASDenysPetrov added a comment. @baloghadamsoftware I've added a test for unscoped SVal, but still can't come up with `if (!LPos || !RPos)` Could you, please, suggest me something? CHANGES SINC

[PATCH] D77940: [AArch64] Add NVIDIA Carmel support

sdesmalen added a comment. It seems a NVIDIA Developer Program Membership is needed in order to download the TRM. I'm not sure if that is just a matter of creating an account, but without it I can't really verify that the architecture version and the features are correct and complete. ==

[PATCH] D78693: Make "#pragma clang attribute" support uninitialized attribute.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/test/CodeGenCXX/trivial-auto-var-init-attribute.cpp:38-50 +// UNINIT-LABEL: test_pragma_attribute_uninitialized_f2( +// UNINIT: al

[PATCH] D78704: [analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor

steakhal created this revision. steakhal added reviewers: NoQ, xazax.hun, rnkovacs, Szelethus, baloghadamsoftware, mikhail.ramalho. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, a.sidorin, szepet, whisperity, mgorny. Herald added a project: clang. st

[PATCH] D78704: [analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor

steakhal updated this revision to Diff 259531. steakhal added a comment. Upload the right diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78704/new/ https://reviews.llvm.org/D78704 Files: clang/unittests/StaticAnalyzer/CMakeLists.txt clang

[PATCH] D78457: [analyzer][Z3-refutation] Fix refutation BugReporterVisitor bug and refactor

steakhal updated this revision to Diff 259532. steakhal added a comment. - keep the visitor - fix the bug - add test demonstrating the bug and the fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78457/new/ https://reviews.llvm.org/D78457 Files:

[PATCH] D78457: [analyzer][Z3-refutation] Fix refutation BugReporterVisitor bug and refactor

steakhal marked an inline comment as done. steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2871 + // Overwrite the associated constraint of the Symbol. + Constraints = CF.remove(Constraints, Sym); Constraints = CF

[clang] 2f9fc8d - [clang-format] Handle C# property accessors when parsing lines

Author: Jonathan Coe Date: 2020-04-23T13:25:10+01:00 New Revision: 2f9fc8d9718fb19c04e169f7ba7ae26ea6a05085 URL: https://github.com/llvm/llvm-project/commit/2f9fc8d9718fb19c04e169f7ba7ae26ea6a05085 DIFF: https://github.com/llvm/llvm-project/commit/2f9fc8d9718fb19c04e169f7ba7ae26ea6a05085.diff

[PATCH] D78704: [analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor

xazax.hun added a comment. Thanks! Having more tests is always welcome! I mentioned some nits inline, but I wonder if you actually need to add a new check. Can't you just reuse existing debug checks? We have the expr inspeciton checker that supports the following functions: clang_analyzer_war

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:438-442 + Optional getReturnValueUnderConstruction(unsigned BlockCount) const; + + Optional getArgObject(unsigned Index, unsigned BlockCount) const; + + Optional getReturn

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

balazske added inline comments. Comment at: clang/test/Analysis/cfg.cpp:570 } +// CHECK-LABEL: void vla_simple(int x) aaron.ballman wrote: > NoQ wrote: > > balazske wrote: > > > balazske wrote: > > > > aaron.ballman wrote: > > > > > Can you also add tests for:

[PATCH] D78642: [clang-format] Handle C# property accessors when parsing lines

This revision was automatically updated to reflect the committed changes. Closed by commit rG2f9fc8d9718f: [clang-format] Handle C# property accessors when parsing lines (authored by Jonathan Coe ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[clang] 3a53806 - Add extension links for VSCode

Author: Kumar Harsh Date: 2020-04-23T14:56:36+02:00 New Revision: 3a5380618e8284efd513228036ca98e550ea0abf URL: https://github.com/llvm/llvm-project/commit/3a5380618e8284efd513228036ca98e550ea0abf DIFF: https://github.com/llvm/llvm-project/commit/3a5380618e8284efd513228036ca98e550ea0abf.diff L

[PATCH] D78457: [analyzer][Z3-refutation] Fix refutation BugReporterVisitor bug and refactor

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:2751 +Optional hasContradictionUsingZ3(BugReporterContext &BRC, + const ExplodedNode *EndPathNode) { Is this function used anywhere?

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

saiislam updated this revision to Diff 259545. saiislam added a comment. Added check and test for sync scope to be a constant literal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75917/new/ https://reviews.llvm.org/D75917 Files: clang/include/

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

bernhard added a comment. Are there plans to offer a way to disable this behavior (or have it optional in the first place)? We'd like to run some custom processing between wasm-ld and wasm-opt which can't happen after the latter due to some of its one-way destructive optimizations (i.e. memory-

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

aaron.ballman added inline comments. Comment at: clang/test/Analysis/cfg.cpp:570 } +// CHECK-LABEL: void vla_simple(int x) balazske wrote: > aaron.ballman wrote: > > NoQ wrote: > > > balazske wrote: > > > > balazske wrote: > > > > > aaron.ballman wrote: > > >

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

saiislam marked an inline comment as done. saiislam added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:2958 + // Check that sync scope is a constant literal + if(!ArgExpr->EvaluateAsConstantExpr(ArgResult1, + Expr::EvaluateForCodeGen, Context))

Re: [clang] 2214b90 - [clangd] Make signatureHelp work with stale preambles

Hi Kadir, I start seeing some sanitizer complaints with this commit for the following two testcases: ./ClangdTests/PreamblePatchTest.ContainsNewIncludes ./ClangdTests/PreamblePatchTest.IncludeParsing The complaints look like this: =

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

xazax.hun added a comment. Actually, sorry. I just realized that the alignof problem is introduced by this patch. I'd love to see the solution committed together with this patch (it could be a separate patch but preferably, they should be committed together.) Repository: rG LLVM Github Monor

[PATCH] D78521: [clangd] Extend dexp to support remote index

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/Index.cpp:97 +std::unique_ptr connect(llvm::StringRef Address) { +#ifdef CLANGD_REMOTE + return std::unique_ptr(new IndexClient(Address)); sammccall wrote: > if remote is disabled

[PATCH] D78642: [clang-format] Handle C# property accessors when parsing lines

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1344 addUnwrappedLine(); FormatTok->Type = TT_FunctionLBrace; parseBlock(/*MustBeDeclaration=*/false); previously set and get would break based

[PATCH] D78642: [clang-format] Handle C# property accessors when parsing lines

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:249 + "public string Host { set; get; }"); verifyFormat("[TestMethod(\"start\", HelpText = \"Starts the server " is this just a personal choice? or ba

[PATCH] D78521: [clangd] Extend dexp to support remote index

kbobyrev updated this revision to Diff 259547. kbobyrev marked 13 inline comments as done. kbobyrev added a comment. Address the remaining comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78521/new/ https://reviews.llvm.org/D78521 Files:

[PATCH] D78521: [clangd] Extend dexp to support remote index

kbobyrev updated this revision to Diff 259553. kbobyrev added a comment. Convert plain function pointers to std::function in templates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78521/new/ https://reviews.llvm.org/D78521 Files: clang-tools-e

[PATCH] D78190: Add Bfloat IR type

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. This direction of an IR type was taken after a discussion on the list. All previous comments have been addressed, and the changes here all look very reasonable to me. So, LGTM, but

[PATCH] D78401: [SveEmitter] IsInsertOp1SVALL and builtins for svqdec[bhwd] and svqinc[bhwd]

sdesmalen added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:530 +class sat_type { string U = u; string T = t; } +def SIGNED_BYTE : sat_type<"", "c">; +def SIGNED_HALF : sat_type<"", "s">; SjoerdMeijer wrote: > nit: just won

[PATCH] D77597: [SveEmitter] Add IsAppendSVALL and builtins for svptrue and svcnt[bhwd]

sdesmalen updated this revision to Diff 259555. sdesmalen marked 2 inline comments as done. sdesmalen added a comment. - Added comment explaining need for expanding SV_ALL CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77597/new/ https://reviews.llvm.org/D77597 Files: clang/include/cl

[PATCH] D78638: [analyzer] Consider array subscripts to be interesting lvalues

NoQ accepted this revision. NoQ added a comment. Yup. Yet another epic bug! Comment at: clang/test/Analysis/CheckThatArraySubsciptNodeIsNotCollected.cpp:18-19 +// time to collect redundant nodes. This GC-like mechanism kicks in only when +// the exploded graph is large enough

[PATCH] D78401: [SveEmitter] IsInsertOp1SVALL and builtins for svqdec[bhwd] and svqinc[bhwd]

sdesmalen updated this revision to Diff 259554. sdesmalen marked 3 inline comments as done. sdesmalen added a comment. - Changed UNSIGNED_BYTE etc from upper-case to CamelCase. - Added comment explaining need to expand SV_ALL CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78401/new/ http

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

balazske added a comment. In D77809#1999050 , @xazax.hun wrote: > Actually, sorry. I just realized that the alignof problem is introduced by > this patch. I'd love to see the solution committed together with this patch > (it could be a separate patch but

[PATCH] D78638: [analyzer] Consider array subscripts to be interesting lvalues

vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/test/Analysis/CheckThatArraySubsciptNodeIsNotCollected.cpp:18-19 +// time to collect redundant nodes. This GC-like mechanism kicks in only when +// the exploded graph is large enough

[PATCH] D46472: [HIP] Support offloading by linker script

JonChesterfield added inline comments. Herald added a reviewer: jdoerfert. Comment at: cfe/trunk/lib/Driver/ToolChains/CommonArgs.cpp:1329 + // Get the HIP offload tool chain. + auto *HIPTC = static_cast( + C.getSingleOffloadToolChain()); Should this be `t

[PATCH] D78704: [analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor

martong added a comment. I like it! Nice work! I have some minor comments. Comment at: clang/unittests/StaticAnalyzer/CheckerRegistration.h:81 +template +bool runCheckerOnCodeWithArgs(const std::string &Code, std::string &Diags, + const std::vector

[PATCH] D78563: [AIX] Port power alignment rules to clang

Xiangling_L updated this revision to Diff 259559. Xiangling_L marked 5 inline comments as done. Xiangling_L added a comment. Adjust some comments style; Add more testcases; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78563/new/ https://reviews.ll

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Let's land this, I guess? Fantastic work! Comment at: clang/lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:198 + // 'self' variable of the current class method. +

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

sunfish added a comment. In D70500#1998994 , @bernhard wrote: > Are there plans to offer a way to disable this behavior (or have it optional > in the first place)? > We'd like to run some custom processing between wasm-ld and wasm-opt which > can't happ

[PATCH] D78704: [analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor

martong added inline comments. Comment at: clang/unittests/StaticAnalyzer/FalsePositiveRefutationBRVisitorTest.cpp:55 + + bool reachedWithNoContradiction(const CallEvent &, CheckerContext &C, + ProgramStateRef State) const { It

[PATCH] D78289: [analyzer] Stability improvements for IteratorModeling functions

ASDenysPetrov updated this revision to Diff 259561. ASDenysPetrov edited the summary of this revision. ASDenysPetrov added a comment. I decided not to add changes of what I cannot cover by tests. So I removed them. @NoQ @baloghadamsoftware please, review my changes. CHANGES SINCE LAST ACTION

[PATCH] D78715: [clangd] Fix modernize-loop-convert "multiple diag in flight" crash.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. this maybe not ideal, but it is trivial and does fix the crash. Fixes https://github.com/clangd/clangd/issues

[PATCH] D78704: [analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor

martong added inline comments. Comment at: clang/unittests/StaticAnalyzer/FalsePositiveRefutationBRVisitorTest.cpp:65 + + bool reportIfCanBeZero(const CallEvent &Call, CheckerContext &C, + ProgramStateRef State) const { xazax.hun wrote:

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Typz added a comment. In D50078#1998578 , @hokein wrote: > In D50078#1998520 , @Typz wrote: > > > In D50078#1998398 , @dyung wrote: > > > > > Hi, this change that you submitt

[clang-tools-extra] 89cb5d5 - [clangd] Delete remapped buffers in tests

Author: Kadir Cetinkaya Date: 2020-04-23T16:31:35+02:00 New Revision: 89cb5d558895706e053bc3af972aa5b15aa82863 URL: https://github.com/llvm/llvm-project/commit/89cb5d558895706e053bc3af972aa5b15aa82863 DIFF: https://github.com/llvm/llvm-project/commit/89cb5d558895706e053bc3af972aa5b15aa82863.dif

[clang] b0a1c0b - [doc] Fix broken link. NFC.

Author: Xing GUO Date: 2020-04-23T22:47:39+08:00 New Revision: b0a1c0b72c9c61f8b0a223e08f43498abb64f5e8 URL: https://github.com/llvm/llvm-project/commit/b0a1c0b72c9c61f8b0a223e08f43498abb64f5e8 DIFF: https://github.com/llvm/llvm-project/commit/b0a1c0b72c9c61f8b0a223e08f43498abb64f5e8.diff LOG:

[clang] b0a1c0b - [doc] Fix broken link. NFC.

Author: Xing GUO Date: 2020-04-23T22:47:39+08:00 New Revision: b0a1c0b72c9c61f8b0a223e08f43498abb64f5e8 URL: https://github.com/llvm/llvm-project/commit/b0a1c0b72c9c61f8b0a223e08f43498abb64f5e8 DIFF: https://github.com/llvm/llvm-project/commit/b0a1c0b72c9c61f8b0a223e08f43498abb64f5e8.diff LOG:

Re: [clang] 2214b90 - [clangd] Make signatureHelp work with stale preambles

Thanks Mikael, sent out an ugly fix at 89cb5d558895706e053bc3af972aa5b15aa82863 to get sanitizer build bots running. Will change the testing scheme for a proper fix. On Thu, Apr 23, 2020 at 4:53 PM Mikael Holmén wrote: > Hi Kadir, > > I start seeing some sanitizer complaints with this commit fo

[PATCH] D78457: [analyzer][Z3-refutation] Fix refutation BugReporterVisitor bug and refactor

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2822 PathSensitiveBugReport &BR) { // Collect new constraints + addConstraints(EndPathNode, /*OnlyForNewSymbols=*/false); Probably you wanted to use `hasCont

[PATCH] D78457: [analyzer][Z3-refutation] Fix refutation BugReporterVisitor bug and refactor

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2871 + // Overwrite the associated constraint of the Symbol. + Constraints = CF.remove(Constraints, Sym); Constraints = CF.add(Constraints, Sym, C.second); --

[PATCH] D78715: [clangd] Fix modernize-loop-convert "multiple diag in flight" crash.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Ah, nice work! Agree it's a hack (and how many more instances are lurking) but I don't know how better to fix it and it's been reported 3 times... Comment at: clang-to

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

vsavchenko marked 2 inline comments as done. vsavchenko added a comment. > Let's land this, I guess? Fantastic work! Thanks :-) Comment at: clang/lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:198 + // 'self' variable of the current class method. + if (Receiv

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:198 + // 'self' variable of the current class method. + if (ReceiverSVal == Message.getSelfSVal()) { +// In this case, we should return the type of the enclosing

[PATCH] D46472: [HIP] Support offloading by linker script

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: cfe/trunk/lib/Driver/ToolChains/CommonArgs.cpp:1329 + // Get the HIP offload tool chain. + auto *HIPTC = static_cast( + C.getSingleOffloadToolChain()); JonChesterfield wrote

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

bernhard added a comment. > It's for users who want smaller wasm binaries. It's not currently documented, > though yes, it would be nice to document it. But how would a user even end up with wasm-opt in the same directory of clang binaries? > Clang and wasm-ld are free to do anything wasm-opt

[PATCH] D77062: [analyzer] Added check for unacceptable equality operation between Loc and NonLoc types

ASDenysPetrov added a comment. @Szelethus, could you, please, make some suggestions about my investigation above? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77062/new/ https://reviews.llvm.org/D77062 ___ cfe-commits mailing list cfe-com

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

balazske updated this revision to Diff 259584. balazske added a comment. - Separating test files, fixing alignof problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77809/new/ https://reviews.llvm.org/D77809 Files: clang/lib/Analysis/CFG.cpp

[PATCH] D78677: [SveEmitter] Add builtins for gather prefetches

sdesmalen updated this revision to Diff 259589. sdesmalen added a comment. - Updated the tests to use `SVE_ACLE_FUNC` for the overloaded builtins. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78677/new/ https://reviews.llvm.org/D78677 Files: clang/include/clang/Basic/TargetBuiltins.

[PATCH] D78674: [SveEmitter] Add builtins for contiguous prefetches

sdesmalen updated this revision to Diff 259587. sdesmalen marked an inline comment as done. sdesmalen added a comment. - Don't emit bitcast+gep+bitcast when offset is 0. - Added negative tests for _vnum cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78674/new/ https://reviews.llvm

[PATCH] D78573: [Clang][Sema] Capturing section type conflicts between #pragma clang section and section attributes

pratlucas updated this revision to Diff 259594. pratlucas added a comment. Rebasing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78573/new/ https://reviews.llvm.org/D78573 Files: clang/include/clang/AST/ASTContext.h clang/lib/Sema/SemaAttr.c

[PATCH] D76996: [analyzer] Improve PlacementNewChecker

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CheckPlacementNew.cpp:261 + + if (const VarRegion *TheVarRegion = BaseRegion->getAs()) { +const VarDecl *TheVarDecl = TheVarRegion->getDecl(); Perhaps you could call instead `checkV

[PATCH] D78674: [SveEmitter] Add builtins for contiguous prefetches

sdesmalen marked an inline comment as done. sdesmalen added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7727 + Value *Offset = Ops.size() > 3 ? Ops[2] : Builder.getInt32(0); + BasePtr = Builder.CreateGEP(MemoryTy, BasePtr, Offset); + efriedma w

[PATCH] D78572: [Clang][Sema] Capturing section type conflicts on #pragma clang section

pratlucas updated this revision to Diff 259593. pratlucas added a comment. Rebasing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78572/new/ https://reviews.llvm.org/D78572 Files: clang/include/clang/AST/ASTContext.h clang/lib/Parse/ParsePrag

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM with a minor nit, thank you! Comment at: clang/lib/Analysis/CFG.cpp:2855 + VA = FindVA(VA->getElementType().getTypePtr())) { + if (CFGBlock *newBlock = addStmt(VA->getSizeExpr())) +La

[PATCH] D78726: [CUDA] Define __CUDACC_DEBUG__ when compiling device code in debug mode

tambre created this revision. tambre added a reviewer: tra. Herald added subscribers: cfe-commits, yaxunl. Herald added a project: clang. NVCC defines __CUDACC_DEBUG__ when compiling device code in debug mode. Let's do the same to help with compatibility between the two and possibly enable users

[PATCH] D74813: [RFC] Add hash of block contents to function block names

erik.pilkington added inline comments. Comment at: clang/lib/AST/Mangle.cpp:41 + for (ParmVarDecl *PVD : BD->parameters()) { +Context.mangleTypeName(PVD->getType(), Out); + } >>! In D74813#1996143, @alexbdv wrote: > @dexonsmith, @erik.pilkington - how about

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 updated this revision to Diff 259605. wxz2020 added a comment. Resubmit as the previous one was rejected by test plan changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/ https://reviews.llvm.org/D78129 Files: clang/lib/Drive

[PATCH] D78521: [clangd] Extend dexp to support remote index

kbobyrev updated this revision to Diff 259604. kbobyrev added a comment. Implement (B) for now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78521/new/ https://reviews.llvm.org/D78521 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-

[PATCH] D77592: [NFC][CodeGen] Add enum for selecting the layout of components in the vtable

leonardchan updated this revision to Diff 259602. leonardchan added a comment. Updated to reflect the changes in D72959 which make the vtable 4-byte aligned under the `Relative` layout. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D78569: [SVE][CodeGen] Lower SDIV & UDIV to SVE intrinsics

kmclaughlin updated this revision to Diff 259610. kmclaughlin added a comment. - Removed changes to handle legalisation from this patch (this will be included in a follow up) - Added AArch64ISD nodes for SDIV_PRED & UDIV_PRED - Changed LowerDIV to use the new ISD nodes rather than lowering to SVE

[clang] a880256 - [analyzer] Consider array subscripts to be interesting lvalues.

Author: Valeriy Savchenko Date: 2020-04-23T19:52:45+03:00 New Revision: a88025672f89374bfa584e2179a557f44d86da11 URL: https://github.com/llvm/llvm-project/commit/a88025672f89374bfa584e2179a557f44d86da11 DIFF: https://github.com/llvm/llvm-project/commit/a88025672f89374bfa584e2179a557f44d86da11.d

[PATCH] D78693: Make "#pragma clang attribute" support uninitialized attribute.

jfb accepted this revision. jfb added inline comments. Comment at: clang/test/Parser/pragma-attribute.cpp:190 +#pragma clang attribute pop +#pragma clang attribute push([[clang::uninitialized]], apply_to = variable) // expected-error {{attribute 'uninitialized' can't be applied

[PATCH] D78726: [CUDA] Define __CUDACC_DEBUG__ when compiling device code in debug mode

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:632 + if (mustEmitDebugInfo(DriverArgs) == EmitSameDebugInfoAsHost) +CC1Args.push_back("-D__CUDACC_DEBUG__"); + Built-in preprocessor macros are defined in clang/lib/Frontend/InitP

[PATCH] D78642: [clang-format] Handle C# property accessors when parsing lines

jbcoe marked 2 inline comments as done. jbcoe added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1344 addUnwrappedLine(); FormatTok->Type = TT_FunctionLBrace; parseBlock(/*MustBeDeclaration=*/false); MyDevelop

  1   2   3   >