a.sidorin added a comment.
Hi Gabor,
I don't feel I'm a right person to review AST-related part so I'm adding other
reviewers.
What I'm worrying about is that there is no test to check if our changes in
removeDecl are correct. Maybe https://reviews.llvm.org/D44100 is a right patch
for this but
ilya-biryukov updated this revision to Diff 146757.
ilya-biryukov added a comment.
- Removed the overload that accepts ASTContext
Repository:
rC Clang
https://reviews.llvm.org/D46000
Files:
include/clang/AST/CommentLexer.h
include/clang/AST/RawCommentList.h
lib/AST/CommentLexer.cpp
l
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: include/clang/AST/RawCommentList.h:138
+ /// the overload with ASTContext in the rest of the code.
+ std::string getFormattedText(const SourceManager &Sour
martong updated this revision to Diff 146765.
martong added a comment.
- Add FIXME
Repository:
rC Clang
https://reviews.llvm.org/D46353
Files:
lib/AST/ASTImporter.cpp
unittests/AST/ASTImporterTest.cpp
Index: unittests/AST/ASTImporterTest.cpp
martong added a comment.
Hi Aleksei,
Added the FIXME, can you help me with committing this?
Repository:
rC Clang
https://reviews.llvm.org/D46353
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
ioeric updated this revision to Diff 146770.
ioeric added a comment.
- Add heuristic to reduce false position on identifying proto headers
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46751
Files:
clangd/ClangdLSPServer.cpp
clangd/SourceCode.cpp
clangd/SourceCode.h
cl
ioeric added a comment.
> I think this is good if that's true that the comment is always there. I think
> it would be OK for this to be enabled by default, with a general option to
> turn heuristics off. Not sure what to call it...
> -use-symbol-filtering-heuristics :)
@malaperle Having an opt
RKSimon added reviewers: efriedma, hfinkel.
RKSimon added a comment.
I'm all for keeping the scalar/vector behaviour the same but I'm concerned
about constant folding not taking into account runtime rounding mode:
e,.g. SelectionDAG::getNode - we don't check the return status of
convertFromAPIn
ilya-biryukov added a comment.
Maybe move the tests back to this revision?
There are tests for code completion that don't depend on libindex or libclang
and use clang -cc1 directly, i.e. `tools/clang/test/CodeComplete`. This would
require adding a flag to clang and patching up `PrintingCodeCompl
Author: hans
Date: Tue May 15 03:19:24 2018
New Revision: 332335
URL: http://llvm.org/viewvc/llvm-project?rev=332335&view=rev
Log:
Make ast-print-record-decl.c pass on Windows after r332314
It was failing because on Windows, -ast-print prints
__single_inheritance(1) before T1.
Adding a triple is
This broke the ast-print-record-decl.c test on Windows, see for
example
http://lab.llvm.org:8011/builders/clang-with-thin-lto-windows/builds/9066
One way to reproduce the failure on Linux is to pass a Windows triple
to this ast-print command:
--- a/test/Misc/ast-print-record-decl.c
+++ b/test/Mi
martong created this revision.
martong added reviewers: a.sidorin, xazax.hun, szepet.
Herald added subscribers: cfe-commits, dkrupp, rnkovacs, mgorny.
This patch add new tests for structural equivalence. For that a new common
header is created which holds the test related language specific types
yvvan added a comment.
I will add more tests...
Comment at: test/SemaCXX/member-expr.cpp:193
+Cl0* c;
+return c.a; // expected-error {{member reference type 'PR15045::Cl0 *' is
a pointer; did you mean to use '->'?}}
+ }
ilya-biryukov wrote:
> Is this
jkorous added a comment.
Hi Bruno, I just noticed couple of implementation details.
Comment at: utils/hmaptool/hmaptool:55
+# The number of buckets must be a power of two.
+if num_buckets == 0 or (num_buckets & num_buckets - 1) != 0:
+rai
chill added a comment.
Ping?
https://reviews.llvm.org/D46439
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lebedev.ri added a comment.
Ping.
Any thoughts on these Timer changes?
Repository:
rL LLVM
https://reviews.llvm.org/D46603
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: a.sidorin
Date: Tue May 15 04:09:07 2018
New Revision: 332338
URL: http://llvm.org/viewvc/llvm-project?rev=332338&view=rev
Log:
[ASTImporter] Extend lookup logic in class templates
During import of a class template, lookup may find a forward
declaration and structural match falsely report
This revision was automatically updated to reflect the committed changes.
Closed by commit rC332338: [ASTImporter] Extend lookup logic in class templates
(authored by a.sidorin, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46353?vs=146765&id=146780#toc
Repository:
rC Cl
timcorringham created this revision.
Herald added subscribers: cfe-commits, t-tye, tpr, dstuttard, yaxunl, nhaehnle,
wdng, kzhuravl.
Added builtins for the interpolation intrinsics, and related LIT
test.
Repository:
rC Clang
https://reviews.llvm.org/D46871
Files:
include/clang/Basic/Built
This revision was automatically updated to reflect the committed changes.
Closed by commit rC332343: [Solaris] Only define _REENTRANT if -pthread
(authored by ro, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D41241
Files:
lib/Basic/Targets/OSTargets.h
Index: lib/Basic/Tar
kent08ian added a comment.
In https://reviews.llvm.org/D10833#970906, @milianw wrote:
> still looks good to me. can someone else please review and commit this?
Ping
Repository:
rC Clang
https://reviews.llvm.org/D10833
___
cfe-commits mailing l
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Nice, ship it!
Comment at: clangd/CodeComplete.cpp:317
+if (Includes && !D->IncludeHeader.empty()) {
+ // Fallback to canonical header if declaration l
>
>
> Could you provide a minimal example where USRs are not generated? It might
> be the case that there are other ways to fix it.
>
>
Sure, I'll try to reduce our testcase, but basically we have an
ASTFrontendAction [0] that adds a set of intrinsics [1] to the preprocessor
[2].
[0]
https://githu
Author: bwyma
Date: Mon May 14 14:21:22 2018
New Revision: 332296
URL: http://llvm.org/viewvc/llvm-project?rev=332296&view=rev
Log:
[CodeView] Improve debugging of virtual base class member variables
Initial support for passing the virtual base pointer offset to CodeViewDebug.
https://reviews.ll
Author: ro
Date: Tue May 15 04:36:00 2018
New Revision: 332343
URL: http://llvm.org/viewvc/llvm-project?rev=332343&view=rev
Log:
[Solaris] Only define _REENTRANT if -pthread
When looking at lib/Basic/Targets/OSTargets.h, I noticed that _REENTRANT is
defined
unconditionally on Solaris, unlike all
Hi Richard,
The for-range-examples.cpp test fails on 32-bit arm buildbots, e.g.:
http://lab.llvm.org:8011/builders/clang-cmake-armv7-full/builds/840 . Would
you please investigate?
You didn't get a notification because your commit was around the same time as a
fix for an unrelated testcase is
algrant added a comment.
There is a (stalled) proposal to add atomic integer max/min to C++:
http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2016/p0493r0.pdf . The
proposal has memory semantics similar to these builtins, i.e. unconditional
RMW. There is no limitation to 32-bit types though,
sammccall added a comment.
@malaperle to expand on what Eric said, adding proto hacks with false positives
and no way to turn them off is indeed not the way to go here!
There's probably going to be other places we want to filter symbols too, and it
should probably be extensible/customizable in s
r.stahl updated this revision to Diff 146789.
r.stahl marked 3 inline comments as done.
r.stahl edited the summary of this revision.
r.stahl added a comment.
Herald added subscribers: whisperity, mgorny.
I looked through the original patches and found quite a few more occurrences of
"function map
r.stahl added inline comments.
Comment at: include/clang/CrossTU/CrossTranslationUnit.h:114
+ llvm::Expected
+ getCrossTUDefinition(const VarDecl *VD, StringRef CrossTUDir,
+ StringRef IndexName);
xazax.hun wrote:
> I wonder if we need the
Author: nzaghen
Date: Tue May 15 06:30:56 2018
New Revision: 332350
URL: http://llvm.org/viewvc/llvm-project?rev=332350&view=rev
Log:
[clang] Update uses of DEBUG macro to LLVM_DEBUG.
The DEBUG() macro is very generic so it might clash with other projects.
The renaming was done as follows:
- git
This revision was automatically updated to reflect the committed changes.
Closed by commit rL332350: [clang] Update uses of DEBUG macro to LLVM_DEBUG.
(authored by nzaghen, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D44975?vs=14005
r.stahl updated this revision to Diff 146809.
r.stahl marked 2 inline comments as done.
r.stahl added a comment.
updated test
https://reviews.llvm.org/D46823
Files:
lib/StaticAnalyzer/Core/RegionStore.cpp
test/Analysis/initialization.c
Index: test/Analysis/initialization.c
===
r.stahl added inline comments.
Comment at: lib/StaticAnalyzer/Core/RegionStore.cpp:1650
+
+// If there is a list, but no init, it must be zero.
+if (i >= InitList->getNumInits())
NoQ wrote:
> NoQ wrote:
> > Would this work correctly if the
ilya-biryukov updated this revision to Diff 146812.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
- Rebase onto head and remove \brief from the comments, it's gone upstream now
- Rename CurrentArg to ArgIndex
Repository:
rC Clang
https://reviews.llvm.org/D4600
MTC added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:1037
+
+if (StateWholeReg && !StateNotWholeReg && CharVal.isZeroConstant()) {
+ // If the 'memset()' acts on the whole region of destination buffer and
NoQ wrote:
> I t
Hi Hans,
Thanks. Sorry for the trouble. I'll look into it.
Joel
On Tue, May 15, 2018 at 6:23 AM, Hans Wennborg wrote:
> This broke the ast-print-record-decl.c test on Windows, see for
> example http://lab.llvm.org:8011/builders/clang-with-thin-lto-
> windows/builds/9066
>
> One way to reprod
filcab accepted this revision.
filcab added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: test/Driver/rtti-options.cpp:13
// RUN: %clang -### -c -fno-rtti -frtti %s 2>&1 | FileCheck
-check-prefix=CHECK-RTTI %s
-// RUN: %clang -### -c -frtti -fno
MTC updated this revision to Diff 146816.
MTC added a comment.
- According to NoQ's suggestion, use `assumeZero()` instead of
`isZeroConstant()` to determine whether the value is 0.
- Add test `memset26_upper_UCHAR_MAX()` and `memset27_symbol()`
- Since `void *memset( void *dest, int ch, size_t c
jolesiak created this revision.
Herald added subscribers: cfe-commits, klimek.
Currently BreakBeforeParameter is set to true everytime message receiver
spans multiple lines, e.g.:
[[object block:^{
return 42;
}] aa:42 bb:42];
will be formatted:
[[object block:^{
return 42;
}] aa:42
bb:4
erik.pilkington added a comment.
> One way we could deal with this is by adding an attribute to the compiler to
> indicate "the const is a lie", that we can apply to `std::pair::first`, with
> the semantics being that a top-level `const` is ignored when determining the
> "real" type of the memb
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46524
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ilya-biryukov updated this revision to Diff 146827.
ilya-biryukov marked 6 inline comments as done.
ilya-biryukov added a comment.
- Fix code after a change in deps (getFormattedText now needs a SourceManager
instead of an ASTContext)
- Address review comments
Repository:
rCTE Clang Tools Ext
sepavloff added a comment.
@rsmith Do yo think this patch is OK to apply?
Repository:
rC Clang
https://reviews.llvm.org/D46241
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-biryukov added inline comments.
Comment at: clangd/CodeCompletionStrings.h:29
+
+/// Gets a raw documentation comment of the current active parameter
+/// of \p Result.
sammccall wrote:
> sammccall wrote:
> > ilya-biryukov wrote:
> > > ilya-biryukov wrote:
>
malaperle added a comment.
In https://reviews.llvm.org/D46751#1099097, @ioeric wrote:
> > I think this is good if that's true that the comment is always there. I
> > think it would be OK for this to be enabled by default, with a general
> > option to turn heuristics off. Not sure what to call i
mike.dvoretsky created this revision.
mike.dvoretsky added a reviewer: craig.topper.
Herald added a subscriber: cfe-commits.
This patch aims to match the changes introduced in gcc by
https://gcc.gnu.org/ml/gcc-cvs/2018-04/msg00534.html. The -mibt feature flag is
being removed, and the -fcf-prote
ioeric added a comment.
In https://reviews.llvm.org/D46751#1099479, @malaperle wrote:
> In https://reviews.llvm.org/D46751#1099097, @ioeric wrote:
>
> > > I think this is good if that's true that the comment is always there. I
> > > think it would be OK for this to be enabled by default, with a
ilya-biryukov updated this revision to Diff 146831.
ilya-biryukov added a comment.
- Added tests that all comments are being parsed.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46002
Files:
clangd/ClangdUnit.cpp
clangd/CodeComplete.cpp
unittests/clangd/CodeCompleteTest
yaxunl added a comment.
In https://reviews.llvm.org/D45900#1093160, @rjmccall wrote:
> In https://reviews.llvm.org/D45900#1093154, @yaxunl wrote:
>
> > In https://reviews.llvm.org/D45900#1083377, @rjmccall wrote:
> >
> > > Oh, I see, it's not that the lifetime intrinsics don't handle pointers in
arsenm added inline comments.
Comment at: test/CodeGenOpenCL/builtins-amdgcn-interp.cl:2-28
+// RUN: %clang_cc1 -triple amdgcn-unknown-unknown -target-cpu gfx900 -S -o -
%s | FileCheck %s --check-prefixes=CHECK,GFX9,BANK32
+// RUN: %clang_cc1 -triple amdgcn-unknown-unknown -targ
arsenm added inline comments.
Comment at: include/clang/Basic/BuiltinsAMDGPU.def:103-107
+BUILTIN(__builtin_amdgcn_interp_p1_f16, "ffUiUibUi", "nc")
+BUILTIN(__builtin_amdgcn_interp_p2_f16, "hffUiUibUi", "nc")
+BUILTIN(__builtin_amdgcn_interp_p1, "ffUiUiUi", "nc")
+BUILTIN(__buil
timcorringham added inline comments.
Comment at: include/clang/Basic/BuiltinsAMDGPU.def:103-107
+BUILTIN(__builtin_amdgcn_interp_p1_f16, "ffUiUibUi", "nc")
+BUILTIN(__builtin_amdgcn_interp_p2_f16, "hffUiUibUi", "nc")
+BUILTIN(__builtin_amdgcn_interp_p1, "ffUiUiUi", "nc")
+BUILTIN
Szelethus added a comment.
I'm afraid it'll be even more time before I post a new diff. There are some
things that `ProgramState` is lacking, so I'll get that fixed first in a
different pull request first.
Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp
ioeric updated this revision to Diff 146834.
ioeric marked 4 inline comments as done.
ioeric added a comment.
- Addressed review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46497
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.h
tejohnson updated this revision to Diff 146836.
tejohnson added a comment.
Update tests for changes to https://reviews.llvm.org/D46699
Repository:
rC Clang
https://reviews.llvm.org/D46700
Files:
test/CodeGen/thinlto-distributed-cfi-devirt.ll
test/CodeGen/thinlto-distributed-cfi.ll
Inde
ioeric updated this revision to Diff 146838.
ioeric added a comment.
- Rebase on https://reviews.llvm.org/D46676
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46497
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/CodeComplete.cpp
ioeric updated this revision to Diff 146839.
ioeric added a comment.
- Rebase...
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46497
Files:
clangd/ClangdServer.cpp
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/Headers.cpp
clangd/Headers.h
clangd/Protocol.h
Author: ioeric
Date: Tue May 15 08:23:53 2018
New Revision: 332362
URL: http://llvm.org/viewvc/llvm-project?rev=332362&view=rev
Log:
[clangd] Remove LSP command-based #include insertion.
Summary:
clangd will populate #include insertions as addtionalEdits in completion items.
The code completion
This revision was automatically updated to reflect the committed changes.
ioeric marked an inline comment as done.
Closed by commit rL332362: [clangd] Remove LSP command-based #include
insertion. (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
ioeric updated this revision to Diff 146843.
ioeric added a comment.
- Merged with origin/master
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46497
Files:
clangd/ClangdServer.cpp
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/Headers.cpp
clangd/Headers.h
cla
malaperle added a comment.
In https://reviews.llvm.org/D46751#1099235, @sammccall wrote:
> @malaperle to expand on what Eric said, adding proto hacks with false
> positives and no way to turn them off is indeed not the way to go here!
> There's probably going to be other places we want to filte
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE332363: [clangd] Populate #include insertions as
additional edits in completion items. (authored by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46497?vs=146843&id=146844
Author: ioeric
Date: Tue May 15 08:29:32 2018
New Revision: 332363
URL: http://llvm.org/viewvc/llvm-project?rev=332363&view=rev
Log:
[clangd] Populate #include insertions as additional edits in completion items.
Summary:
o Remove IncludeInsertion LSP command.
o Populate include insertion edits sy
dexonsmith added a comment.
(Somehow I missed Richard's comment when I replied last night, even though it
preceded mine by 5 hours...)
In https://reviews.llvm.org/D46834#1098727, @rsmith wrote:
> This would violate our guidelines for diagnostic messages; see
> https://clang.llvm.org/docs/Inter
martong added a comment.
Hi Aleksei,
Thanks for reviewing this.
I could synthesize a test which exercises only the `DeclContext::removeDecl`
function. This test causes an assertion without the fix.
Removed the rest of the testcases, which are not strictly connected to this
change.
==
martong updated this revision to Diff 146845.
martong marked 4 inline comments as done.
martong added a comment.
- Add test for removeDecl, remove unrelated tests
Repository:
rC Clang
https://reviews.llvm.org/D46835
Files:
lib/AST/DeclBase.cpp
unittests/AST/ASTImporterTest.cpp
unittest
martong updated this revision to Diff 146847.
martong added a comment.
- Remove unrelated CXX14 changes
Repository:
rC Clang
https://reviews.llvm.org/D46835
Files:
lib/AST/DeclBase.cpp
unittests/AST/ASTImporterTest.cpp
unittests/AST/MatchVerifier.h
Index: unittests/AST/MatchVerifier.
Author: ioeric
Date: Tue May 15 09:22:43 2018
New Revision: 332366
URL: http://llvm.org/viewvc/llvm-project?rev=332366&view=rev
Log:
[clangd] Log error message instead write to errs(). NFC
Modified:
clang-tools-extra/trunk/clangd/index/SymbolCollector.cpp
Modified: clang-tools-extra/trunk/cl
mclow.lists added a comment.
>> One way we could deal with this is by adding an attribute to the compiler to
>> indicate "the const is a lie", that we can apply to std::pair::first, with
>> the semantics being that a top-level const is ignored when determining the
>> "real" type of the member (
Author: nico
Date: Tue May 15 09:37:00 2018
New Revision: 332370
URL: http://llvm.org/viewvc/llvm-project?rev=332370&view=rev
Log:
update two comments as suggested on https://reviews.llvm.org/D46843
Modified:
cfe/trunk/tools/clang-fuzzer/CMakeLists.txt
cfe/trunk/tools/clang-fuzzer/proto-t
Author: nzaghen
Date: Tue May 15 09:37:45 2018
New Revision: 332371
URL: http://llvm.org/viewvc/llvm-project?rev=332371&view=rev
Log:
[clang-tools-extra] Update uses of DEBUG macro to LLVM_DEBUG.
The DEBUG() macro is very generic so it might clash with other projects.
The renaming was done as fol
This revision was automatically updated to reflect the committed changes.
Closed by commit rL332371: [clang-tools-extra] Update uses of DEBUG macro to
LLVM_DEBUG. (authored by nzaghen, committed by ).
Herald added subscribers: llvm-commits, klimek.
Changed prior to commit:
https://reviews.llvm.
Szelethus created this revision.
Szelethus added reviewers: xazax.hun, NoQ.
Herald added subscribers: cfe-commits, a.sidorin, rnkovacs, szepet, whisperity.
Herald added a reviewer: george.karpenkov.
Repository:
rC Clang
https://reviews.llvm.org/D46891
Files:
include/clang/StaticAnalyzer/Core
sammccall added a comment.
In https://reviews.llvm.org/D46751#1099633, @malaperle wrote:
> In https://reviews.llvm.org/D46751#1099235, @sammccall wrote:
>
> > @malaperle to expand on what Eric said, adding proto hacks with false
> > positives and no way to turn them off is indeed not the way to
tkrupa created this revision.
Herald added a subscriber: cfe-commits.
tkrupa added reviewers: craig.topper, RKSimon, spatel.
This is the patch that lowers x86 intrinsics to native IR
in order to enable optimizations.
Corresponding LLVM part: https://reviews.llvm.org/D46179
Previous https://revie
malaperle added a comment.
In https://reviews.llvm.org/D46751#1099786, @sammccall wrote:
> In https://reviews.llvm.org/D46751#1099633, @malaperle wrote:
>
> > In https://reviews.llvm.org/D46751#1099235, @sammccall wrote:
> >
> > > @malaperle to expand on what Eric said, adding proto hacks with fa
jkorous planned changes to this revision.
jkorous added a comment.
Sorry for me being dense here - since the output format is determined by input
source code there's more work to do.
I tried to change format of introduced version in couple of tests and the
output mirrors the change. That basica
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
Sorry this took so long. Please update `test/libcxx/double_include.sh.cpp` and
commit.
Repository:
rCXX libc++
https://reviews.llvm.org/D41347
jdenny created this revision.
jdenny added reviewers: aaron.ballman, rsmith, hfinkel.
Fixes bug reported at:
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20180514/228390.html
https://reviews.llvm.org/D46894
Files:
lib/AST/DeclPrinter.cpp
test/Misc/ast-print-record-decl.c
Index
Wizard created this revision.
Herald added subscribers: cfe-commits, klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46895
Files:
clang-tidy/objc/PropertyDeclarationCheck.cpp
Index: clang-tidy/objc/PropertyDeclarationCheck.cpp
==
Hi Hans,
On Tue, May 15, 2018 at 6:23 AM, Hans Wennborg wrote:
> This broke the ast-print-record-decl.c test on Windows, see for
> example http://lab.llvm.org:8011/builders/clang-with-thin-lto-
> windows/builds/9066
>
> One way to reproduce the failure on Linux is to pass a Windows triple
> to t
mclow.lists added a comment.
Herald added subscribers: bixia, christof.
What we need to do here is to here is to add a new macro
`_LIBCPP_ABI_REGEX_MEMORY` in `<__config>` (around line 89) and then make these
changes available only when this macro is defined.
By default - we get no change.
If `
rjmccall added a comment.
That would work. I think it would be reasonable for AutoVarEmission to store
that pointer if it makes things easier.
https://reviews.llvm.org/D45900
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
mclow.lists added inline comments.
Comment at: include/charconv:89
+_LIBCPP_BEGIN_NAMESPACE_STD
+
+enum class _LIBCPP_ENUM_VIS chars_format
lichray wrote:
> EricWF wrote:
> > We need to hide these names when `_LIBCPP_STD_VER < 17`, since we're not
> > allowed to
erik.pilkington added a comment.
> I am now thinking about just switching to dot format in
> ParseAvailabilityAttribute() because it's much simpler to maintain
> consistency that way.
Okay, but if we're going to treat underscores as dots while printing
diagnostics and fixits (which I think we
rsmith added a comment.
In https://reviews.llvm.org/D46845#1099732, @mclow.lists wrote:
> >> One way we could deal with this is by adding an attribute to the compiler
> >> to indicate "the const is a lie", that we can apply to std::pair::first,
> >> with the semantics being that a top-level con
Author: sammccall
Date: Tue May 15 10:43:27 2018
New Revision: 332378
URL: http://llvm.org/viewvc/llvm-project?rev=332378&view=rev
Log:
[clangd] Extract scoring/ranking logic, and shave yaks.
Summary:
Code completion scoring was embedded in CodeComplete.cpp, which is bad:
- awkward to test. The
This revision was automatically updated to reflect the committed changes.
Closed by commit rL332378: [clangd] Extract scoring/ranking logic, and shave
yaks. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D46524?
Author: abataev
Date: Tue May 15 11:01:01 2018
New Revision: 332380
URL: http://llvm.org/viewvc/llvm-project?rev=332380&view=rev
Log:
[OPENMP, NVPTX] Do not globalize variables with reference/pointer types.
In generic data-sharing mode we do not need to globalize
variables/parameters of reference
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE332382: add AR to acronyms of clang-tidy property check
(authored by Wizard, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46895?vs=146874&id=146886#toc
Repository:
rCTE Clang
Author: wizard
Date: Tue May 15 11:13:51 2018
New Revision: 332382
URL: http://llvm.org/viewvc/llvm-project?rev=332382&view=rev
Log:
add AR to acronyms of clang-tidy property check
Reviewers: hokein, benhamilton
Reviewed By: benhamilton
Subscribers: klimek, cfe-commits
Differential Revision: h
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D46894
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
Author: kparzysz
Date: Tue May 15 11:15:59 2018
New Revision: 332383
URL: http://llvm.org/viewvc/llvm-project?rev=332383&view=rev
Log:
[Hexagon] Add driver options for subtarget features
Added:
cfe/trunk/test/Driver/hexagon-memops.c
cfe/trunk/test/Driver/hexagon-nvj.c
cfe/trunk/test/D
Author: ssrivastava
Date: Tue May 15 11:28:42 2018
New Revision: 332384
URL: http://llvm.org/viewvc/llvm-project?rev=332384&view=rev
Log:
Fixed some rtti-options tests.
Certain tests in rtti-options.cpp are not really testing anything because they
are testing for the absence of -frtti option to
This revision was automatically updated to reflect the committed changes.
Closed by commit rC332384: Fixed some rtti-options tests. (authored by
ssrivastava, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46836?vs=146632&id=146893#toc
Repository:
rC Clang
https://reviews
craig.topper added a comment.
Ping @echristo
https://reviews.llvm.org/D46541
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
efriedma added a comment.
> I'm concerned about constant folding not taking into account runtime rounding
> mode
Changing the rounding mode is UB without FENV_ACCESS. And with FENV_ACCESS,
__builtin_convertvector should lower to @llvm.experimental.constrained.sitofp
etc., which won't constant
yaxunl added a comment.
In https://reviews.llvm.org/D46489#1088940, @rjmccall wrote:
> I think the right solution here is to make a CompileJobAction with type
> TY_LLVM_BC in the first place. You should get the advice of a driver expert,
> though.
There is already JobAction for TY_LLVM_BC. I
rjmccall added a comment.
In https://reviews.llvm.org/D46489#1099979, @yaxunl wrote:
> In https://reviews.llvm.org/D46489#1088940, @rjmccall wrote:
>
> > I think the right solution here is to make a CompileJobAction with type
> > TY_LLVM_BC in the first place. You should get the advice of a dri
1 - 100 of 158 matches
Mail list logo
