EricWF added inline comments.
Comment at: include/__functional_base:396
+!is_same<__uncvref_t<_Up>, reference_wrapper>::value
+>::type, bool _IsNothrow = noexcept(__bind(_VSTD::declval<_Up>()))>
+_LIBCPP_INLINE_VISIBILITY reference_wrapper(_Up&& __u)
_NOEXCEPT_(_
Author: martell
Date: Tue Nov 21 00:09:59 2017
New Revision: 318736
URL: http://llvm.org/viewvc/llvm-project?rev=318736&view=rev
Log:
[MS] add an init test for thumbv7-windows-msvc
Modified:
cfe/trunk/test/Preprocessor/init.c
Modified: cfe/trunk/test/Preprocessor/init.c
URL:
http://llvm.org
martell created this revision.
Herald added subscribers: kristof.beyls, javed.absar, rengolin, aemerson.
_WIN32 is already defined in lib/Basic/Targets/OSTargets.h
WIN32 and WIN64 are not real definitions they are typically
defined by the system headers, _WIN32 and _WIN64 are the
compiler definit
mstorsjo added a comment.
> WIN32 and WIN64 are not real definitions they are typically defined by the
> system headers, _WIN32 and _WIN64 are the compiler definitions.
Almost.
In MSVC, WIN32 and WIN64 are never defined by the compiler, neither by system
headers. Project files created by the I
mstorsjo added a comment.
... so in general I wouldn't mind doing a change like this, but I'd like to
make it consistent on ARM, i386 and x86_64 at the same time in that case,
instead of just changing aarch64.
Repository:
rL LLVM
https://reviews.llvm.org/D40285
__
martell updated this revision to Diff 123728.
Repository:
rL LLVM
https://reviews.llvm.org/D40285
Files:
lib/Basic/Targets/AArch64.cpp
lib/Basic/Targets/X86.h
test/Preprocessor/predefined-macros.c
Index: test/Preprocessor/predefined-macros.c
tcanens added inline comments.
Comment at: include/__functional_base:396
+!is_same<__uncvref_t<_Up>, reference_wrapper>::value
+>::type, bool _IsNothrow = noexcept(__bind(_VSTD::declval<_Up>()))>
+_LIBCPP_INLINE_VISIBILITY reference_wrapper(_Up&& __u)
_NOEXCEPT_(
martell added a comment.
In https://reviews.llvm.org/D40285#931241, @mstorsjo wrote:
> ... so in general I wouldn't mind doing a change like this, but I'd like to
> make it consistent on ARM, i386 and x86_64 at the same time in that case,
> instead of just changing aarch64.
Thanks for the qui
martell added a comment.
... also WINNT was defined for X86 so I just added that to note it.
what do you suggest we do with that one.
Repository:
rL LLVM
https://reviews.llvm.org/D40285
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
Author: coby
Date: Tue Nov 21 00:50:10 2017
New Revision: 318739
URL: http://llvm.org/viewvc/llvm-project?rev=318739&view=rev
Log:
[x86][inline-asm] allow recognition of MPX regs inside ms inline-asm blob
Differential Revision: https://reviews.llvm.org/D38445
Modified:
cfe/trunk/lib/Basic/Tar
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318739: [x86][inline-asm] allow recognition of MPX regs
inside ms inline-asm blob (authored by coby).
Changed prior to commit:
https://reviews.llvm.org/D38445?vs=117278&id=123730#toc
Repository:
rL L
mstorsjo added a comment.
In https://reviews.llvm.org/D40285#931242, @martell wrote:
> The easy one is to get rid of WIN64 because gcc doesn't even do that for
> mingw.
Yes it does, it behaves just the same as WIN32:
$ x86_64-w64-mingw32-gcc -E -dM - < /dev/null | grep WIN64
#define _WIN6
a.sidorin requested changes to this revision.
a.sidorin added a comment.
This revision now requires changes to proceed.
Hello Takafumi,
Could you investigate the patch https://reviews.llvm.org/D30876? It should fix
same issue. However, it also handles conflict resolution. I accidentally forgot
martell added a comment.
In https://reviews.llvm.org/D40285#931248, @mstorsjo wrote:
> I'm a little divided - either we remove both WIN32 and WIN64 from all mingw
> configurations, or we add the missing WIN32 for x86_64 mingw. Removing would
> be the strictly correct thing to do, but I'm sure i
yvvan added inline comments.
Comment at: cfe/trunk/lib/Sema/SemaOverload.cpp:6365
cast(FD)->getParent(), ObjectType,
- ObjectClassification, Args.slice(1), CandidateSet,
+ ObjectClassification, Functi
EricWF added inline comments.
Comment at: include/__functional_base:396
+!is_same<__uncvref_t<_Up>, reference_wrapper>::value
+>::type, bool _IsNothrow = noexcept(__bind(_VSTD::declval<_Up>()))>
+_LIBCPP_INLINE_VISIBILITY reference_wrapper(_Up&& __u)
_NOEXCEPT_(_
EricWF marked an inline comment as done.
EricWF added inline comments.
Comment at: test/SemaCXX/type-traits.cpp:2102-2116
+ using LRef = ConvertsToRef;
+ using RRef = ConvertsToRef;
+ using CLRef = ConvertsToRef;
+ using LongRef = ConvertsToRef;
+ { int arr[T((__is_construct
KrzysztofKapusta created this revision.
KrzysztofKapusta added a project: clang-tools-extra.
Herald added a subscriber: klimek.
This patch allows grouping multiple #include blocks together and sort all
includes as one big block.
Additionally, sorted includes can be regrouped after sorting based o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318744: [Modules TS] Added module re-export support.
(authored by hamzasood).
Changed prior to commit:
https://reviews.llvm.org/D40270?vs=123666&id=123736#toc
Repository:
rL LLVM
https://reviews.llv
Author: hamzasood
Date: Tue Nov 21 01:42:42 2017
New Revision: 318744
URL: http://llvm.org/viewvc/llvm-project?rev=318744&view=rev
Log:
[Modules TS] Added module re-export support.
This implements [dcl.modules.export] from the C++ Modules TS, which lets a
module re-export another module with the
ilya-biryukov requested changes to this revision.
ilya-biryukov added a comment.
This revision now requires changes to proceed.
I haven't looked into the `getHover` method's body yet, but here are some
comments about other parts.
Good work, BTW, this looks close to being ready.
===
EricWF added inline comments.
Comment at: src/cxa_demangle.cpp:10
+// FIXME: (possibly) incomplete list of features that clang mangles that this
+// file does not yet support:
Awesome comment!
If your awesomeness knows no bound, I would love to add currently-f
EricWF updated this revision to Diff 123741.
EricWF added a comment.
- Address spelling errors pointed out during review.
https://reviews.llvm.org/D29930
Files:
docs/LanguageExtensions.rst
include/clang/Basic/TokenKinds.def
include/clang/Basic/TypeTraits.h
lib/Parse/ParseDeclCXX.cpp
l
ro added a comment.
In https://reviews.llvm.org/D35755#931120, @krytarowski wrote:
> Do we still target Oracle Solaris or SmartOS? Just wondering and noted the
> domain change in e-mail.
Both, I'd say ;-) They still have much common heritage and the vast majority
of linker/toolchain work on
martell updated this revision to Diff 123747.
martell edited the summary of this revision.
martell added a comment.
[MINGW] normalize WIN32 macros
Repository:
rL LLVM
https://reviews.llvm.org/D40285
Files:
lib/Basic/Targets.cpp
lib/Basic/Targets.h
lib/Basic/Targets/AArch64.cpp
lib/Ba
mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: test/Preprocessor/predefined-macros.c:200
+// CHECK-X86-WIN: #define _WIN32 1
+// CHECK-X86-WIN-NOT: #define _WIN64 1
+// CHECK-X86-WIN-NOT: #define WINN
Author: a.sidorin
Date: Tue Nov 21 03:05:28 2017
New Revision: 318750
URL: http://llvm.org/viewvc/llvm-project?rev=318750&view=rev
Log:
[Analyzer] Non-determinism: stable iteration on indirect goto LabelDecl's
CFG wass built in non-deterministic order due to the fact that indirect
goto labels' de
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318750: [Analyzer] Non-determinism: stable iteration on
indirect goto LabelDecl's (authored by a.sidorin).
Changed prior to commit:
https://reviews.llvm.org/D40073?vs=123558&id=123750#toc
Repository:
martell updated this revision to Diff 123751.
martell added a comment.
reorder test checks
Repository:
rL LLVM
https://reviews.llvm.org/D40285
Files:
lib/Basic/Targets.cpp
lib/Basic/Targets.h
lib/Basic/Targets/AArch64.cpp
lib/Basic/Targets/AArch64.h
lib/Basic/Targets/ARM.cpp
lib/
martell added a comment.
@mstorsjo can you confirm this new order looks good to you?
Repository:
rL LLVM
https://reviews.llvm.org/D40285
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Author: kosarev
Date: Tue Nov 21 03:18:06 2017
New Revision: 318752
URL: http://llvm.org/viewvc/llvm-project?rev=318752&view=rev
Log:
[CodeGen] Generate TBAA type descriptors in a more reliable manner
This patch introduces a couple of helper functions that make it
possible to handle the caching l
mstorsjo accepted this revision.
mstorsjo added a comment.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D40285
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318752: [CodeGen] Generate TBAA type descriptors in a more
reliable manner (authored by kosarev).
Changed prior to commit:
https://reviews.llvm.org/D39953?vs=123563&id=123754#toc
Repository:
rL LLVM
Author: a.sidorin
Date: Tue Nov 21 03:20:07 2017
New Revision: 318753
URL: http://llvm.org/viewvc/llvm-project?rev=318753&view=rev
Log:
[Analyzer] Revert r318750 because incorrect files were added for commit.
Sorry for the noise.
Removed:
cfe/trunk/test/Analysis/cfg-indirect-goto-determinis
NoQ added a comment.
Thank you for the patch!~
In https://reviews.llvm.org/D40073#930470, @a.sidorin wrote:
> By the way, is there a common way to write tests for non-determinism for LLVM
> test suite?
I guess the most recent update on this subject is in this thread:
https://lists.llvm.org/p
keith.walker.arm added inline comments.
Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:406
+const bool HasVFPv4 = (std::find(ItBegin, ItEnd, "+vfpv4") != ItEnd);
+const bool HasFParmv8 = (std::find(ItBegin, ItEnd, "+fp-armv8") != ItEnd);
+const bool HasFullFP16 = (
Author: a.sidorin
Date: Tue Nov 21 03:27:47 2017
New Revision: 318754
URL: http://llvm.org/viewvc/llvm-project?rev=318754&view=rev
Log:
[Analyzer] Stable iteration on indirect goto LabelDecl's to avoid
non-determinism (attempt 2)
CFG wass built in non-deterministic order due to the fact that ind
Author: martell
Date: Tue Nov 21 03:28:29 2017
New Revision: 318755
URL: http://llvm.org/viewvc/llvm-project?rev=318755&view=rev
Log:
[MINGW] normalize WIN32 macros
move _WIN64 and _WIN32 defines to lib/Basic/Targets/OSTargets.h
move WIN32, WIN64 and __MINGW64__ to addMinGWDefines
fixes __MINGW6
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318755: [MINGW] normalize WIN32 macros (authored by martell).
Changed prior to commit:
https://reviews.llvm.org/D40285?vs=123751&id=123755#toc
Repository:
rL LLVM
https://reviews.llvm.org/D40285
Fil
martell updated this revision to Diff 123758.
martell added a comment.
updated to HEAD.
added a NOT msvc test
Repository:
rL LLVM
https://reviews.llvm.org/D39673
Files:
docs/ClangCommandLineReference.rst
include/clang/Basic/LangOptions.def
include/clang/Driver/Options.td
include/clan
martell added a comment.
In https://reviews.llvm.org/D39673#929986, @mstorsjo wrote:
> I'm not sure if this is the right thing to do. Since the exception handling
> model more or less also defines what ABI the code conforms to, I can see it
> being useful to know what exception handling mode is
xazax.hun requested changes to this revision.
xazax.hun added a comment.
This revision now requires changes to proceed.
In https://reviews.llvm.org/D39049#928620, @danielmarjamaki wrote:
> > So what are the arguments that are passed to getSimplifiedOffset() in
> that case? 0? That does not see
martell added a comment.
Just as a note there is still a lot to be desired here. I do not particularly
like the `UseSEHExceptions` function default and the actual macro definition
guards should be based on the current `ExceptionModel` because we set that in
`lib/CodeGen/BackendUtil.cpp`. This w
sberg created this revision.
Herald added a subscriber: kubamracek.
...when such an operation is done on an object during con-/destruction.
This adds a test case to compiler-rt/test/ubsan/TestCases/TypeCheck/vptr.cpp
that, unlike the existing test cases there, wants to detect multiple UBSan
war
pasko accepted this revision.
pasko added a comment.
This revision is now accepted and ready to land.
Instrumenting the function entry post-inlining, without function exit, and with
no parameters is exactly what we need. The `__cyg_profile_func_enter_bare`
sounds good to me as a name. Thank you!
sberg added a comment.
Some items I'm unclear about:
- Should those additional calls to EmitTypeCheck be restricted via those
SkippedChecks or not?
- Maybe there's a better way to add tests for this than to try shoehorn it into
the existing vptr.cpp?
https://reviews.llvm.org/D40295
__
tk1012 added a comment.
Oh, yes.
https://reviews.llvm.org/D30876 is motivated by the same problem.
The notable difference between this patch and https://reviews.llvm.org/D30876
is that ASTImporter should check the conflict resolution for the unnamed
structs/unions in a record context or not.
T
sepavloff accepted this revision.
sepavloff added a comment.
This revision is now accepted and ready to land.
LGTM.
Thanks!
https://reviews.llvm.org/D40013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
paulwalker-arm created this revision.
Plant an inline version of "((ac+bd)/(cc+dd)) + i((bc-ad)/(cc+dd))" instead.
https://reviews.llvm.org/D40299
Files:
lib/CodeGen/CGExprComplex.cpp
test/CodeGen/complex-math.c
Index: test/CodeGen/complex-math.c
===
tstellar added a comment.
Ping.
https://reviews.llvm.org/D34848
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rL LLVM
https://reviews.llvm.org/D40281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
ilya-biryukov created this revision.
In-memory preambles will not be copied anymore, so we need to make
sure they outlive the AST.
https://reviews.llvm.org/D40301
Files:
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
Index: clangd/ClangdUnit.h
===
ilya-biryukov created this revision.
Preambles are large and we should prefer not to copy it.
https://reviews.llvm.org/D40302
Files:
include/clang/Frontend/PrecompiledPreamble.h
lib/Frontend/PrecompiledPreamble.cpp
Index: lib/Frontend/PrecompiledPreamble.cpp
==
a.sidorin added a comment.
No need to apologize. Thank you for your work anyway. Even if the bug-fixing
part of this patch will be omitted, I'd still like to add your tests into the
test suite.
https://reviews.llvm.org/D39886
___
cfe-commits maili
a.sidorin added a comment.
Hello Aaron,
This patch is OK for me but could you please take a look at ASTMatchers changes?
https://reviews.llvm.org/D39722
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
xazax.hun requested changes to this revision.
xazax.hun added a comment.
This revision now requires changes to proceed.
The checker documentation should be updated as well.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:2251
+// will generate TypeTraitExpr <...> 'int'
+co
Author: hahnfeld
Date: Tue Nov 21 06:44:45 2017
New Revision: 318763
URL: http://llvm.org/viewvc/llvm-project?rev=318763&view=rev
Log:
[OpenMP] Consistently use cubin extension for nvlink
This was previously done in some places, but for example not for
bundling so that single object compilation w
This revision was automatically updated to reflect the committed changes.
Hahnfeld marked an inline comment as done.
Closed by commit rL318763: [OpenMP] Consistently use cubin extension for nvlink
(authored by Hahnfeld).
Changed prior to commit:
https://reviews.llvm.org/D40250?vs=123649&id=1237
Author: epilk
Date: Tue Nov 21 07:04:08 2017
New Revision: 318765
URL: http://llvm.org/viewvc/llvm-project?rev=318765&view=rev
Log:
[demangler] Document some features that the demangler doesn't yet support, NFC
Modified:
libcxxabi/trunk/src/cxa_demangle.cpp
libcxxabi/trunk/test/test_deman
Author: hahnfeld
Date: Tue Nov 21 07:06:28 2017
New Revision: 318767
URL: http://llvm.org/viewvc/llvm-project?rev=318767&view=rev
Log:
Add target triples to openmp-offload-gpu.c
This might fix the failure on Green Dragon.
Modified:
cfe/trunk/test/Driver/openmp-offload-gpu.c
Modified: cfe/tr
MTC updated this revision to Diff 123783.
MTC added a comment.
Herald added subscribers: a.sidorin, rnkovacs.
Update diff, use the SourceLocation of the first element of the entered block
as the argument of `PathDiagnosticLocation`.
https://reviews.llvm.org/D37187
Files:
lib/StaticAnalyzer/C
erik.pilkington updated this revision to Diff 123787.
erik.pilkington added a comment.
In this new patch:
- Update the comment BNF to show the new attribute, fix comment formatting
- Move call to parse_abi_tag_seq() from parse_unqualified_name() to
parse_operator_name() to more closely model BNF
erik.pilkington marked 5 inline comments as done.
erik.pilkington added inline comments.
Comment at: src/cxa_demangle.cpp:10
+// FIXME: (possibly) incomplete list of features that clang mangles that this
+// file does not yet support:
EricWF wrote:
> Awesome co
MTC marked an inline comment as done.
MTC added inline comments.
Comment at: lib/StaticAnalyzer/Core/PathDiagnostic.cpp:694
+ } else if (Optional BE = P.getAs()) {
+CFGElement BlockFront = BE->getBlock()->front();
+if (BlockFront.getKind() == CFGElement::Statement) {
---
tk1012 updated this revision to Diff 123792.
tk1012 added a comment.
Hello Gábor,
Thank you for responding.
I move the definition of the mather `typeTraitExpr` into
unittests/AST/ASTImporterTest.cpp.
I also slightly modify the test code.
https://reviews.llvm.org/D39722
Files:
lib/AST/ASTIm
Typz added a comment.
Generally, this indeed improves the situation (though I cannot say much about
the code itself, it is still too subtle for my shallow knowledge of
clang-format).
But it seems to give some strange looking result with long comments: it seems
like the decision is made at each
sammccall added inline comments.
Comment at: clangd/JSONExpr.h:62
+// Array and Object also have typed indexing accessors for easy traversal:
+// if (json::obj* Opts = O.array("options"))
+// if (Optional Font = Opts->string("font"))
ioeric wrote:
> It's no
sammccall updated this revision to Diff 123794.
sammccall added a comment.
Address comment.
https://reviews.llvm.org/D40182
Files:
clangd/JSONExpr.cpp
clangd/JSONExpr.h
unittests/clangd/JSONExprTests.cpp
Index: unittests/clangd/JSONExprTests.cpp
==
mattcary added a comment.
It looks like there also has to be a change to
llvm/lib/Transforms/Utils/EntryExitInstrumenter.cpp?
Index: lib/Transforms/Utils/EntryExitInstrumenter.cpp
=
- lib/Transforms/Utils/EntryExitInstrumenter.cpp(revi
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D40182
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Typz added a comment.
In https://reviews.llvm.org/D33589#924716, @klimek wrote:
> One interesting trade-off I'm running into:
> My gut feeling is that we really want to make local decisions about whether
> we want to break/reflow - this makes the code significantly simpler (IMO),
> and handles
spatel added a comment.
Ping.
https://reviews.llvm.org/D40044
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Typz added a comment.
In https://reviews.llvm.org/D33589#925903, @klimek wrote:
> I think this patch doesn't handle a couple of cases that I'd like to see
> handled. A counter-proposal with different trade-offs is in
> https://reviews.llvm.org/D40068.
It may be simpler (though not to my eyes,
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
https://reviews.llvm.org/D40279
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: sammccall
Date: Tue Nov 21 08:00:53 2017
New Revision: 318774
URL: http://llvm.org/viewvc/llvm-project?rev=318774&view=rev
Log:
[clangd] Add parsing and value inspection to JSONExpr.
Summary:
This will replace the places where we're using YAMLParser to parse JSON now:
- the new marshall
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318774: [clangd] Add parsing and value inspection to
JSONExpr. (authored by sammccall).
Repository:
rL LLVM
https://reviews.llvm.org/D40182
Files:
clang-tools-extra/trunk/clangd/JSONExpr.cpp
clang
klimek created this revision.
This fixes some bugs in the reflowing logic and splits out the concerns
of reflowing from BreakableToken.
Things to do after this patch:
- Refactor the breakProtrudingToken function possibly into a class, so we can
split it up into methods that operate on the commo
Typz added a comment.
Btw, another issue I am having is that reflowing does not respect the
alignment. For exemple:
enum {
Foo,///< This is a very long comment
Bar,///< This is shorter
BarBar, ///< This is shorter
} Stuff;
will be reflown to :
enum {
Foo, //
Author: a.sidorin
Date: Tue Nov 21 08:08:41 2017
New Revision: 318776
URL: http://llvm.org/viewvc/llvm-project?rev=318776&view=rev
Log:
[ASTImporter] Support new AST nodes:
* UnresolvedUsingType
* EmptyDecl
* NamespaceAliasDecl
* UsingDecl
* UsingShadowDecl
* UsingDirectiveDecl
* Unresolve
a.sidorin closed this revision.
a.sidorin added a comment.
Closed with https://reviews.llvm.org/rL318776 (forgot Differential Revision,
sorry).
https://reviews.llvm.org/D32751
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D40065
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
Author: sammccall
Date: Tue Nov 21 08:44:16 2017
New Revision: 318778
URL: http://llvm.org/viewvc/llvm-project?rev=318778&view=rev
Log:
[clangd] Fix dumb && || bug from r318774
Modified:
clang-tools-extra/trunk/clangd/JSONExpr.cpp
Modified: clang-tools-extra/trunk/clangd/JSONExpr.cpp
URL:
h
Author: hahnfeld
Date: Tue Nov 21 08:49:11 2017
New Revision: 318779
URL: http://llvm.org/viewvc/llvm-project?rev=318779&view=rev
Log:
Fix test/OpenMP/nvptx_data_sharing.cpp
This was an oversight that stayed in the test from development.
Modified:
cfe/trunk/test/OpenMP/nvptx_data_sharing.cpp
hans added a comment.
Reid, are you happy with this too?
In https://reviews.llvm.org/D40276#931502, @pasko wrote:
> Instrumenting the function entry post-inlining, without function exit, and
> with no parameters is exactly what we need. The
> `__cyg_profile_func_enter_bare` sounds good to me a
rnk accepted this revision.
rnk added a comment.
Yep, looks good. :)
https://reviews.llvm.org/D40276
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
K-ballo updated this revision to Diff 123813.
K-ballo added a comment.
Full context diff.
https://reviews.llvm.org/D40259
Files:
include/__functional_base
include/functional
test/std/utilities/function.objects/refwrap/refwrap.assign/copy_assign.pass.cpp
test/std/utilities/function.obj
Author: sammccall
Date: Tue Nov 21 09:02:24 2017
New Revision: 318780
URL: http://llvm.org/viewvc/llvm-project?rev=318780&view=rev
Log:
[clangd] Satisfy GCC: 'changes meaning of Error'
Modified:
clang-tools-extra/trunk/clangd/JSONExpr.cpp
Modified: clang-tools-extra/trunk/clangd/JSONExpr.cpp
Author: abataev
Date: Tue Nov 21 09:08:48 2017
New Revision: 318781
URL: http://llvm.org/viewvc/llvm-project?rev=318781&view=rev
Log:
[OPENMP] Initial support for asynchronous data update, NFC.
OpenMP 5.0 introduces asynchronous data update/dependecies clauses on
target data directives. Patch add
sammccall updated this revision to Diff 123817.
sammccall added a comment.
This revision is now accepted and ready to land.
Add an option to allow impossible completions.
While here, remove 'helpful' constructors that take some subset of the params.
https://reviews.llvm.org/D39836
Files:
clan
rnk added a comment.
In https://reviews.llvm.org/D39673#931487, @martell wrote:
> Just as a note there is still a lot to be desired here. I do not particularly
> like the `UseSEHExceptions` function default and the actual macro definition
> guards should be based on the current `ExceptionModel`
Author: sammccall
Date: Tue Nov 21 09:18:30 2017
New Revision: 318782
URL: http://llvm.org/viewvc/llvm-project?rev=318782&view=rev
Log:
[clangd] Include the right header for std::isxdigit
Modified:
clang-tools-extra/trunk/clangd/JSONExpr.cpp
Modified: clang-tools-extra/trunk/clangd/JSONExpr.
sammccall updated this revision to Diff 123819.
sammccall added a comment.
(trying to resync the diff to head)
https://reviews.llvm.org/D39836
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/ClangdUnit.cpp
clangd/Clangd
sammccall requested review of this revision.
sammccall added a comment.
PTAL - this is now optional. The results will be hidden by default, but can be
turned on with a flag.
https://reviews.llvm.org/D39836
___
cfe-commits mailing list
cfe-commits@l
Author: hans
Date: Tue Nov 21 09:30:34 2017
New Revision: 318785
URL: http://llvm.org/viewvc/llvm-project?rev=318785&view=rev
Log:
Add -finstrument-function-entry-bare flag
This is an instrumentation flag that's similar to
-finstrument-functions, but it only inserts calls on function entry, the
c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318785: Add -finstrument-function-entry-bare flag (authored
by hans).
Changed prior to commit:
https://reviews.llvm.org/D40276?vs=123691&id=123821#toc
Repository:
rL LLVM
https://reviews.llvm.org/D4
tra added inline comments.
Comment at: clang/lib/Sema/SemaType.cpp:2188
+ !Context.getTargetInfo().isVLASupported() &&
+ shouldDiagnoseTargetSupportFromOpenMP()) {
+ // Some targets don't support VLAs.
rjmccall wrote:
> Please wri
hfinkel added a comment.
> When Sema sees this code during compilation, it can not tell whether there is
> an error. Calling foo from the host code is perfectly valid. Calling it from
> device code is not. CUDADiagIfDeviceCode creates 'postponed' diagnostics
> which only gets emitted if we ever
tra updated this revision to Diff 123823.
tra added a comment.
Updated to partially address rjmccall@ comments.
https://reviews.llvm.org/D40275
Files:
clang/lib/Sema/SemaType.cpp
clang/test/SemaCUDA/vla.cu
Index: clang/test/SemaCUDA/vla.cu
=
tra added inline comments.
Comment at: clang/lib/Sema/SemaType.cpp:2188
+ !Context.getTargetInfo().isVLASupported() &&
+ shouldDiagnoseTargetSupportFromOpenMP()) {
+ // Some targets don't support VLAs.
tra wrote:
> rjmccall wrote:
tra added a comment.
In https://reviews.llvm.org/D40275#931947, @hfinkel wrote:
> > When Sema sees this code during compilation, it can not tell whether there
> > is an error. Calling foo from the host code is perfectly valid. Calling it
> > from device code is not. CUDADiagIfDeviceCode creates
1 - 100 of 170 matches
Mail list logo
