erik.pilkington marked 5 inline comments as done. erik.pilkington added inline comments.
================ Comment at: src/cxa_demangle.cpp:10 +// FIXME: (possibly) incomplete list of features that clang mangles that this +// file does not yet support: ---------------- EricWF wrote: > Awesome comment! > > If your awesomeness knows no bound, I would love to add currently-failing > tests that demonstrate the FIXME. > Obviously that has no bearing on how this patch proceeds. Sure, r318765 ================ Comment at: src/cxa_demangle.cpp:1848 +// <abi-tag> ::= B <positive length number> <identifier> + +const char* ---------------- EricWF wrote: > I realize the unneeded blank line is part of the existing style... But I > fudging hate it. > > If you're not opposed I would love to start removing the unneeded line > wherever it's > part of this changeset. I'm not opposed! The new patch removes it in the functions I touched https://reviews.llvm.org/D40279 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
