Author: djasper
Date: Wed Oct 11 00:47:54 2017
New Revision: 315439
URL: http://llvm.org/viewvc/llvm-project?rev=315439&view=rev
Log:
Revert r314955: "Remove PendingBody mechanism for function and ObjC method
deserialization."
This is breaking a build of https://github.com/abseil/abseil-cpp and
jklaehn marked an inline comment as done.
jklaehn added a comment.
In https://reviews.llvm.org/D36973#893851, @jbcoe wrote:
> LGTM
>
> Would you like me to commit this for you?
Yes, that would be great!
https://reviews.llvm.org/D36973
___
cfe-com
hokein accepted this revision.
hokein added a comment.
LGTM, let's check in it.
Repository:
rL LLVM
https://reviews.llvm.org/D38402
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jklaehn added a comment.
In https://reviews.llvm.org/D36955#893856, @jbcoe wrote:
> LGTM
>
> Would you like me to commit this for you?
Yes, I would appreciate it.
https://reviews.llvm.org/D36955
___
cfe-commits mailing list
cfe-commits@lists.llvm
kosarev updated this revision to Diff 118551.
kosarev added a comment.
Removed changes related to functions like getNaturalTypeAlignment() that
generate LValue base info objects to simplify the patch. These removed changes
will be addressed with separate patches.
https://reviews.llvm.org/D3873
hokein added a comment.
The code looks most good to me, a few nits.
Comment at: lib/Basic/DiagnosticIDs.cpp:46
unsigned WarnShowInSystemHeader : 1;
- unsigned Category : 5;
+ unsigned Category : 6;
just curious: is this change needed?
kosarev created this revision.
kosarev added a project: clang.
Prepared on top of https://reviews.llvm.org/D38733.
Repository:
rL LLVM
https://reviews.llvm.org/D38788
Files:
CodeGen/CGClass.cpp
CodeGen/CGExpr.cpp
CodeGen/CodeGenFunction.h
Index: CodeGen/CodeGenFunction.h
olista01 accepted this revision.
olista01 added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D38452
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
hokein updated this revision to Diff 118573.
hokein marked 3 inline comments as done.
hokein added a comment.
Address review comments.
https://reviews.llvm.org/D38723
Files:
lib/Tooling/Refactoring/Rename/USRLocFinder.cpp
unittests/Rename/RenameClassTest.cpp
Index: unittests/Rename/RenameC
kosarev created this revision.
kosarev added a project: clang.
This patch should not bring in any functional changes. Prepared on top of
https://reviews.llvm.org/D38733.
Repository:
rL LLVM
https://reviews.llvm.org/D38791
Files:
CodeGen/CGExpr.cpp
CodeGen/CodeGenFunction.h
Index: Code
kosarev created this revision.
kosarev added a project: clang.
Repository:
rL LLVM
https://reviews.llvm.org/D38793
Files:
CodeGen/CGExpr.cpp
CodeGen/CodeGenFunction.h
Index: CodeGen/CodeGenFunction.h
===
--- CodeGen/CodeGenF
kosarev created this revision.
kosarev added a project: clang.
This patch should not bring in any functional changes. Prepared on top of
https://reviews.llvm.org/D38733, https://reviews.llvm.org/D38788,
https://reviews.llvm.org/D38791 and https://reviews.llvm.org/D38793.
Repository:
rL LLVM
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315452: [clang-rename] Don't add prefix qualifiers to the
declaration and definition of… (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D38723?vs=118573&id=118587#toc
Repositor
Author: hokein
Date: Wed Oct 11 04:15:48 2017
New Revision: 315452
URL: http://llvm.org/viewvc/llvm-project?rev=315452&view=rev
Log:
[clang-rename] Don't add prefix qualifiers to the declaration and definition of
the renamed symbol.
Reviewers: ioeric
Reviewed By: ioeric
Subscribers: klimek, cf
Author: bader
Date: Wed Oct 11 04:16:31 2017
New Revision: 315453
URL: http://llvm.org/viewvc/llvm-project?rev=315453&view=rev
Log:
[OpenCL] Allow function declaration with empty argument list.
Treat 'f()' as 'f(void)' rather than a function w/o a prototype.
Reviewers: Anastasia, yaxunl
Reviewe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315453: [OpenCL] Allow function declaration with empty
argument list. (authored by bader).
Changed prior to commit:
https://reviews.llvm.org/D33681?vs=118437&id=118588#toc
Repository:
rL LLVM
https:
kosarev created this revision.
kosarev added a project: clang.
Prepared on top of https://reviews.llvm.org/D38733.
Repository:
rL LLVM
https://reviews.llvm.org/D38795
Files:
CodeGen/CGExpr.cpp
Index: CodeGen/CGExpr.cpp
===
-
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Core/IssueHash.cpp:39
+ // primary template.
+ if (const FunctionDecl *InstantiatedFrom =
+ Target->getInstantiatedFromMemberFunction())
martong wrote:
> Could we use here FunctionDecl::ge
martong added inline comments.
Comment at: test/Analysis/bug_hash_test.cpp:105
+void g() {
+ TX x;
+ TX xl;
As we discussed, the checking of the equality of the `IssueString` in case of
`TX` and `TX` is implicit. And as such it is hard to see that it
is reall
hamzasood added a comment.
I have access now, so I'm able to commit this myself.
However it's been a while since it was approved, so I'd be grateful if someone
could take another look to make sure nothing has changed in the meantime
(besides potentially needing to re-tag some new APIs).
https:
baloghadamsoftware added a comment.
I tried to extend the type to avoid overflow scenarios. Unfortunately, this
breaks essential calculations based on the overflow scenarios (e.g.
ProgramSate::assumeInbound()). So I see no other option than to abandon this
patch and return to the local solution
mstorsjo added a comment.
@mgrang, did you ever get to completing this? I've got a need for this now
(only `__dmb` so far), and if you don't have time, I can try to finish it.
https://reviews.llvm.org/D36111
___
cfe-commits mailing list
cfe-commits
kosarev created this revision.
kosarev added a project: clang.
Prepared on top of https://reviews.llvm.org/D38795.
Repository:
rL LLVM
https://reviews.llvm.org/D38796
Files:
CodeGen/CGExpr.cpp
CodeGen/CodeGenFunction.cpp
CodeGen/CodeGenFunction.h
CodeGen/CodeGenModule.cpp
CodeGen/C
NoQ created this revision.
Herald added a subscriber: szepet.
In https://bugs.llvm.org/show_bug.cgi?id=34460 CStringChecker tries to
`evalCast()` a memory region from `void *` to `char *` for the purposes of
modeling `mempcpy()`. The memory region turned out to be an element region of
type `uns
NoQ added inline comments.
Comment at: test/Analysis/casts.c:134-139
+ clang_analyzer_eval(y1 == y2); // expected-warning{{TRUE}}
+
+ // FIXME: should be FALSE (i.e. equal pointers).
+ clang_analyzer_eval(y1 - y2); // expected-warning{{UNKNOWN}}
+ // FIXME: should be TRUE (i.
hokein added a comment.
Sorry for the delay. I saw you have reverted this commit somehow. A post commit.
Comment at: cfe/trunk/lib/Tooling/Refactoring/Rename/RenamingAction.cpp:113
Rules.push_back(createRefactoringActionRule(
-SymbolSelectionRequirement()));
+
Author: hokein
Date: Wed Oct 11 07:00:42 2017
New Revision: 315459
URL: http://llvm.org/viewvc/llvm-project?rev=315459&view=rev
Log:
[clang-rename] Add more unittest.
Modified:
cfe/trunk/unittests/Rename/RenameClassTest.cpp
Modified: cfe/trunk/unittests/Rename/RenameClassTest.cpp
URL:
http:
grokos created this revision.
grokos added a project: clang.
This patch completes the support for the "declare target" directive in Sema.
With this patch Sema handles implicitly used functions (i.e. functions which
are used inside a target region without having been "declared target")
including
jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D38679
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
NoQ created this revision.
Herald added a subscriber: szepet.
In https://reviews.llvm.org/D38358, we ended up believing that reading the
first byte of the void pointer is not the intended behavior of
`ProgramState::getSVal(Loc)`. Hence the fix.
Additionally, allow specifying the type in the `Pr
szdominik updated this revision to Diff 118617.
szdominik marked 4 inline comments as done.
szdominik added a comment.
Small changes after aaron.ballman's comments.
https://reviews.llvm.org/D33722
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/CopyConstructorInitCheck.cpp
clang-tid
szdominik added inline comments.
Comment at: clang-tidy/misc/CopyConstructorInitCheck.cpp:37
+
+ // We match here because we want one warning (and FixIt) for every ctor.
+ const auto Matches = match(
aaron.ballman wrote:
> Wouldn't registering this matcher achi
arphaman added a comment.
In https://reviews.llvm.org/D37856#894638, @hokein wrote:
> Sorry for the delay. I saw you have reverted this commit somehow. A post
> commit.
I had some issues with ppc64/s390x bots for some reason, so I had to revert.
I'm still trying to investigate what went wrong
Author: danielmarjamaki
Date: Wed Oct 11 07:49:35 2017
New Revision: 315462
URL: http://llvm.org/viewvc/llvm-project?rev=315462&view=rev
Log:
[Analyzer] Clarify error messages for undefined result
Differential Revision: https://reviews.llvm.org/D30295
Modified:
cfe/trunk/include/clang/Stati
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315462: [Analyzer] Clarify error messages for undefined
result (authored by danielmarjamaki).
Changed prior to commit:
https://reviews.llvm.org/D30295?vs=116865&id=118620#toc
Repository:
rL LLVM
htt
Author: morehouse
Date: Wed Oct 11 08:13:53 2017
New Revision: 315463
URL: http://llvm.org/viewvc/llvm-project?rev=315463&view=rev
Log:
[clang-fuzzer] Fix shared library dependencies.
Modified:
cfe/trunk/tools/clang-fuzzer/CMakeLists.txt
cfe/trunk/tools/clang-fuzzer/handle-cxx/CMakeLists.
NoQ updated this revision to Diff 118625.
NoQ added a comment.
Herald added a subscriber: szepet.
Because i didn't get back to this in a while, and similar crashes keep coming,
i decided to leave this refactoring as a FIXME.
https://reviews.llvm.org/D23963
Files:
lib/StaticAnalyzer/Core/Regi
Author: abataev
Date: Wed Oct 11 08:29:40 2017
New Revision: 315464
URL: http://llvm.org/viewvc/llvm-project?rev=315464&view=rev
Log:
[OPENMP] Fix PR34916: Crash on mixing taskloop|tasks directives.
If both taskloop and task directives are used at the same time in one
program, we may ran into the
rwols accepted this revision.
rwols added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D38720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM - thanks!
https://reviews.llvm.org/D38757
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
Author: morehouse
Date: Wed Oct 11 08:51:12 2017
New Revision: 315465
URL: http://llvm.org/viewvc/llvm-project?rev=315465&view=rev
Log:
Reland "[clang-fuzzer] Allow building without coverage instrumentation."
This relands r315336 after fixing bot breakage.
Added:
cfe/trunk/tools/clang-fuzzer
Author: abataev
Date: Wed Oct 11 08:56:38 2017
New Revision: 315467
URL: http://llvm.org/viewvc/llvm-project?rev=315467&view=rev
Log:
[OPENMP] Remove extra if, NFC.
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
URL:
http://llvm.org/v
Author: ctopper
Date: Wed Oct 11 09:06:08 2017
New Revision: 315470
URL: http://llvm.org/viewvc/llvm-project?rev=315470&view=rev
Log:
[X86] Correct type for argument to clflushopt intrinsic.
Summary: According to Intel docs this should take void const *. We had char*.
The lack of const is the ma
hokein added inline comments.
Comment at: cfe/trunk/lib/Tooling/Refactoring/Rename/RenamingAction.cpp:113
Rules.push_back(createRefactoringActionRule(
-SymbolSelectionRequirement()));
+SymbolSelectionRequirement(), OptionRequirement()));
return Rules;
--
jlebar accepted this revision.
jlebar added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9726
+ case NVPTX::BI__hmma_m16n16k16_ld_c_f16:
+case NVPTX::BI__hmma_m16n16k16_ld_c_f32:{
+Address Dst = EmitPointer
tra updated this revision to Diff 118636.
tra marked 6 inline comments as done.
tra added a comment.
Addressed Justin's comments.
https://reviews.llvm.org/D38742
Files:
clang/include/clang/Basic/BuiltinsNVPTX.def
clang/lib/CodeGen/CGBuiltin.cpp
clang/test/CodeGen/builtins-nvptx-sm_70.cu
tra added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9726
+ case NVPTX::BI__hmma_m16n16k16_ld_c_f16:
+case NVPTX::BI__hmma_m16n16k16_ld_c_f32:{
+Address Dst = EmitPointerWithAlignment(E->getArg(0));
jlebar wrote:
> weird indentation?
My
Nebiroth marked 3 inline comments as done.
Nebiroth added inline comments.
Comment at: clangd/ClangdUnit.cpp:1017
+
+ auto DeclLocationsFinder = std::make_shared(
+ llvm::errs(), SourceLocationBeg, AST.getASTContext(),
ilya-biryukov wrote:
> I wonder if we
bsdjhb updated this revision to Diff 118638.
bsdjhb added a comment.
- Add more soft-float checks.
https://reviews.llvm.org/D38110
Files:
include/__libunwind_config.h
include/libunwind.h
src/Registers.hpp
src/UnwindCursor.hpp
src/UnwindRegistersRestore.S
src/UnwindRegistersSave.S
jlebar added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9733
+ return nullptr;
+bool isColMajor = isColMajorArg.getZExtValue();
+unsigned IID;
tra wrote:
> jlebar wrote:
> > Urg, this isn't a bool? Do we want it to be?
> There are
george.karpenkov created this revision.
Herald added subscribers: szepet, kristof.beyls, xazax.hun, javed.absar,
aemerson.
https://reviews.llvm.org/D38810
Files:
lib/Analysis/BodyFarm.cpp
test/Analysis/call_once.cpp
Index: test/Analysis/call_once.cpp
erichkeane updated this revision to Diff 118648.
erichkeane added a comment.
Craig noticed a pair of ordering issues in the TargetArray list, so fixed htose.
https://reviews.llvm.org/D38596
Files:
include/clang/AST/Decl.h
include/clang/Basic/Attr.td
include/clang/Basic/DiagnosticSemaKinds
danielmarjamaki added a comment.
In https://reviews.llvm.org/D37897#892667, @dcoughlin wrote:
> Apologies for the delay reviewing! As I noted inline, I'm pretty worried
> about the performance impact of this. Is it possible to do the analysis in a
> single traversal of the translation unit?
I
morehouse created this revision.
Herald added a subscriber: mgorny.
Makes clang-[proto-]fuzzer compatible with flags specified by OSS-Fuzz.
https://llvm.org/pr34314
https://reviews.llvm.org/D38812
Files:
clang/tools/clang-fuzzer/CMakeLists.txt
Index: clang/tools/clang-fuzzer/CMakeLists.txt
kcc accepted this revision.
kcc added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D38812
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
LGTM with the dyn_cast mentioned inline changed.
Comment at: lib/Analysis/BodyFarm.cpp:359
+ ValueDecl *FieldDecl = dyn_cast(FoundDecl);
bool isLambdaCall = Callb
Author: morehouse
Date: Wed Oct 11 11:29:24 2017
New Revision: 315486
URL: http://llvm.org/viewvc/llvm-project?rev=315486&view=rev
Log:
[clang-fuzzer] Allow linking with any fuzzing engine.
Summary:
Makes clang-[proto-]fuzzer compatible with flags specified by OSS-Fuzz.
https://llvm.org/pr34314
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315486: [clang-fuzzer] Allow linking with any fuzzing
engine. (authored by morehouse).
Changed prior to commit:
https://reviews.llvm.org/D38812?vs=118651&id=118655#toc
Repository:
rL LLVM
https://re
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
This looks good to me.
https://reviews.llvm.org/D38797
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
george.karpenkov marked 9 inline comments as done.
george.karpenkov added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/NonnullStringConstantsChecker.cpp:22
+// Checker uses are defined in the test file:
+// - test/Analysis/nonnull-string-constants.mm
+//
--
george.karpenkov updated this revision to Diff 118657.
george.karpenkov marked 2 inline comments as done.
https://reviews.llvm.org/D38764
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/NonnullStringConstantsChe
Author: george.karpenkov
Date: Wed Oct 11 11:39:40 2017
New Revision: 315488
URL: http://llvm.org/viewvc/llvm-project?rev=315488&view=rev
Log:
[Analyzer] Assume that string-like const globals are non-nil.
Differential Revision: https://reviews.llvm.org/D38764
Added:
cfe/trunk/lib/StaticAnaly
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315488: [Analyzer] Assume that string-like const globals are
non-nil. (authored by george.karpenkov).
Changed prior to commit:
https://reviews.llvm.org/D38764?vs=118657&id=118660#toc
Repository:
rL L
Author: george.karpenkov
Date: Wed Oct 11 11:42:39 2017
New Revision: 315489
URL: http://llvm.org/viewvc/llvm-project?rev=315489&view=rev
Log:
[Analyzer] Remove dead code from testing scripts
Differential Revision: https://reviews.llvm.org/D38488
Modified:
cfe/trunk/utils/analyzer/SATestBuil
Nebiroth added a comment.
Bumping this.
I've worked on a patch for this feature that currently supports showing the
declaration of whatever is being hovered on instead of the raw source code. It
also has basic support to distinguish declarations in types ( class/struct,
namespace, global varia
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Sure.
https://reviews.llvm.org/D38733
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
OK. Seems reasonable!
https://reviews.llvm.org/D23963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
Author: george.karpenkov
Date: Wed Oct 11 12:13:15 2017
New Revision: 315492
URL: http://llvm.org/viewvc/llvm-project?rev=315492&view=rev
Log:
[Analyzer] Fix introduced regression: properly check for nullable attribute.
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/NonnullStringConstantsChe
On Fri, Oct 6, 2017 at 3:27 PM, Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: aaronballman
> Date: Fri Oct 6 06:27:59 2017
> New Revision: 315060
>
> URL: http://llvm.org/viewvc/llvm-project?rev=315060&view=rev
> Log:
> Renaming a test to start with the name of the
mstorsjo added a comment.
In https://reviews.llvm.org/D38679#894668, @jroelofs wrote:
> LGTM
Thanks, will push this one without the docs update since it's still buggy in
practice on windows until https://reviews.llvm.org/D38680 gets resolved.
https://reviews.llvm.org/D38679
__
mgrang added a comment.
In https://reviews.llvm.org/D36111#894604, @mstorsjo wrote:
> @mgrang, did you ever get to completing this? I've got a need for this now
> (only `__dmb` so far), and if you don't have time, I can try to finish it.
Sorry, I never got to complete this as I moved to other
On Wed, Oct 11, 2017 at 3:29 PM, Alexander Kornienko wrote:
> On Fri, Oct 6, 2017 at 3:27 PM, Aaron Ballman via cfe-commits
> wrote:
>>
>> Author: aaronballman
>> Date: Fri Oct 6 06:27:59 2017
>> New Revision: 315060
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=315060&view=rev
>> Log:
>> R
mstorsjo added a comment.
In https://reviews.llvm.org/D36111#895084, @mgrang wrote:
> Sorry, I never got to complete this as I moved to other priorities. I do not
> think I have cycles to do this now. Please feel free to take over this patch
> :)
Ok - will do! Thanks for letting me know!
ht
arichardson created this revision.
Herald added subscribers: Anastasia, nhaehnle, jholewinski.
Currently both clang AST address spaces and target specific address spaces
are represented as unsigned which can lead to subtle errors if the wrong
type is passed. It is especially confusing in the CodeG
Author: mstorsjo
Date: Wed Oct 11 13:06:18 2017
New Revision: 315498
URL: http://llvm.org/viewvc/llvm-project?rev=315498&view=rev
Log:
Support DWARF unwinding on i386 windows
In practice, with code built with clang, there are still unresolved
issues with DW_CFA_GNU_args_size though.
Differential
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315498: Support DWARF unwinding on i386 windows (authored by
mstorsjo).
Changed prior to commit:
https://reviews.llvm.org/D38679?vs=118263&id=118673#toc
Repository:
rL LLVM
https://reviews.llvm.org/
yaxunl updated this revision to Diff 118677.
yaxunl marked 2 inline comments as done.
yaxunl added a comment.
Revised by Anastasia's comments. Get block invoke function by API instead of
iterate through IR's. Pass the block kernel directly to `__enqueu_kernel
functions`.
https://reviews.llvm.o
mstorsjo created this revision.
Herald added a subscriber: aprantl.
Clang doesn't currently support building for windows/x86_64 with dwarf by
setting command line parameters, but if manually modified to use dwarf, we can
make libunwind work in this configuration as well.
Even if support for thi
yaxunl added a comment.
If there is no other issues. May I commit this patch now? Thanks.
https://reviews.llvm.org/D35082
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Carrot created this revision.
In function GetIntrinsic, not all types are covered. Types double and long long
are missed, type long is wrongly treated same as int, it should be same as long
long. These problems cause compiler crashes when compiling code in PR31161.
This patch fixed the problem.
jlebar added a comment.
My only regret is that I have but one +1 to give to this patch.
Comment at: include/clang/Basic/AddressSpaces.h:51
+namespace LanguageAS {
/// The type of a lookup table which maps from language-specific address spaces
I wonder if you
eugenis added a comment.
ping
https://reviews.llvm.org/D38430
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: morehouse
Date: Wed Oct 11 13:45:10 2017
New Revision: 315506
URL: http://llvm.org/viewvc/llvm-project?rev=315506&view=rev
Log:
[clang-fuzzer] Build with newer protobuf-mutator.
Modified:
cfe/trunk/cmake/modules/ProtobufMutator.cmake
Modified: cfe/trunk/cmake/modules/ProtobufMutator.
mstorsjo added a comment.
As further explanation/justification - libcxxabi and libunwind don't support
SEH exceptions yet.
https://reviews.llvm.org/D38819
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315508: [Analyzer] Support bodyfarming libstdc++
implementation of std::call_once. (authored by george.karpenkov).
Changed prior to commit:
https://reviews.llvm.org/D38810?vs=118644&id=118686#toc
Repos
Author: george.karpenkov
Date: Wed Oct 11 13:53:01 2017
New Revision: 315508
URL: http://llvm.org/viewvc/llvm-project?rev=315508&view=rev
Log:
[Analyzer] Support bodyfarming libstdc++ implementation of std::call_once.
Differential Revision: https://reviews.llvm.org/D38810
Modified:
cfe/trunk
Nebiroth marked an inline comment as done.
Nebiroth added inline comments.
Comment at: clangd/ClangdUnit.cpp:784
+/// Finds declarations locations that a given source location refers to.
+class TargetDeclarationFinder : public index::IndexDataConsumer {
+ std::vector Declaration
mstorsjo created this revision.
Herald added subscribers: kristof.beyls, javed.absar, aemerson.
This is an update to https://reviews.llvm.org/D36111 by @mgrang, taking over
finishing of this patch. Compared to his version, this makes the intrinsics
conditional to ALL_MS_LANGUAGES.
https://revi
rjmccall added a comment.
It sounds like there's agreement about the basic technical direction of
introducing LangAS::opencl_private. Please introduce isAddressSpaceImplicit()
in a different patch and make this patch just about the introduction of
LangAS::opencl_private. You can have the pret
craig.topper created this revision.
Herald added a subscriber: krytarowski.
We were using corei7 for a large swatch of Intel CPUs. gcc has a different
defines that more closely match the march flags. This updates to match. It
also fixes skylake-avx512 and adds silvermont in addition to slm.
h
arphaman added inline comments.
Comment at: lib/Basic/DiagnosticIDs.cpp:46
unsigned WarnShowInSystemHeader : 1;
- unsigned Category : 5;
+ unsigned Category : 6;
hokein wrote:
> just curious: is this change needed?
I get a build warning without this change
arphaman updated this revision to Diff 118701.
arphaman marked 2 inline comments as done.
arphaman added a comment.
- rename the common consumer class.
Repository:
rL LLVM
https://reviews.llvm.org/D38772
Files:
include/clang/Basic/AllDiagnostics.h
include/clang/Basic/CMakeLists.txt
inc
arichardson added inline comments.
Comment at: include/clang/Basic/AddressSpaces.h:51
+namespace LanguageAS {
/// The type of a lookup table which maps from language-specific address spaces
jlebar wrote:
> I wonder if you need this namespace? LangAS right nex
jlebar added a comment.
> The only reason I added this namespace is that I wasn't sure whether having
> those functions in the clang namespace is acceptable.
Maybe someone else will object, or suggest an existing namespace they should be
in. FWIW I think it's fine.
> Not quite sure what to ca
Author: ctopper
Date: Wed Oct 11 14:42:02 2017
New Revision: 315517
URL: http://llvm.org/viewvc/llvm-project?rev=315517&view=rev
Log:
[X86] Add support for 'amdfam17h' to __builtin_cpu_is to match gcc.
The compiler-rt implementation already supported it, it just wasn't exposed.
Modified:
cfe
rnk added inline comments.
Comment at: src/libunwind.cpp:188
+ co->getInfo(&info);
+ pint_t orgArgSize = (pint_t)info.gp;
+ uint64_t orgFuncStart = info.start_ip;
I think it makes sense to have this here: the contract is that if the
personality se
Author: vedantk
Date: Wed Oct 11 14:54:09 2017
New Revision: 315518
URL: http://llvm.org/viewvc/llvm-project?rev=315518&view=rev
Log:
[Driver] Export symbols needed to use profile runtime
Apple's API verification tool (tapi) checks that the symbols exported
from a program match a whitelist. When
yaxunl marked 2 inline comments as done.
yaxunl added a comment.
In https://reviews.llvm.org/D35082#895230, @rjmccall wrote:
> It sounds like there's agreement about the basic technical direction of
> introducing LangAS::opencl_private. Please introduce
> isAddressSpaceImplicit() in a differen
mgrang added a comment.
LGTM.
https://reviews.llvm.org/D38821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chandlerc added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:844-845
-// FIXME: Historically, we defined this legacy name, it would be nice to
-// remove it at some point. We've never exposed fine-grained names for
-// recent primary x86 CPUs, and we should
1 - 100 of 125 matches
Mail list logo
