chandlerc added inline comments.
================
Comment at: lib/Basic/Targets/X86.cpp:844-845
- // FIXME: Historically, we defined this legacy name, it would be nice to
- // remove it at some point. We've never exposed fine-grained names for
- // recent primary x86 CPUs, and we should keep it that way.
- defineCPUMacros(Builder, "corei7");
----------------
This seems to undo the idea that we should keep avoiding exposing fine-grained
CPU names? What's new that changes this?
================
Comment at: lib/Basic/Targets/X86.cpp:852
+ defineCPUMacros(Builder, "core_avx2");
+ defineCPUMacros(Builder, "haswell");
break;
----------------
I find calling a Westmere CPU `nehalem` a little odd. Calling IvyBridge a
`sandybridge' CPU seems quite confusing. But calling Skylake (client) and
Cannonlake (all? client?) `haswell` seems .... deeply weird.
https://reviews.llvm.org/D38824
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
