jina.nahias added inline comments.
Comment at: include/clang/Basic/BuiltinsX86.def:981
-TARGET_BUILTIN(__builtin_ia32_pbroadcastd512_gpr_mask, "V16iiV16iUs", "",
"avx512f")
TARGET_BUILTIN(__builtin_ia32_pbroadcastq512_mem_mask, "V8LLiLLiV8LLiUc", "",
"avx512f")
TARGET_BUILTIN
ilya-biryukov added a comment.
In https://reviews.llvm.org/D37101#868207, @rwols wrote:
> Thanks! Thinking ahead now so we're on the same page, you will be
> implementing the client's initialize request, and I'll start work on
> textDocument/signatureHelp.
Sounds good.
https://reviews.llvm.
Author: chapuni
Date: Wed Sep 13 00:58:46 2017
New Revision: 313128
URL: http://llvm.org/viewvc/llvm-project?rev=313128&view=rev
Log:
clang/lib/Driver/ToolChains/Darwin.h: Add proper style to comments.
[-Wdocumentation]
Modified:
cfe/trunk/lib/Driver/ToolChains/Darwin.h
Modified: cfe/trunk/
sylvestre.ledru created this revision.
Herald added a subscriber: klimek.
As defined here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Classes
See for the downstream bug report:
https://bugzilla.mozilla.org/show_bug.cgi?id=1399359
https://reviews.llvm.org/D377
SjoerdMeijer updated this revision to Diff 114998.
SjoerdMeijer added a comment.
Fixed the typos, and added tests.
https://reviews.llvm.org/D34695
Files:
lib/Frontend/InitPreprocessor.cpp
lib/Headers/float.h
test/Headers/float16.c
test/Preprocessor/init.c
Index: test/Preprocessor/init.
Author: uriel.k
Date: Wed Sep 13 02:02:02 2017
New Revision: 313133
URL: http://llvm.org/viewvc/llvm-project?rev=313133&view=rev
Log:
[X86] [PATCH] [intrinsics] Lowering X86 ABS intrinsics to IR. (clang)
This patch, together with a matching llvm patch
(https://reviews.llvm.org/D37693), implement
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313133: [X86] [PATCH] [intrinsics] Lowering X86 ABS
intrinsics to IR. (clang) (authored by uriel.k).
Changed prior to commit:
https://reviews.llvm.org/D37694?vs=114613&id=115001#toc
Repository:
rL LL
hfinkel added a comment.
In https://reviews.llvm.org/D37436#868333, @aaron.ballman wrote:
> In https://reviews.llvm.org/D37436#868295, @hfinkel wrote:
>
> > In https://reviews.llvm.org/D37436#867965, @aaron.ballman wrote:
> >
> > > In https://reviews.llvm.org/D37436#867287, @rsmith wrote:
> > >
>
hfinkel added a comment.
Also, please post a full-context patch.
https://reviews.llvm.org/D37436
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
krasimir added a comment.
Patch looks good, but I also would like to see it splited. I would suggest to
first get the statement macro part in, which requires less code. Then we can
put the namespace macros on top of that. I really like the generality of this
approach and would want to also add
Author: abataev
Date: Wed Sep 13 04:12:35 2017
New Revision: 313141
URL: http://llvm.org/viewvc/llvm-project?rev=313141&view=rev
Log:
[OPENMP] Allow all classes as mappable types.
According to upcoming OpenMP 5.0 all classes/structs are now considered
as mappable, even polymorphic and with static
Hello Galina,
I tried to re-create the issue but with no success. I ran the test on versions
before and after my commit, using your builder’s cmake properties, and the test
passed each time.
There doesn’t seem to be a connection between my commit’s changes and the
failed test.
We checked the t
aaron.ballman added a comment.
In https://reviews.llvm.org/D37436#869350, @hfinkel wrote:
> In https://reviews.llvm.org/D37436#868333, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D37436#868295, @hfinkel wrote:
> >
> > > In https://reviews.llvm.org/D37436#867965, @aaron.ballman wrote:
mikhail.ramalho marked an inline comment as done.
mikhail.ramalho added a comment.
ping
https://reviews.llvm.org/D36610
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman updated this revision to Diff 115015.
aaron.ballman added a comment.
Added full context, no other changes from previous patch.
https://reviews.llvm.org/D37436
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/Attributes.h
clang/include/clang/Basic/LangOption
hfinkel added a comment.
In https://reviews.llvm.org/D37436#869445, @aaron.ballman wrote:
> In https://reviews.llvm.org/D37436#869350, @hfinkel wrote:
>
> > In https://reviews.llvm.org/D37436#868333, @aaron.ballman wrote:
> >
> > > In https://reviews.llvm.org/D37436#868295, @hfinkel wrote:
> > >
aaron.ballman added a comment.
In https://reviews.llvm.org/D37436#869462, @hfinkel wrote:
> I think that I misunderstood your concern. Let me see if I can summarize your
> position: You believe that, when GCC implements this syntax in C, they will
> audit their attributes and not support all of
johannes updated this revision to Diff 115018.
johannes added a comment.
use CXXOperatorCallExpr::isPrefixOp() to determine whether it's infix or postfix
directly traverse statement children instead of copying
https://reviews.llvm.org/D37663
Files:
include/clang/AST/ExprCXX.h
include/clang/
johannes added inline comments.
Comment at: include/clang/AST/RecursiveASTVisitor.h:327
+
+ SmallVector getStmtChildren(CXXOperatorCallExpr *CE) {
+SmallVector Children(CE->children());
rsmith wrote:
> The copy here is more expensive than I'd like. Instead o
nik added a comment.
Ping
https://reviews.llvm.org/D37554
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia created this revision.
Added missing `addrspacecast` case in alignment computation logic of pointer
type emission in IR generation.
https://reviews.llvm.org/D37804
Files:
lib/CodeGen/CGExpr.cpp
test/CodeGenOpenCL/vectorLoadStore.cl
Index: test/CodeGenOpenCL/vectorLoadStore.cl
=
NoQ created this revision.
The self-debugging method to add dumps of the checker's internal state to
program state dumps and exploded graphs.
I'm looking into enabling this checker by default, so more patches would follow.
https://reviews.llvm.org/D37805
Files:
lib/StaticAnalyzer/Checkers/P
NoQ created this revision.
`lck_mtx_lock()` returns `void`. The analyzer failed to model its effect
because he was surprised that the return value is `Unknown`. Prepare for the
aforementioned surprise and fix the tests accordingly.
https://reviews.llvm.org/D37806
Files:
lib/StaticAnalyzer/C
NoQ created this revision.
It turns out that XNU rwlocks, locked by `lck_rw_lock_shared()` and
`lck_rw_lock_exclusive()`, can be unlocked through either the "unspecific"
`lck_rw_done()` or the "specific" `lck_rw_unlock_shared()` and
`lck_rw_unlock_exclusive()` calls. Add the two "specific" unlo
JonasToth added a comment.
I added a clarifying comment for some outcommented code still in the patch. I
would like to have a bit of discussion on it.
Maybe some parts of the check could be warning-area, i just implemented it here
to have it on one place.
Comment at: clang-ti
MontyKutyi added a comment.
Ping.
https://reviews.llvm.org/D34030
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ created this revision.
Use `CallEvent` and `CallDescription` everywhere. Unhardcode argument numbers
in AcquireLock() etc. Have a list of supported functions in one place. Other
misc cleanup. No functional change intended anywhere.
https://reviews.llvm.org/D37809
Files:
lib/StaticAnalyz
JonasToth updated this revision to Diff 115037.
JonasToth marked 3 inline comments as done.
JonasToth added a comment.
- fix the first issues i found
https://reviews.llvm.org/D37808
Files:
clang-tidy/hicpp/CMakeLists.txt
clang-tidy/hicpp/HICPPTidyModule.cpp
clang-tidy/hicpp/MultiwayPathsC
JonasToth added a comment.
fixed first stuff, sorry for noise.
https://reviews.llvm.org/D37808
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Eugene.Zelenko added a comment.
I think will be good idea to extend -Wswitch diagnostics.
https://reviews.llvm.org/D37808
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ updated this revision to Diff 115042.
NoQ added a comment.
Don't forget to check that the function is a global C function in post-call.
https://reviews.llvm.org/D37809
Files:
lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp
test/Analysis/Inputs/system-header-simulator-for-pthread-lock
JonasToth added a comment.
In https://reviews.llvm.org/D37808#869602, @Eugene.Zelenko wrote:
> I think will be good idea to extend -Wswitch diagnostics.
Ok. But it will introduce new warnings to llvm codebase itself. I prepare some
example output i found right now.
https://reviews.llvm.org/D
Typz added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:1339
+unsigned ContinuationIndenter::breakProtrudingToken(const FormatToken &Current,
+LineState &State,
djasper wrote:
> Can you cre
Author: alexfh
Date: Wed Sep 13 07:55:13 2017
New Revision: 313150
URL: http://llvm.org/viewvc/llvm-project?rev=313150&view=rev
Log:
[clang-tidy] fixed misc-unused-parameters omitting parameters default value
Summary:
Bug: https://bugs.llvm.org/show_bug.cgi?id=34450
**Problem:**
Clang-tidy chec
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313150: [clang-tidy] fixed misc-unused-parameters omitting
parameters default value (authored by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D37566?vs=114538&id=115047#toc
Repository:
alexfh added a comment.
In https://reviews.llvm.org/D37566#866096, @PriMee wrote:
> Done :) Could you please commit this for me?
Sure, just committed the patch.
Repository:
rL LLVM
https://reviews.llvm.org/D37566
___
cfe-commits mailing list
c
rogfer01 accepted this revision.
rogfer01 added a subscriber: rsmith.
rogfer01 added a comment.
This revision is now accepted and ready to land.
This LGTM, but wait a couple of days before comitting in case @rsmith or
@scanon (or others!) have further comments.
https://reviews.llvm.org/D34695
scanon accepted this revision.
scanon added a comment.
LGTM as well.
https://reviews.llvm.org/D34695
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
SjoerdMeijer added a comment.
many thanks for reviewing and your help.
https://reviews.llvm.org/D34695
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313152: This adds the _Float16 preprocessor macro
definitions. (authored by SjoerdMeijer).
Changed prior to commit:
https://reviews.llvm.org/D34695?vs=114998&id=115050#toc
Repository:
rL LLVM
https:
Author: sjoerdmeijer
Date: Wed Sep 13 08:23:19 2017
New Revision: 313152
URL: http://llvm.org/viewvc/llvm-project?rev=313152&view=rev
Log:
This adds the _Float16 preprocessor macro definitions.
Differential Revision: https://reviews.llvm.org/D34695
Added:
cfe/trunk/test/Headers/float16.c
Mod
Typz updated this revision to Diff 115051.
Typz added a comment.
Reorder the functions to minimize diff.
https://reviews.llvm.org/D33589
Files:
lib/Format/ContinuationIndenter.cpp
lib/Format/ContinuationIndenter.h
lib/Format/UnwrappedLineFormatter.cpp
unittests/Format/FormatTest.cpp
In
Typz marked 8 inline comments as done.
Typz added inline comments.
Comment at: lib/Format/NamespaceEndCommentsFixer.cpp:155
const FormatToken *NamespaceTok = AnnotatedLines[StartLineIndex]->First;
- // Detect "(inline)? namespace" in the beginning of a line.
- if (NamespaceT
zaks.anna added a comment.
How about committing the refactor of the code without test modifications. And
committing changes to the test separately?
https://reviews.llvm.org/D37809
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp:271
}
-assert(lockFail && lockSucc);
-C.addTransition(lockFail);
-
+// We might want to handle the case when the mutex lock function was
inlined
+// and returned
Typz updated this revision to Diff 115054.
Typz marked 2 inline comments as done.
Typz added a comment.
Fix review comments, before splitting the commit.
https://reviews.llvm.org/D33440
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/FormatToken.h
lib/Format/Format
NoQ created this revision.
As usual, we need to invalidate mutex states when something may touch them.
Implement this boilerplate for the thread lock checker.
The previous refactoring is handy for listing functions on which we don't need
to invalidate mutex states because we model them instead.
Typz updated this revision to Diff 115057.
Typz added a comment.
Split diff: handle only statements in here, namespace macros will be moved to
another one.
https://reviews.llvm.org/D33440
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/FormatToken.h
lib/Format/For
Typz created this revision.
Other macros are used to declare namespaces, and should thus be handled
similarly. This is the case for crpcut's TESTSUITE macro, or for
unittest-cpp's SUITE macro:
TESTSUITE(Foo) {
TEST(MyFirstTest) {
assert(0);
}
} // TESTSUITE(Foo)
This patch deals with
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lgtm too
https://reviews.llvm.org/D37564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Author: alexfh
Date: Wed Sep 13 10:03:58 2017
New Revision: 313156
URL: http://llvm.org/viewvc/llvm-project?rev=313156&view=rev
Log:
Update users of llvm::sys::ExecuteAndWait etc.
Summary: Clang part of https://reviews.llvm.org/D37563
Reviewers: bkramer
Subscribers: vsk, cfe-commits
Differenti
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313156: Update users of llvm::sys::ExecuteAndWait etc.
(authored by alexfh).
Repository:
rL LLVM
https://reviews.llvm.org/D37564
Files:
cfe/trunk/include/clang/Driver/Compilation.h
cfe/trunk/inclu
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D37785
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
Eugene.Zelenko added a comment.
In https://reviews.llvm.org/D37808#869612, @JonasToth wrote:
> In https://reviews.llvm.org/D37808#869602, @Eugene.Zelenko wrote:
>
> > I think will be good idea to extend -Wswitch diagnostics.
>
>
> Ok. But it will introduce new warnings to llvm codebase itself. I
lebedev.ri added a comment.
What about GNU extension `case 1 ... 3:` ?
https://reviews.llvm.org/D37808
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: alexfh
Date: Wed Sep 13 10:45:51 2017
New Revision: 313162
URL: http://llvm.org/viewvc/llvm-project?rev=313162&view=rev
Log:
Attempt to fix MSVC build.
Modified:
cfe/trunk/lib/Driver/Job.cpp
Modified: cfe/trunk/lib/Driver/Job.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/li
hfinkel added a comment.
In https://reviews.llvm.org/D37436#869467, @aaron.ballman wrote:
> In https://reviews.llvm.org/D37436#869462, @hfinkel wrote:
>
> > I think that I misunderstood your concern. Let me see if I can summarize
> > your position: You believe that, when GCC implements this synt
aaron.ballman added a comment.
In https://reviews.llvm.org/D37436#869851, @hfinkel wrote:
> In https://reviews.llvm.org/D37436#869467, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D37436#869462, @hfinkel wrote:
> >
> > > I think that I misunderstood your concern. Let me see if I can su
JonasToth added a comment.
In https://reviews.llvm.org/D37808#869823, @lebedev.ri wrote:
> What about GNU extension `case 1 ... 3:` ?
Strictly speaking, the coding standard (which should be enforced by the patch)
requires strict ISO C++11, therefore this extension is not considered directly.
D
b-sumner accepted this revision.
b-sumner added a comment.
This revision is now accepted and ready to land.
Looks good to me.
https://reviews.llvm.org/D37703
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
lebedev.ri added a comment.
In https://reviews.llvm.org/D37808#869879, @JonasToth wrote:
> In https://reviews.llvm.org/D37808#869823, @lebedev.ri wrote:
>
> > What about GNU extension `case 1 ... 3:` ?
>
>
> Strictly speaking, the coding standard (which should be enforced by the
> patch) require
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D37787
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: pcc
Date: Wed Sep 13 11:36:07 2017
New Revision: 313169
URL: http://llvm.org/viewvc/llvm-project?rev=313169&view=rev
Log:
Driver: Make -fwhole-program-vtables a core option so it can be used from
clang-cl.
Also add some missing driver tests for the regular clang driver.
Differential Rev
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313169: Driver: Make -fwhole-program-vtables a core option
so it can be used from clang… (authored by pcc).
Changed prior to commit:
https://reviews.llvm.org/D37787?vs=114960&id=115082#toc
Repository:
vsapsai added a comment.
Correcting typo in Sema::ActOnMemberAccessExpr is an interesting idea and it
almost works. After such change there is a single failure in
clang/test/SemaCXX/typo-correction-cxx11.cpp
void run(A *annotations) {
map new_annotations;
auto &annotation = *annota
vivekvpandya updated this revision to Diff 115085.
vivekvpandya added a comment.
update
https://reviews.llvm.org/D37196
Files:
lib/CodeGen/CodeGenAction.cpp
Index: lib/CodeGen/CodeGenAction.cpp
===
--- lib/CodeGen/CodeGenAction
vivekvpandya updated this revision to Diff 115086.
vivekvpandya added a comment.
Added method to detach unique_ptr from LLVMContext.
https://reviews.llvm.org/D33514
Files:
include/llvm/Analysis/OptimizationDiagnosticInfo.h
include/llvm/CodeGen/MachineOptimizationRemarkEmitter.h
include/ll
Author: yaxunl
Date: Wed Sep 13 11:50:42 2017
New Revision: 313171
URL: http://llvm.org/viewvc/llvm-project?rev=313171&view=rev
Log:
[AMDGPU] Change addr space of clk_event_t, queue_t and reserve_id_t to global
Differential Revision: https://reviews.llvm.org/D37703
Modified:
cfe/trunk/lib/Ba
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313171: [AMDGPU] Change addr space of clk_event_t, queue_t
and reserve_id_t to global (authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D37703?vs=114642&id=115088#toc
Repository:
zturner created this revision.
Herald added a reviewer: modocache.
Herald added a subscriber: fedor.sergeev.
This is probably the last work I'm going to do here for a while. I still see
some room for improvement, but I think after this patch:
a) refactor begins to have diminishing returns
b) Th
Author: yaxunl
Date: Wed Sep 13 11:56:25 2017
New Revision: 313172
URL: http://llvm.org/viewvc/llvm-project?rev=313172&view=rev
Log:
Add more tests for OpenCL atomic builtin functions
Add tests for different address spaces and insert some blank lines to make them
more readable.
Differential Rev
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313172: Add more tests for OpenCL atomic builtin functions
(authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D37742?vs=114824&id=115090#toc
Repository:
rL LLVM
https://reviews.
On 13 October 2015 at 15:12, Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ericwf
> Date: Tue Oct 13 17:12:02 2015
> New Revision: 250235
>
> URL: http://llvm.org/viewvc/llvm-project?rev=250235&view=rev
> Log:
> [libcxx] Capture configuration information when install
On Wed, Sep 13, 2017 at 1:02 PM, Richard Smith
wrote:
> On 13 October 2015 at 15:12, Eric Fiselier via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: ericwf
>> Date: Tue Oct 13 17:12:02 2015
>> New Revision: 250235
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=250235&view=re
Author: phosek
Date: Wed Sep 13 12:17:41 2017
New Revision: 313173
URL: http://llvm.org/viewvc/llvm-project?rev=313173&view=rev
Log:
[Fuchsia] Set ENABLE_X86_RELAX_RELOCATIONS for Fuchsia builds
This is a "Does your linker support it?" option, and all ours do.
Patch by Roland McGrath
Differenti
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313173: [Fuchsia] Set ENABLE_X86_RELAX_RELOCATIONS for
Fuchsia builds (authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D37785?vs=114956&id=115094#toc
Repository:
rL LLVM
https
rnk added inline comments.
Comment at: llvm/utils/lit/lit/llvm/config.py:92
def with_environment(self, variable, value, append_path = False):
+if append_path:
Rather than having an optional parameter that makes this append, maybe have a
new method
dlj added inline comments.
Comment at: clang/test/lit.cfg:23
# the test runner updated.
-config.test_format = lit.formats.ShTest(execute_external)
+config.test_format = lit.formats.ShTest(not llvm_config.use_lit_shell)
Minor nit: it seems reasonable enough to
yaxunl created this revision.
Currently block is translated to a structure equivalent to
struct Block {
void *isa;
int flags;
int reserved;
void *invoke;
void *descriptor;
};
Except `invoke`, which is the pointer to the block invoke function,
all other fields are useless
On 13 September 2017 at 12:15, Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Wed, Sep 13, 2017 at 1:02 PM, Richard Smith
> wrote:
>
>> On 13 October 2015 at 15:12, Eric Fiselier via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> Author: ericwf
>>> Date: Tue O
andrew.w.kaylor added a comment.
Does anything else need to be done for this to be ready to land?
https://reviews.llvm.org/D37042
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This is a wild guess, but don't you need to add `REQUIRES: lld` to your
test if your test depends on lld? I don't think all bots have lld, and if
`ld.lld` is not found, clang prints out that error message.
On Tue, Sep 12, 2017 at 7:16 PM, Martell Malone
wrote:
> Just to follow up,
> The test cas
Ah, sorry, you mentioned that. Yes, I think you need it.
On Wed, Sep 13, 2017 at 1:00 PM, Rui Ueyama wrote:
> This is a wild guess, but don't you need to add `REQUIRES: lld` to your
> test if your test depends on lld? I don't think all bots have lld, and if
> `ld.lld` is not found, clang prints
Author: sylvestre
Date: Wed Sep 13 13:03:29 2017
New Revision: 313182
URL: http://llvm.org/viewvc/llvm-project?rev=313182&view=rev
Log:
SplitEmptyFunction should be true in the Mozilla coding style
Summary:
As defined here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_
cameron314 updated this revision to Diff 115104.
cameron314 edited the summary of this revision.
cameron314 added a comment.
Alright, I've changed the patch so that the preamble takes into account the BOM
presence and is invalidated when it changes. This automatically fixes all
clients of `Preco
efriedma added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6031
InGroup;
+def ext_gnu_null_ptr_arith : Extension<
+ "arithmetic on a null pointer treated as a cast from integer to pointer is a
GNU extension">,
"extension" isn't re
Author: abataev
Date: Wed Sep 13 13:20:59 2017
New Revision: 313186
URL: http://llvm.org/viewvc/llvm-project?rev=313186&view=rev
Log:
[OPENMP] Fix types for the target specific parameters in debug mode.
Used incorrect types for target specific parameters in debug mode,
should use original pointer
Hi Saleem
I just realize there can be an issue with this commit. This breaks the bitcode
compatibility when LTO linking bitcode file produced by llvm-5.0 vs the older
versions. Because the objc related module flag has the behavior Module::Error,
simple whitespace changes will cause libLTO to er
erichkeane added a comment.
Tighten up the 'IUnknown' check, and do the check I mentioned above, and I
think this logic is correct. Searching would be required in the positive case,
but this is the negative case.
Comment at: lib/Sema/SemaDeclCXX.cpp:2483
+!IsDecl
Author: amccarth
Date: Wed Sep 13 13:53:55 2017
New Revision: 313192
URL: http://llvm.org/viewvc/llvm-project?rev=313192&view=rev
Log:
Mark static member functions as static in CodeViewDebug
Summary:
To improve CodeView quality for static member functions, we need to make the
static explicit. In
ioeric added a comment.
This is very nice! Thanks!
Looks good to me; I'll let Manuel stamp the patch for you.
Comment at: include/clang/Tooling/Refactoring/RefactoringActionRules.h:56
+ virtual Expected
+ createSourceReplacements(RefactoringRuleContext &Context) = 0;
+
-
erichkeane added a comment.
Actually... disregard that... the rule is more complex than that.
Based on some playing around with MSVC on godbolt, it seems that it actually
marks any type that inherits ONLY from interface types or IUnknown as an
interface itself. We may be better off doing that
yaxunl added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:957
-return Builder.CreateBitCast(Addr, ConvertType(E->getType()));
+return Builder.CreatePointerBitCastOrAddrSpaceCast(
+Addr, ConvertType(E->getType()));
Better asser
andrew.w.kaylor added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6031
InGroup;
+def ext_gnu_null_ptr_arith : Extension<
+ "arithmetic on a null pointer treated as a cast from integer to pointer is a
GNU extension">,
efriedma wrot
efriedma added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6031
InGroup;
+def ext_gnu_null_ptr_arith : Extension<
+ "arithmetic on a null pointer treated as a cast from integer to pointer is a
GNU extension">,
andrew.w.kaylor wrot
andrew.w.kaylor added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6031
InGroup;
+def ext_gnu_null_ptr_arith : Extension<
+ "arithmetic on a null pointer treated as a cast from integer to pointer is a
GNU extension">,
efriedma wrot
Author: pcc
Date: Wed Sep 13 14:49:17 2017
New Revision: 313201
URL: http://llvm.org/viewvc/llvm-project?rev=313201&view=rev
Log:
Use -- to prevent the driver from confusing paths with flags, should fix Mac
bot.
Modified:
cfe/trunk/test/Driver/whole-program-vtables.c
Modified: cfe/trunk/tes
zahiraam updated this revision to Diff 115125.
zahiraam added a comment.
Hi have made all the changes requested.
https://reviews.llvm.org/D37308
Files:
lib/Sema/SemaDeclCXX.cpp
Index: lib/Sema/SemaDeclCXX.cpp
===
--- lib/Sema/S
efriedma added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6031
InGroup;
+def ext_gnu_null_ptr_arith : Extension<
+ "arithmetic on a null pointer treated as a cast from integer to pointer is a
GNU extension">,
andrew.w.kaylor wrot
Author: fjricci
Date: Wed Sep 13 12:40:10 2017
New Revision: 313179
URL: http://llvm.org/viewvc/llvm-project?rev=313179&view=rev
Log:
[docs] Update LeakSanitizer documentation to reflect OS X support
Reviewers: kcc, alekseyshl, kubamracek, glider
Subscribers: llvm-commits
Differential Revision:
1 - 100 of 124 matches
Mail list logo
