rnk added inline comments.

================
Comment at: llvm/utils/lit/lit/llvm/config.py:92
 
     def with_environment(self, variable, value, append_path = False):
+        if append_path:
----------------
Rather than having an optional parameter that makes this append, maybe have a 
new method that calls this one after doing the path appending. How about 
`append_environment_path(var, value)` or something?


https://reviews.llvm.org/D37818



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to