[PATCH] D21830: Remove -mrelax-all from Clang -O0

2016-06-29 Thread Dean Michael Berris via cfe-commits
dberris created this revision. dberris added reviewers: echristo, rafael, grosbach. dberris added a subscriber: cfe-commits. Herald added a subscriber: mehdi_amini. Remove the -mrelax-all options passed onto the integrated assembler in -O0. http://reviews.llvm.org/D21830 Files: lib/Driver/Tool

r274110 - [AVX512] Zero extend cmp intrinsic return value.

2016-06-29 Thread Igor Breger via cfe-commits
Author: ibreger Date: Wed Jun 29 03:14:17 2016 New Revision: 274110 URL: http://llvm.org/viewvc/llvm-project?rev=274110&view=rev Log: [AVX512] Zero extend cmp intrinsic return value. Differential Revision: http://reviews.llvm.org/D21746 Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp cfe/

Re: [PATCH] D21746: [AVX512] Zero extend cmp intrinsic return value.

2016-06-29 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL274110: [AVX512] Zero extend cmp intrinsic return value. (authored by ibreger). Changed prior to commit: http://reviews.llvm.org/D21746?vs=61953&id=62185#toc Repository: rL LLVM http://reviews.llvm

[PATCH] D21833: [clang-tidy] Fix more enum declaration cases in misc-unused-using-decls check.

2016-06-29 Thread Haojian Wu via cfe-commits
hokein created this revision. hokein added a reviewer: alexfh. hokein added subscribers: cfe-commits, Eugene.Zelenko. Fix PR28350. http://reviews.llvm.org/D21833 Files: clang-tidy/misc/UnusedUsingDeclsCheck.cpp test/clang-tidy/misc-unused-using-decls.cpp Index: test/clang-tidy/misc-unused-u

Re: [PATCH] D21501: [Driver] Add support for Broadcom Vulcan core

2016-06-29 Thread pankaj gode via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL274114: [Driver][AArch64] Add support for Broadcom Vulcan core. (authored by pgode). Changed prior to commit: http://reviews.llvm.org/D21501?vs=61192&id=62195#toc Repository: rL LLVM http://reviews.

r274114 - [Driver][AArch64] Add support for Broadcom Vulcan core.

2016-06-29 Thread Pankaj Gode via cfe-commits
Author: pgode Date: Wed Jun 29 05:00:31 2016 New Revision: 274114 URL: http://llvm.org/viewvc/llvm-project?rev=274114&view=rev Log: [Driver][AArch64] Add support for Broadcom Vulcan core. Adding support for new Broadcom Vulcan core (ARMv8.1A). Differential Revision: http://reviews.llvm.org/D2150

Re: [PATCH] D21367: AMDGPU: Set amdgpu_kernel calling convention for OpenCL kernels.

2016-06-29 Thread Nikolay Haustov via cfe-commits
nhaustov updated this revision to Diff 62198. nhaustov added a comment. Update after discussion with Sam and review from Anastasia. http://reviews.llvm.org/D21367 Files: include/clang/Basic/Specifiers.h lib/AST/ItaniumMangle.cpp lib/AST/Type.cpp lib/AST/TypePrinter.cpp lib/Basic/Targe

Re: [PATCH] D21641: Use ArgList::hasFlag to check if -miamcu/-mno-iamcu is passed. NFC.

2016-06-29 Thread Andrey Turetskiy via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL274119: Use ArgList::hasFlag to check if -miamcu/-mno-iamcu is passed. NFC. (authored by aturetsk). Changed prior to commit: http://reviews.llvm.org/D21641?vs=61662&id=62203#toc Repository: rL LLVM

r274119 - Use ArgList::hasFlag to check if -miamcu/-mno-iamcu is passed. NFC.

2016-06-29 Thread Andrey Turetskiy via cfe-commits
Author: aturetsk Date: Wed Jun 29 05:57:17 2016 New Revision: 274119 URL: http://llvm.org/viewvc/llvm-project?rev=274119&view=rev Log: Use ArgList::hasFlag to check if -miamcu/-mno-iamcu is passed. NFC. Differential Revision: http://reviews.llvm.org/D21641 Modified: cfe/trunk/lib/Driver/Driv

r274120 - [OpenCL] Fix typo in as_type test.

2016-06-29 Thread Alexey Bader via cfe-commits
Author: bader Date: Wed Jun 29 07:25:58 2016 New Revision: 274120 URL: http://llvm.org/viewvc/llvm-project?rev=274120&view=rev Log: [OpenCL] Fix typo in as_type test. Reset astype variable in f6 function to avoid matching with wrong value from f5 function. Modified: cfe/trunk/test/CodeGenOp

r274122 - [OpenCL] Add attribute 'pure' to read_image built-in functions to enable optimizations.

2016-06-29 Thread Alexey Bader via cfe-commits
Author: bader Date: Wed Jun 29 07:30:26 2016 New Revision: 274122 URL: http://llvm.org/viewvc/llvm-project?rev=274122&view=rev Log: [OpenCL] Add attribute 'pure' to read_image built-in functions to enable optimizations. Reviewers: Anastasia, yaxunl Subscribers: pekka.jaaskelainen, pxli168, cfe-

Re: [PATCH] D21795: [OpenCL] Add attribute 'pure' to read_image built-in functions to enable optimizations.

2016-06-29 Thread Alexey Bader via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL274122: [OpenCL] Add attribute 'pure' to read_image built-in functions to enable… (authored by bader). Changed prior to commit: http://reviews.llvm.org/D21795?vs=62094&id=62210#toc Repository: rL LLV

Re: [PATCH] D20334: [libcxx] Fix a bug in strstreambuf::overflow

2016-06-29 Thread Marshall Clow via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. This looks fine to me. http://reviews.llvm.org/D20334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[PATCH] D21836: [AVX512][BUILTIN] Deleting two incorrect lines, conflicting SPEC

2016-06-29 Thread michael zuckerman via cfe-commits
m_zuckerman created this revision. m_zuckerman added reviewers: AsafBadouh, igorb, delena, craig.topper. m_zuckerman added a subscriber: cfe-commits. By SPEC, instruction vpermilps gets IMM bigger than 15. Below, you can see that IMM can be any number between 0 to 255 include. SELECT4(src, con

Re: [PATCH] D21836: [AVX512][BUILTIN][vpermilps][intrinsics] Fixing two incorrect IMM check.

2016-06-29 Thread Igor Breger via cfe-commits
igorb accepted this revision. igorb added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D21836 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

2016-06-29 Thread Tavian Barnes via cfe-commits
tavianator updated this revision to Diff 62218. tavianator added a comment. Added error handling for pthread_key uses http://reviews.llvm.org/D21803 Files: cmake/config-ix.cmake src/CMakeLists.txt src/cxa_thread_atexit.cpp test/CMakeLists.txt test/cxa_thread_atexit_test.pass.cpp tes

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

2016-06-29 Thread Ben Craig via cfe-commits
bcraig added subscribers: rmaprath, bcraig. bcraig added a comment. You should look at __thread_specific_ptr in libcxx's . It does a lot of these things in order to satisfy the requirements of notify_all_at_thread_exit, set_value_at_thread_exit, and make_ready_at_thread_exit. @rmaprath has be

Re: [PATCH] D20867: [PCH] Fix timestamp check on windows hosts.

2016-06-29 Thread pierre gousseau via cfe-commits
pgousseau added a comment. Ping! http://reviews.llvm.org/D20867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

2016-06-29 Thread Dmitry Polukhin via cfe-commits
DmitryPolukhin updated this revision to Diff 62213. DmitryPolukhin marked 2 inline comments as done. DmitryPolukhin added a comment. Use SmallVector instead of SmallSetVector and sort the vector when needed. http://reviews.llvm.org/D18035 Files: lib/AST/ItaniumMangle.cpp lib/Sema/SemaDeclAt

Re: [PATCH] D21773: [clang] Update an optimization remark test for change D18777

2016-06-29 Thread Li Huang via cfe-commits
lihuang added a comment. Hi Adam, The change in http://reviews.llvm.org/D18777 breaks this test becasue it converts some sexts to zexts, which cannot be eliminated by indvar-simplification after widening IV. The IR after indvar-simplification and before loop-vectorization is like: ... %in

r274126 - [X86][SSE2] Updated tests to match llvm\test\CodeGen\X86\sse2-intrinsics-fast-isel-x86_64.ll

2016-06-29 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Wed Jun 29 09:04:08 2016 New Revision: 274126 URL: http://llvm.org/viewvc/llvm-project?rev=274126&view=rev Log: [X86][SSE2] Updated tests to match llvm\test\CodeGen\X86\sse2-intrinsics-fast-isel-x86_64.ll Modified: cfe/trunk/test/CodeGen/sse2-builtins.c Modified: cfe/t

Re: [PATCH] D21833: [clang-tidy] Fix more enum declaration cases in misc-unused-using-decls check.

2016-06-29 Thread Aaron Ballman via cfe-commits
aaron.ballman added a subscriber: aaron.ballman. Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:22 @@ +21,3 @@ +namespace { +// FIXME: Move this node matcher to ASTMatcher. +const internal::VariadicDynCastAllOfMatcher enumType; Can you fix this fixme as a p

Re: [PATCH] D21510: [libc++] Check hash before calling __hash_table key_eq function

2016-06-29 Thread Kwasi Mensah via cfe-commits
kmensah added a comment. Another friendly Ping Repository: rL LLVM http://reviews.llvm.org/D21510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r274064 - AvailabilityAttr: we accept "macos" as the platform name.

2016-06-29 Thread Aaron Ballman via cfe-commits
On Tue, Jun 28, 2016 at 4:55 PM, Manman Ren via cfe-commits wrote: > Author: mren > Date: Tue Jun 28 15:55:30 2016 > New Revision: 274064 > > URL: http://llvm.org/viewvc/llvm-project?rev=274064&view=rev > Log: > AvailabilityAttr: we accept "macos" as the platform name. > > We continue accepting "m

Re: [PATCH] D21830: Remove -mrelax-all from Clang -O0

2016-06-29 Thread Rafael Espíndola via cfe-commits
We need to benchmark this to see if it still makes a difference. My canonical test is the .s of a lto of clang. Cheers, Rafael On 29 June 2016 at 03:37, Dean Michael Berris wrote: > dberris created this revision. > dberris added reviewers: echristo, rafael, grosbach. > dberris added a subscrib

[libcxx] r274132 - [libcxx] Fix a bug in strstreambuf::overflow.

2016-06-29 Thread Akira Hatanaka via cfe-commits
Author: ahatanak Date: Wed Jun 29 10:26:13 2016 New Revision: 274132 URL: http://llvm.org/viewvc/llvm-project?rev=274132&view=rev Log: [libcxx] Fix a bug in strstreambuf::overflow. The end pointer should point to one past the end of the newly allocated buffer. rdar://problem/24265174 Differenti

Re: [PATCH] D20334: [libcxx] Fix a bug in strstreambuf::overflow

2016-06-29 Thread Akira Hatanaka via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL274132: [libcxx] Fix a bug in strstreambuf::overflow. (authored by ahatanak). Changed prior to commit: http://reviews.llvm.org/D20334?vs=58740&id=62225#toc Repository: rL LLVM http://reviews.llvm.or

Re: r274064 - AvailabilityAttr: we accept "macos" as the platform name.

2016-06-29 Thread Manman Ren via cfe-commits
Good point! In r274133. Manman On Wed, Jun 29, 2016 at 7:30 AM, Aaron Ballman wrote: > On Tue, Jun 28, 2016 at 4:55 PM, Manman Ren via cfe-commits > wrote: > > Author: mren > > Date: Tue Jun 28 15:55:30 2016 > > New Revision: 274064 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=274064&v

r274133 - AvailabilityAttr: update the document for macosx

2016-06-29 Thread Manman Ren via cfe-commits
Author: mren Date: Wed Jun 29 10:50:08 2016 New Revision: 274133 URL: http://llvm.org/viewvc/llvm-project?rev=274133&view=rev Log: AvailabilityAttr: update the document for macosx Modified: cfe/trunk/include/clang/Basic/AttrDocs.td Modified: cfe/trunk/include/clang/Basic/AttrDocs.td URL: ht

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

2016-06-29 Thread Tavian Barnes via cfe-commits
tavianator added a comment. In http://reviews.llvm.org/D21803#469988, @bcraig wrote: > You should look at __thread_specific_ptr in libcxx's . It does a lot > of these things in order to satisfy the requirements of > notify_all_at_thread_exit, set_value_at_thread_exit, and > make_ready_at_thre

Re: [PATCH] D21830: Remove -mrelax-all from Clang -O0

2016-06-29 Thread David Majnemer via cfe-commits
majnemer added a subscriber: majnemer. majnemer added a comment. Why are you making this change? I cannot see a justification in the description. http://reviews.llvm.org/D21830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

Re: [PATCH] D18171: [CUDA][OpenMP] Create generic offload action

2016-06-29 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 62230. sfantao added a comment. - Better organize how the offload action is used and add more comments to document what is going on. - Rebase. http://reviews.llvm.org/D18171 Files: include/clang/Driver/Action.h include/clang/Driver/Compilation.h incl

Re: [PATCH] D18171: [CUDA][OpenMP] Create generic offload action

2016-06-29 Thread Samuel Antao via cfe-commits
sfantao added a comment. @tra, any other comments/suggestions about this patch? Thanks! Samuel http://reviews.llvm.org/D18171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder

2016-06-29 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 62231. sfantao added a comment. - Rebase. http://reviews.llvm.org/D18172 Files: include/clang/Driver/Compilation.h lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp === --- lib/Driver/Dri

[PATCH] D21840: [Driver][CUDA][OpenMP] Reimplement tool selection in the driver.

2016-06-29 Thread Samuel Antao via cfe-commits
sfantao created this revision. sfantao added reviewers: echristo, tra, jlebar, hfinkel, ABataev, rsmith. sfantao added subscribers: carlo.bertolli, arpith-jacob, caomhin, andreybokhanko, Hahnfeld, cfe-commits. Herald added a subscriber: mehdi_amini. This creates a tool selector in the driver that

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

2016-06-29 Thread Ben Craig via cfe-commits
bcraig added a comment. In http://reviews.llvm.org/D21803#470060, @tavianator wrote: > In http://reviews.llvm.org/D21803#469988, @bcraig wrote: > > > You should look at __thread_specific_ptr in libcxx's . It does a > > lot of these things in order to satisfy the requirements of > > notify_all_

Re: [PATCH] D21783: [CodeView] Implement support for bitfields in Clang

2016-06-29 Thread Reid Kleckner via cfe-commits
rnk accepted this revision. rnk added a comment. lgtm Cute, preserves debug info compatibility at the cost of some complexity. http://reviews.llvm.org/D21783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

Re: [PATCH] D21700: [SemaExpr] Support lax conversions in assignments with vector and scalars with same size

2016-06-29 Thread Reid Kleckner via cfe-commits
rnk added a comment. After writing r266366, we discovered that GCC accepts none of the code in that test case, so we should consider turning -flax-vector-conversions off by default. Comment at: test/Sema/vector-cast.c:65 @@ -59,1 +64,3 @@ + d = f2; + d = d + f2; } -

Re: [PATCH] D21367: AMDGPU: Set amdgpu_kernel calling convention for OpenCL kernels.

2016-06-29 Thread Yaxun Liu via cfe-commits
yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! http://reviews.llvm.org/D21367 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D21843: [Driver][OpenMP] Create tool chains for OpenMP offloading kind.

2016-06-29 Thread Samuel Antao via cfe-commits
sfantao created this revision. sfantao added reviewers: echristo, tra, jlebar, hfinkel, ABataev, rsmith. sfantao added subscribers: caomhin, carlo.bertolli, arpith-jacob, Hahnfeld, cfe-commits. Herald added a subscriber: mehdi_amini. This patch adds new logic to create the necessary tool chains t

[PATCH] D21845: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions.

2016-06-29 Thread Samuel Antao via cfe-commits
sfantao created this revision. sfantao added reviewers: echristo, tra, jlebar, hfinkel, ABataev, rsmith. sfantao added subscribers: caomhin, carlo.bertolli, arpith-jacob, andreybokhanko, Hahnfeld, cfe-commits. Herald added a subscriber: mehdi_amini. This patch adds a new specialized action builde

Re: [PATCH] D21334: Add TargetInfo for 32-bit and 64-bit RenderScript

2016-06-29 Thread Pirama Arumuga Nainar via cfe-commits
pirama added a comment. Ping... http://reviews.llvm.org/D21334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

2016-06-29 Thread Pirama Arumuga Nainar via cfe-commits
pirama added a comment. Ping... http://reviews.llvm.org/D20602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

2016-06-29 Thread Asiri Rathnayake via cfe-commits
rmaprath added a comment. In http://reviews.llvm.org/D21803#470060, @tavianator wrote: > In http://reviews.llvm.org/D21803#469988, @bcraig wrote: > > > @rmaprath has been doing some work to make the threading runtime library > > swappable. I don't recall if his work extended to libcxxabi or not

[PATCH] D21847: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains.

2016-06-29 Thread Samuel Antao via cfe-commits
sfantao created this revision. sfantao added reviewers: echristo, tra, jlebar, hfinkel, ABataev, rsmith. sfantao added subscribers: caomhin, carlo.bertolli, arpith-jacob, andreybokhanko, Hahnfeld, cfe-commits. Herald added a subscriber: mehdi_amini. This patch adds logic to create jobs for OpenMP

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

2016-06-29 Thread David Majnemer via cfe-commits
majnemer added inline comments. Comment at: src/cxa_thread_atexit.cpp:64-90 @@ -18,8 +63,29 @@ +_LIBCXXABI_FUNC_VIS int __cxa_thread_atexit(Dtor dtor, void *obj, void *dso_symbol) throw() { - extern int __cxa_thread_atexit_impl(void (*

[PATCH] D21848: [Driver][OpenMP] Add logic for offloading-specific argument translation.

2016-06-29 Thread Samuel Antao via cfe-commits
sfantao created this revision. sfantao added reviewers: echristo, tra, jlebar, hfinkel, ABataev, rsmith. sfantao added subscribers: caomhin, carlo.bertolli, arpith-jacob, andreybokhanko, Hahnfeld, cfe-commits. Herald added a subscriber: mehdi_amini. This patch includes support for argument transl

Re: [PATCH] D13909: clang-offload-bundler - offload files bundling/unbundling tool

2016-06-29 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 62249. sfantao added a comment. Herald added a subscriber: mehdi_amini. - Reorganize file handlers. Generate empty files if no components exist in the bundle instead of just failing. http://reviews.llvm.org/D13909 Files: test/Driver/clang-offload-bundler

Re: [PATCH] D21834: Implementing 'If statement with Initializer'

2016-06-29 Thread Anton Bikineev via cfe-commits
AntonBikineev added a subscriber: cfe-commits. AntonBikineev updated this revision to Diff 62254. http://reviews.llvm.org/D21834 Files: include/clang/AST/Stmt.h include/clang/Parse/Parser.h include/clang/Sema/Sema.h lib/AST/ASTImporter.cpp lib/AST/Stmt.cpp lib/Analysis/BodyFarm.cpp

Re: [PATCH] D21666: [Tooling] Add optional argument to getFullyQualifiedName to prepend "::".

2016-06-29 Thread Reid Kleckner via cfe-commits
rnk accepted this revision. rnk added a comment. lgtm http://reviews.llvm.org/D21666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21851: [Driver][OpenMP][CUDA] Add capability to bundle object files in sections of the host binary format.

2016-06-29 Thread Samuel Antao via cfe-commits
sfantao created this revision. sfantao added reviewers: echristo, tra, jlebar, hfinkel, ABataev. sfantao added subscribers: caomhin, carlo.bertolli, arpith-jacob, Hahnfeld, andreybokhanko, cfe-commits. Herald added a subscriber: mehdi_amini. This patch adds the capability to bundle object files i

r274147 - Re-land "[MS] Don't expect vftables to be provided for extern template instantiations"

2016-06-29 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed Jun 29 13:29:21 2016 New Revision: 274147 URL: http://llvm.org/viewvc/llvm-project?rev=274147&view=rev Log: Re-land "[MS] Don't expect vftables to be provided for extern template instantiations" Reverts r273305 and re-instates r273296. We needed to fix a bug in Sema::MarkV

[PATCH] D21852: [Driver][OpenMP] Update actions builder to create bundling action when necessary.

2016-06-29 Thread Samuel Antao via cfe-commits
sfantao created this revision. sfantao added reviewers: echristo, tra, jlebar, hfinkel, ABataev. sfantao added subscribers: caomhin, carlo.bertolli, arpith-jacob, andreybokhanko, Hahnfeld, cfe-commits. Herald added a subscriber: mehdi_amini. In order to save the user from dealing with multiple ou

[PATCH] D21853: [Driver][OpenMP] Update actions builder to create unbundling action when necessary.

2016-06-29 Thread Samuel Antao via cfe-commits
sfantao created this revision. sfantao added reviewers: echristo, tra, jlebar, hfinkel, ABataev. sfantao added subscribers: caomhin, carlo.bertolli, arpith-jacob, andreybokhanko, Hahnfeld, cfe-commits. Herald added a subscriber: mehdi_amini. Each time that offloading support is requested by the u

[PATCH] D21856: [Driver][OpenMP] Add support to create jobs for bundling actions.

2016-06-29 Thread Samuel Antao via cfe-commits
sfantao created this revision. sfantao added reviewers: echristo, tra, jlebar, hfinkel, ABataev. sfantao added subscribers: caomhin, carlo.bertolli, arpith-jacob, andreybokhanko, Hahnfeld, cfe-commits. Herald added a subscriber: mehdi_amini. This patch adds the support to create a job for the `Of

r274149 - Add CapturedDecl::parameters() ArrayRef accessors following r273647.

2016-06-29 Thread Yaron Keren via cfe-commits
Author: yrnkrn Date: Wed Jun 29 13:55:53 2016 New Revision: 274149 URL: http://llvm.org/viewvc/llvm-project?rev=274149&view=rev Log: Add CapturedDecl::parameters() ArrayRef accessors following r273647. Modified: cfe/trunk/include/clang/AST/Decl.h Modified: cfe/trunk/include/clang/AST/Decl.h

[PATCH] D21857: [Driver][OpenMP] Add support to create jobs for unbundling actions.

2016-06-29 Thread Samuel Antao via cfe-commits
sfantao created this revision. sfantao added reviewers: echristo, tra, jlebar, hfinkel, ABataev. sfantao added subscribers: caomhin, carlo.bertolli, arpith-jacob, andreybokhanko, Hahnfeld, cfe-commits. Herald added a subscriber: mehdi_amini. This patch adds the support to create jobs for the `Off

RFC: Default language standard mode policy

2016-06-29 Thread Richard Smith via cfe-commits
Hi all! I'd like to establish a policy for Clang's default language standard (if none is specified with -std), as follows: Clang defaults to the most recent published standard for the selected language that it fully implements. The practical impact of this is that clang++ will default to C++14

Re: RFC: Default language standard mode policy

2016-06-29 Thread Nico Weber via cfe-commits
For clang-cl, we should follow cl's model of selecting a standard. Before C++17, this was "use newest language the compiler knows about" (keyed off -fmsc-version; clang-cl detects the system msvc version by default if that's not passed in). After C++17, there's an explicit language flag, and we use

Re: RFC: Default language standard mode policy

2016-06-29 Thread Richard Smith via cfe-commits
On Wed, Jun 29, 2016 at 12:14 PM, Nico Weber wrote: > For clang-cl, we should follow cl's model of selecting a standard. Before > C++17, this was "use newest language the compiler knows about" (keyed off > -fmsc-version; clang-cl detects the system msvc version by default if > that's not passed i

Re: RFC: Default language standard mode policy

2016-06-29 Thread Sean Silva via cfe-commits
On Wed, Jun 29, 2016 at 12:09 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi all! > > I'd like to establish a policy for Clang's default language standard (if > none is specified with -std), as follows: > > Clang defaults to the most recent published standard for the

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

2016-06-29 Thread Tavian Barnes via cfe-commits
tavianator added a comment. In http://reviews.llvm.org/D21803#470086, @bcraig wrote: > It also intentionally leaks the pthread key. Does the __thread_specific_ptr > rationale hold for this change as well? Hmm, maybe? If other global destructors run after ~DtorListHolder(), and they cause a

Re: [PATCH] D21031: [OpenCL] Allow -cl-std and other standard -cl- options in driver

2016-06-29 Thread Yaxun Liu via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL274150: [OpenCL] Allow -cl-std and other standard -cl- options in driver (authored by yaxunl). Changed prior to commit: http://reviews.llvm.org/D21031?vs=61574&id=62267#toc Repository: rL LLVM http:

r274150 - [OpenCL] Allow -cl-std and other standard -cl- options in driver

2016-06-29 Thread Yaxun Liu via cfe-commits
Author: yaxunl Date: Wed Jun 29 14:39:32 2016 New Revision: 274150 URL: http://llvm.org/viewvc/llvm-project?rev=274150&view=rev Log: [OpenCL] Allow -cl-std and other standard -cl- options in driver Allow -cl-std and other standard -cl- options from cc1 to driver. Added a test for the options mov

Re: RFC: Default language standard mode policy

2016-06-29 Thread Nico Weber via cfe-commits
On Wed, Jun 29, 2016 at 3:25 PM, Richard Smith wrote: > On Wed, Jun 29, 2016 at 12:14 PM, Nico Weber wrote: > >> For clang-cl, we should follow cl's model of selecting a standard. Before >> C++17, this was "use newest language the compiler knows about" (keyed off >> -fmsc-version; clang-cl detec

Re: [PATCH] D21705: Include debug info for nested structs and classes

2016-06-29 Thread Reid Kleckner via cfe-commits
rnk added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:1075 @@ +1074,3 @@ + } else if (const auto *nestedRec = dyn_cast(I)) { +if (!nestedRec->isImplicit()) + CollectRecordNestedRecord(nestedRec, elements); I would add `&& nestedR

Re: RFC: Default language standard mode policy

2016-06-29 Thread Richard Smith via cfe-commits
On Wed, Jun 29, 2016 at 12:30 PM, Sean Silva wrote: > > > On Wed, Jun 29, 2016 at 12:09 PM, Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Hi all! >> >> I'd like to establish a policy for Clang's default language standard (if >> none is specified with -std), as follows:

Re: RFC: Default language standard mode policy

2016-06-29 Thread Chandler Carruth via cfe-commits
On Wed, Jun 29, 2016 at 12:47 PM Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Wed, Jun 29, 2016 at 3:25 PM, Richard Smith > wrote: > >> Note that at this point I'd like to mainly focus on what our policy >> should be; >> > > Fair enough. I don't have a strong opinion on th

Re: RFC: Default language standard mode policy

2016-06-29 Thread Hal Finkel via cfe-commits
- Original Message - > From: "Richard Smith via cfe-commits" > To: "cfe-commits" , "Clang Dev" > > Sent: Wednesday, June 29, 2016 2:09:37 PM > Subject: RFC: Default language standard mode policy > Hi all! > I'd like to establish a policy for Clang's default language standard > (if none

Re: [cfe-dev] RFC: Default language standard mode policy

2016-06-29 Thread Richard Smith via cfe-commits
On Wed, Jun 29, 2016 at 12:55 PM, Hal Finkel via cfe-dev < cfe-...@lists.llvm.org> wrote: > > -- > > *From: *"Richard Smith via cfe-commits" > *To: *"cfe-commits" , "Clang Dev" < > cfe-...@lists.llvm.org> > *Sent: *Wednesday, June 29, 2016 2:09:37 PM > *Subject: *RFC:

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

2016-06-29 Thread Ben Craig via cfe-commits
bcraig added a comment. > Hmm, maybe? If other global destructors run after ~DtorListHolder(), and > they cause a thread_local to be initialized for the first time, > __cxa_thread_atexit() might be called again. I was thinking that dtors would > get re-initialized in that case but it appears

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

2016-06-29 Thread Richard Smith via cfe-commits
rsmith added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7907 @@ -7904,1 +7906,3 @@ +def ext_opencl_ext_vector_type_rgba_selector: ExtWarn< + "vector component name '%0' is an OpenCL version 2.2 feature">; } // end of sema category As

[PATCH] D21860: [ASTMatcher] Add a node matcher for EnumType.

2016-06-29 Thread Haojian Wu via cfe-commits
hokein created this revision. hokein added a reviewer: aaron.ballman. hokein added a subscriber: cfe-commits. Herald added a subscriber: klimek. http://reviews.llvm.org/D21860 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.c

Re: [PATCH] D21833: [clang-tidy] Fix more enum declaration cases in misc-unused-using-decls check.

2016-06-29 Thread Haojian Wu via cfe-commits
hokein marked an inline comment as done. Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:22 @@ +21,3 @@ +namespace { +// FIXME: Move this node matcher to ASTMatcher. +const internal::VariadicDynCastAllOfMatcher enumType; Done in D21860. http://reviews.llvm

Re: [PATCH] D21833: [clang-tidy] Fix more enum declaration cases in misc-unused-using-decls check.

2016-06-29 Thread Haojian Wu via cfe-commits
hokein updated this revision to Diff 62278. hokein added a comment. Address review comments. http://reviews.llvm.org/D21833 Files: clang-tidy/misc/UnusedUsingDeclsCheck.cpp test/clang-tidy/misc-unused-using-decls.cpp Index: test/clang-tidy/misc-unused-using-decls.cpp ==

r274157 - [cmake] Move creation of ClangTargets and installation of ClangConfig.cmake from ./CMakeLists.txt -> ./cmake/modules/CMakeLists.txt.

2016-06-29 Thread Michael Gottesman via cfe-commits
Author: mgottesman Date: Wed Jun 29 15:22:44 2016 New Revision: 274157 URL: http://llvm.org/viewvc/llvm-project?rev=274157&view=rev Log: [cmake] Move creation of ClangTargets and installation of ClangConfig.cmake from ./CMakeLists.txt -> ./cmake/modules/CMakeLists.txt. This matches LLVM. Added:

r274158 - [ClangConfig] Replace paths with the same value as CLANG_INSTALL_PACKAGE_DIR with a deref of the variable.

2016-06-29 Thread Michael Gottesman via cfe-commits
Author: mgottesman Date: Wed Jun 29 15:22:46 2016 New Revision: 274158 URL: http://llvm.org/viewvc/llvm-project?rev=274158&view=rev Log: [ClangConfig] Replace paths with the same value as CLANG_INSTALL_PACKAGE_DIR with a deref of the variable. Modified: cfe/trunk/cmake/modules/CMakeLists.txt

Re: RFC: Default language standard mode policy

2016-06-29 Thread Sean Silva via cfe-commits
On Wed, Jun 29, 2016 at 12:51 PM, Richard Smith wrote: > On Wed, Jun 29, 2016 at 12:30 PM, Sean Silva > wrote: > >> >> >> On Wed, Jun 29, 2016 at 12:09 PM, Richard Smith via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> Hi all! >>> >>> I'd like to establish a policy for Clang's defa

Re: RFC: Default language standard mode policy

2016-06-29 Thread Sean Silva via cfe-commits
On Wed, Jun 29, 2016 at 1:34 PM, Sean Silva wrote: > > > On Wed, Jun 29, 2016 at 12:51 PM, Richard Smith > wrote: > >> On Wed, Jun 29, 2016 at 12:30 PM, Sean Silva >> wrote: >> >>> >>> >>> On Wed, Jun 29, 2016 at 12:09 PM, Richard Smith via cfe-commits < >>> cfe-commits@lists.llvm.org> wrote: >

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

2016-06-29 Thread Richard Smith via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, thank you so much for your patience and hard work on this change! http://reviews.llvm.org/D18035 ___ cfe-commits mailing list cfe-commits@l

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

2016-06-29 Thread Jake VanAdrighem via cfe-commits
jakev updated this revision to Diff 62282. jakev marked 5 inline comments as done. jakev added a comment. Address comments. Repository: rL LLVM http://reviews.llvm.org/D21823 Files: include/clang/Driver/Options.td lib/Driver/ToolChain.cpp lib/Driver/Tools.cpp test/Driver/clang_f_opts

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

2016-06-29 Thread Rong Xu via cfe-commits
xur added a comment. Thanks for doing this. I like the patch in general. Hers are my minor feedbacks: (1) It seems the original options of -fprofile-instr-generate and -fprofile-instr-use will be kept. Is so, what is the guideline to use these two sets of options. Also, we need some documentat

Re: [PATCH] D21705: Include debug info for nested structs and classes

2016-06-29 Thread Adrian McCarthy via cfe-commits
amccarth marked 2 inline comments as done. amccarth added a comment. http://reviews.llvm.org/D21705 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21705: Include debug info for nested structs and classes

2016-06-29 Thread Adrian McCarthy via cfe-commits
amccarth updated this revision to Diff 62283. amccarth added a comment. Applied suggestion from the comments, which eliminates the need to alter the ObjectiveC test. http://reviews.llvm.org/D21705 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h test/CodeGenCXX/debug-info-dup

r274165 - Switch to an RAII object to revert tentative parsing automatically.

2016-06-29 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Jun 29 16:06:51 2016 New Revision: 274165 URL: http://llvm.org/viewvc/llvm-project?rev=274165&view=rev Log: Switch to an RAII object to revert tentative parsing automatically. Modified: cfe/trunk/include/clang/Parse/Parser.h cfe/trunk/lib/Parse/ParseTentative.cpp

Re: [cfe-dev] RFC: Default language standard mode policy

2016-06-29 Thread Hal Finkel via cfe-commits
- Original Message - > From: "Richard Smith" > To: "Hal Finkel" > Cc: "Clang Dev" , "cfe-commits" > > Sent: Wednesday, June 29, 2016 3:01:46 PM > Subject: Re: [cfe-dev] RFC: Default language standard mode policy > On Wed, Jun 29, 2016 at 12:55 PM, Hal Finkel via cfe-dev < > cfe-...@lis

r274168 - [ClangConfig] Copy ClangConfig.cmake to ${CMAKE_BINARY_DIR}/${CLANG_INSTALL_PACKAGE_DIR} instead of to ${CLANG_BINARY_DIR}/${CLANG_INSTALL_PACKAGE_DIR}.

2016-06-29 Thread Michael Gottesman via cfe-commits
Author: mgottesman Date: Wed Jun 29 16:12:38 2016 New Revision: 274168 URL: http://llvm.org/viewvc/llvm-project?rev=274168&view=rev Log: [ClangConfig] Copy ClangConfig.cmake to ${CMAKE_BINARY_DIR}/${CLANG_INSTALL_PACKAGE_DIR} instead of to ${CLANG_BINARY_DIR}/${CLANG_INSTALL_PACKAGE_DIR}. This

r274167 - Convert another case over to RevertingTentativeParsingAction.

2016-06-29 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Jun 29 16:12:37 2016 New Revision: 274167 URL: http://llvm.org/viewvc/llvm-project?rev=274167&view=rev Log: Convert another case over to RevertingTentativeParsingAction. Modified: cfe/trunk/lib/Parse/ParseTentative.cpp Modified: cfe/trunk/lib/Parse/ParseTentative.cpp

r274169 - P0305R1: Parsing support for init-statements in 'if' and 'switch' statements.

2016-06-29 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Jun 29 16:17:59 2016 New Revision: 274169 URL: http://llvm.org/viewvc/llvm-project?rev=274169&view=rev Log: P0305R1: Parsing support for init-statements in 'if' and 'switch' statements. No semantic analysis yet. This is a pain to disambiguate correctly, because the parsin

Re: [PATCH] D21834: Implementing 'If statement with Initializer'

2016-06-29 Thread Richard Smith via cfe-commits
rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. The proposal has changed since the pre-meeting mailing, and now covers `switch` as well as `if`. You also need to handle the //expression-statement// form of //init-statement//. As

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

2016-06-29 Thread Joerg Sonnenberger via cfe-commits
joerg added a subscriber: joerg. joerg added a comment. On the topic of __cxa_thread_atexit, was it ever specified how it interacts with things like thread cancellation? http://reviews.llvm.org/D21803 ___ cfe-commits mailing list cfe-commits@lists.

Re: [PATCH] D21830: Remove -mrelax-all from Clang -O0

2016-06-29 Thread Joerg Sonnenberger via cfe-commits
On Wed, Jun 29, 2016 at 11:00:26AM -0400, Rafael Espíndola via cfe-commits wrote: > We need to benchmark this to see if it still makes a difference. > > My canonical test is the .s of a lto of clang. That won't exercise it? Assembler sources are exempt from this. Joerg _

Re: [cfe-dev] RFC: Default language standard mode policy

2016-06-29 Thread Joerg Sonnenberger via cfe-commits
On Wed, Jun 29, 2016 at 12:09:37PM -0700, Richard Smith via cfe-dev wrote: > Hi all! > > I'd like to establish a policy for Clang's default language standard (if > none is specified with -std), as follows: > > Clang defaults to the most recent published standard for the selected > language that

r274180 - [ClangConfig] Store all of the targets exported in the variable CLANG_EXPORTED_TARGETS.

2016-06-29 Thread Michael Gottesman via cfe-commits
Author: mgottesman Date: Wed Jun 29 16:59:23 2016 New Revision: 274180 URL: http://llvm.org/viewvc/llvm-project?rev=274180&view=rev Log: [ClangConfig] Store all of the targets exported in the variable CLANG_EXPORTED_TARGETS. Modified: cfe/trunk/cmake/modules/CMakeLists.txt cfe/trunk/cmak

r274177 - [ClangConfig] Follow LLVM's example and only install Clang{Config, Target}.cmake when LLVM_INSTALL_TOOLCHAIN_ONLY is disabled.

2016-06-29 Thread Michael Gottesman via cfe-commits
Author: mgottesman Date: Wed Jun 29 16:59:15 2016 New Revision: 274177 URL: http://llvm.org/viewvc/llvm-project?rev=274177&view=rev Log: [ClangConfig] Follow LLVM's example and only install Clang{Config,Target}.cmake when LLVM_INSTALL_TOOLCHAIN_ONLY is disabled. Modified: cfe/trunk/cmake/mod

r274178 - [ClangConfig] Instead of hard coding the ClangTargets location to /ClangTargets.cmake, follow LLVM's example and use a pre-computed cmake variable @CLANG_CONFIG_EXPORTS_FILE@.

2016-06-29 Thread Michael Gottesman via cfe-commits
Author: mgottesman Date: Wed Jun 29 16:59:19 2016 New Revision: 274178 URL: http://llvm.org/viewvc/llvm-project?rev=274178&view=rev Log: [ClangConfig] Instead of hard coding the ClangTargets location to /ClangTargets.cmake, follow LLVM's example and use a pre-computed cmake variable @CLANG_CONFI

r274179 - [ClangConfig] Unset some variables after we are done using them to configure ClangConfig.cmake.in files.

2016-06-29 Thread Michael Gottesman via cfe-commits
Author: mgottesman Date: Wed Jun 29 16:59:20 2016 New Revision: 274179 URL: http://llvm.org/viewvc/llvm-project?rev=274179&view=rev Log: [ClangConfig] Unset some variables after we are done using them to configure ClangConfig.cmake.in files. This ensures that the values do not bleed over in betw

r274176 - [cmake] Instead of just copying ClangConfig.cmake, configure it using ClangConfig.cmake.in.

2016-06-29 Thread Michael Gottesman via cfe-commits
Author: mgottesman Date: Wed Jun 29 16:59:14 2016 New Revision: 274176 URL: http://llvm.org/viewvc/llvm-project?rev=274176&view=rev Log: [cmake] Instead of just copying ClangConfig.cmake, configure it using ClangConfig.cmake.in. This will allow for cmake to expand variables in ClangConfig.cmake

Re: [cfe-dev] RFC: Default language standard mode policy

2016-06-29 Thread Hal Finkel via cfe-commits
- Original Message - > From: "Hal Finkel via cfe-dev" > To: "Richard Smith" > Cc: "Clang Dev" , "cfe-commits" > > Sent: Wednesday, June 29, 2016 4:17:18 PM > Subject: Re: [cfe-dev] RFC: Default language standard mode policy > - Original Message - > > From: "Richard Smith" >

Re: [cfe-dev] RFC: Default language standard mode policy

2016-06-29 Thread Richard Smith via cfe-commits
On Wed, Jun 29, 2016 at 2:48 PM, Joerg Sonnenberger via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Wed, Jun 29, 2016 at 12:09:37PM -0700, Richard Smith via cfe-dev wrote: > > Hi all! > > > > I'd like to establish a policy for Clang's default language standard (if > > none is specified w

  1   2   >