xur added a comment.
Thanks for doing this. I like the patch in general. Hers are my minor
feedbacks:
(1) It seems the original options of -fprofile-instr-generate and
-fprofile-instr-use will be kept. Is so, what is the guideline to use these two
sets of options. Also, we need some documentations for the new user-visible
options.
(2) One difference b/w -fprofile-instr-generate/-fprofile-instr-use and the new
options is -fpgo-train={source-cfg | optimizer-cfg} can coexist with
-fpgo-apply=<file>. I don't think they work as intended in current
implementation. I would suggest to not allow it.
(3) I would request a driver option to specify the profile name. While
LLVM_PROFILE_FILE environment variable can do that, a command line option is
gonna be useful (at least in our setup).
-Rong
Repository:
rL LLVM
http://reviews.llvm.org/D21823
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
