djasper added inline comments.
Comment at: include/clang/Tooling/Refactoring.h:91
@@ +90,3 @@
+ Rewriter &Rewrite,
+ const format::FormatStyle &Style);
+
Do you have a use case where we'd want to
jonpa retitled this revision from "SystemZ: Check that argument -fzvector is
only given for -z13" to "SystemZ: Check required features when handling
builtins".
jonpa updated the summary for this revision.
jonpa updated this revision to Diff 51910.
jonpa added a comment.
This patch has been rewor
Anastasia added a comment.
LG, apart from small comments mentioned here.
Comment at: lib/AST/ASTContext.cpp:7613
@@ +7612,3 @@
+if (getLangOpts().OpenCL) {
+ if (LHS.getUnqualifiedType() != RHS.getUnqualifiedType() ||
+ LQuals.getCVRQualifiers() != RQuals.getCV
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Aside from the copy-pasta, looks good.
Comment at: clang-tidy/misc/AssignOperatorCheck.cpp:74
@@ +73,3 @@
+ } else {
+std::string Name = ;
+
---
Anastasia accepted this revision.
Anastasia added a comment.
LGTM!
http://reviews.llvm.org/D17955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric marked an inline comment as done.
Comment at: include/clang/Tooling/Refactoring.h:91
@@ +90,3 @@
+ Rewriter &Rewrite,
+ const format::FormatStyle &Style);
+
djasper wrote:
> Do you have a u
djasper added inline comments.
Comment at: include/clang/Tooling/Refactoring.h:91
@@ +90,3 @@
+ Rewriter &Rewrite,
+ const format::FormatStyle &Style);
+
ioeric wrote:
> djasper wrote:
> > Do you
aaron.ballman added inline comments.
Comment at: test/clang-tidy/modernize-use-override-ms.cpp:1
@@ +1,2 @@
+// RUN: %check_clang_tidy %s modernize-use-override %t
+
I *think* this run line may require -fms-extensions in order to compile under
non-MSVC-built vers
etienneb updated this revision to Diff 51927.
etienneb added a comment.
fix invalid comment.
http://reviews.llvm.org/D18475
Files:
clang-tidy/readability/RedundantStringCStrCheck.cpp
test/clang-tidy/readability-redundant-string-cstr.cpp
Index: test/clang-tidy/readability-redundant-string-c
etienneb marked an inline comment as done.
etienneb added a comment.
thanks, aaron.ballman@.
Comment at: clang-tidy/readability/RedundantStringCStrCheck.cpp:129
@@ +128,3 @@
+ // Detect: 'dst += str.c_str()' -> 'dst += str'
+ // Detect: 's == str.c_str()' -> 's == str'
+
fowles added a comment.
ping?
http://reviews.llvm.org/D18408
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: kzhuravl
Date: Tue Mar 29 10:54:09 2016
New Revision: 264737
URL: http://llvm.org/viewvc/llvm-project?rev=264737&view=rev
Log:
[AMDGPU] Switch linker to amdphdrs + update test
Differential Revision: http://reviews.llvm.org/D18253
Modified:
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk
This revision was automatically updated to reflect the committed changes.
Closed by commit rL264737: [AMDGPU] Switch linker to amdphdrs + update test
(authored by kzhuravl).
Changed prior to commit:
http://reviews.llvm.org/D18253?vs=50975&id=51930#toc
Repository:
rL LLVM
http://reviews.llvm
edward-jones updated this revision to Diff 51932.
edward-jones added a comment.
This rolls AAP forward to top-of-tree.
http://reviews.llvm.org/D12192
Files:
lib/Basic/Targets.cpp
lib/Driver/Driver.cpp
lib/Driver/ToolChains.cpp
lib/Driver/ToolChains.h
lib/Driver/Tools.cpp
lib/Driver/
ioeric updated this revision to Diff 51933.
ioeric added a comment.
- Change the Style parameter of formatAndApplyReplacements from FormatStyle to
be a Style name string.
http://reviews.llvm.org/D17852
Files:
include/clang/Basic/SourceManager.h
include/clang/Format/Format.h
include/clang
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
Comment at: include/clang/Tooling/Refactoring.h:93
@@ +92,3 @@
+///
+/// See also "clang/Tooling/Core/Replacements.h".
+bool formatAndApplyAllReplacements(const
uweigand added a comment.
> This patch has been reworked, and aims to specify which features systemz
> builtins require. The way of doing this has been taken from the X86 Target
> (with a '#define TARGET_BUILTIN')
>
> If a builtin is used by the programmer for a target that does not include a
Author: jlebar
Date: Tue Mar 29 11:24:23 2016
New Revision: 264742
URL: http://llvm.org/viewvc/llvm-project?rev=264742&view=rev
Log:
[CUDA] Add missing #undef __DEVICE__ to CUDA shim header.
Modified:
cfe/trunk/lib/Headers/__clang_cuda_cmath.h
Modified: cfe/trunk/lib/Headers/__clang_cuda_cma
Author: jlebar
Date: Tue Mar 29 11:24:22 2016
New Revision: 264741
URL: http://llvm.org/viewvc/llvm-project?rev=264741&view=rev
Log:
[CUDA] Fix order of overloading preferences in comment.
Modified:
cfe/trunk/lib/Sema/SemaCUDA.cpp
Modified: cfe/trunk/lib/Sema/SemaCUDA.cpp
URL:
http://llvm.o
Author: jlebar
Date: Tue Mar 29 11:24:16 2016
New Revision: 264739
URL: http://llvm.org/viewvc/llvm-project?rev=264739&view=rev
Log:
[CUDA] Remove three obsolete CUDA cc1 flags.
Summary:
* -fcuda-target-overloads
Previously unconditionally set to true by the driver. Necessary for
correct fu
Author: jlebar
Date: Tue Mar 29 11:24:20 2016
New Revision: 264740
URL: http://llvm.org/viewvc/llvm-project?rev=264740&view=rev
Log:
[CUDA] Make CUDA description strings in langopts into noun phrases. NFC
rsmith quoth in D18380:
> This should be a noun phrase -- this string appears in contexts
This revision was automatically updated to reflect the committed changes.
Closed by commit rL264739: [CUDA] Remove three obsolete CUDA cc1 flags.
(authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D18416?vs=51478&id=51935#toc
Repository:
rL LLVM
http://reviews.llvm.org/D
ioeric updated this revision to Diff 51936.
ioeric added a comment.
- Minor changes.
http://reviews.llvm.org/D17852
Files:
include/clang/Basic/SourceManager.h
include/clang/Format/Format.h
include/clang/Tooling/Core/Replacement.h
include/clang/Tooling/Refactoring.h
lib/Format/Format.c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL264745: Added formatAndApplyAllReplacements that works on
multiple files in libTooling. (authored by ioeric).
Changed prior to commit:
http://reviews.llvm.org/D17852?vs=51936&id=51939#toc
Repository:
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good with one nit. Thank you for the new check!
Do you need me to submit the patch for you?
Comment at: clang-tidy/readability/AvoidConstParamsInDecls.cpp:24
@@ +23,3 @
Author: ioeric
Date: Tue Mar 29 11:31:53 2016
New Revision: 264745
URL: http://llvm.org/viewvc/llvm-project?rev=264745&view=rev
Log:
Added formatAndApplyAllReplacements that works on multiple files in libTooling.
Summary:
formatAndApplyAllReplacements takes a set of Replacements, applies them on
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good to me. Adding Samuel, since he has done a lot of similar stuff by
now and might have good ideas on improving this and making this more general.
http://reviews.llvm.org/D18475
__
Anastasia added a comment.
Regarding half types since there is inconsistency in both headers (commented in
CL1.2), should we just enable the extension cl_khr_fp16 in the header and then
have the overloads with half there with all the other types? They shouldn't be
visible to custom code unless
sbenza added a comment.
In http://reviews.llvm.org/D18475#385789, @alexfh wrote:
> Looks good to me. Adding Samuel, since he has done a lot of similar stuff by
> now and might have good ideas on improving this and making this more general.
There are two things I've done before that might apply
Author: bruno
Date: Tue Mar 29 12:35:02 2016
New Revision: 264752
URL: http://llvm.org/viewvc/llvm-project?rev=264752&view=rev
Log:
[Sema] Handle UTF-8 invalid format string specifiers
Improve invalid format string specifier handling by printing out
invalid specifiers characters with \x, \u and \
bruno closed this revision.
bruno added a comment.
Thanks Richard. Applied your last comments and committed in r264752
http://reviews.llvm.org/D18296
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
bcraig added a comment.
ping
http://reviews.llvm.org/D16544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
ping
http://reviews.llvm.org/D16545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
ping
http://reviews.llvm.org/D17410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
ping @danalbert, @mclow.lists
http://reviews.llvm.org/D17416
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
fowles updated this revision to Diff 51954.
fowles marked 2 inline comments as done.
fowles added a comment.
- review comments
- rename variables and remove MSVC compat issues
http://reviews.llvm.org/D18408
Files:
clang-tidy/readability/AvoidConstParamsInDecls.cpp
clang-tidy/readability/Avo
Author: cbieneman
Date: Tue Mar 29 12:51:08 2016
New Revision: 264757
URL: http://llvm.org/viewvc/llvm-project?rev=264757&view=rev
Log:
[Order Files] Fix order file usage
The CMake EXISTS operator needs to have the variable expanded. Not expanding
this was causing the if statement to always be f
Author: sbenza
Date: Tue Mar 29 13:02:26 2016
New Revision: 264759
URL: http://llvm.org/viewvc/llvm-project?rev=264759&view=rev
Log:
[clang-tidy] Add check to detect dangling references in value handlers.
Summary:
Add check misc-dangling-handle to detect dangling references in value
handlers like
Hi Eric,
I'm getting a build error:
In file included from
/usr/local/google/home/tejohnson/llvm/llvm_16/tools/clang/lib/Tooling/Refactoring.cpp:21:
/usr/local/google/home/tejohnson/llvm/llvm_16/tools/clang/include/clang/Tooling/Refactoring.h:32:1:
error: class 'FormatStyle' was previously declare
This revision was automatically updated to reflect the committed changes.
Closed by commit rL264759: [clang-tidy] Add check to detect dangling references
in value handlers. (authored by sbenza).
Changed prior to commit:
http://reviews.llvm.org/D17811?vs=51684&id=51956#toc
Repository:
rL LLVM
spyffe requested changes to this revision.
spyffe added a comment.
This revision now requires changes to proceed.
Overall this is a great improvement and I look forward to taking advantage of
this patch in LLDB!
I had one specific nit about `NullPtrTy`, and one more general comment about
your i
Author: ioeric
Date: Tue Mar 29 13:17:11 2016
New Revision: 264760
URL: http://llvm.org/viewvc/llvm-project?rev=264760&view=rev
Log:
Removed class FormatStyle, which is a struct, forward declaration from
Refactoring.h to avoid compilation error.
Modified:
cfe/trunk/include/clang/Tooling/Refa
Hi Teresa,
Thanks a lot! I have patched the error.
Thanks,
Eric
On Tue, Mar 29, 2016 at 8:08 PM Teresa Johnson wrote:
> Hi Eric,
>
> I'm getting a build error:
>
> In file included from
> /usr/local/google/home/tejohnson/llvm/llvm_16/tools/clang/lib/Tooling/Refactoring.cpp:21:
> /usr/local/goo
Author: bruno
Date: Tue Mar 29 13:38:44 2016
New Revision: 264765
URL: http://llvm.org/viewvc/llvm-project?rev=264765&view=rev
Log:
[Sema] Attempt to fix tests for utf-8 invalid format string specifiers
Followup from r264752.
Attempt to appease buildbots:
http://lab.llvm.org:8011/builders/clang
aprantl created this revision.
aprantl added reviewers: dblaikie, dexonsmith.
aprantl added a subscriber: cfe-commits.
aprantl set the repository for this revision to rL LLVM.
As noted in the review thread for http://reviews.llvm.org/D18477 on
llvm-commits, DWARF consumers such as dtrace's ctfcon
manmanren created this revision.
manmanren added reviewers: rjmccall, Anastasia.
manmanren added a subscriber: cfe-commits.
A simple example will crash at IRGen:
void (^simpleBlock)() = ^ _Nonnull {
return;
};
The Return type for the block will be AttributedType of a DependentTy and it
will no
etienneb marked an inline comment as done.
etienneb added a comment.
I'll to try to make a better way to describe redundant cases (as proposed by
sbenza@) with an array.
I like the array based approach, it's lean and clean.
I'll try to make a prototype of the generic overloaded functions matcher
tra added a comment.
LGTM.
http://reviews.llvm.org/D18380
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Tue, Mar 29, 2016 at 06:47:24PM +, Adrian Prantl via cfe-commits wrote:
> This code in this patch listens to the driver option -gfull, and lowers it to
> the new cc1 option -debug-retain-types (1).
> When -debug-retain-types is present, CGDebugInfo will retain every(2) type it
> creates.
> On Mar 29, 2016, at 12:00 PM, Joerg Sonnenberger
> wrote:
>
> On Tue, Mar 29, 2016 at 06:47:24PM +, Adrian Prantl via cfe-commits wrote:
>> This code in this patch listens to the driver option -gfull, and lowers it
>> to the new cc1 option -debug-retain-types (1).
>> When -debug-retain-t
alexfh added inline comments.
Comment at: clang-tidy/misc/SuspiciousMissingCommaCheck.cpp:42
@@ +41,3 @@
+ const auto *ConcatenatedLiteral = Result.Nodes.getNodeAs("str");
+ if (InitializerList && ConcatenatedLiteral) {
+// Skip small arrays as they often generate false-posi
Author: nico
Date: Tue Mar 29 14:41:02 2016
New Revision: 264774
URL: http://llvm.org/viewvc/llvm-project?rev=264774&view=rev
Log:
clang-cl: Silently ignore /d2FastFail flag.
It's some debugging flag for cl.exe related to how it writes crash dumps.
Modified:
cfe/trunk/include/clang/Driver/CL
yaxunl updated this revision to Diff 51967.
yaxunl marked 2 inline comments as done.
yaxunl added a comment.
Revised as Aaron suggested.
http://reviews.llvm.org/D17861
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/
yaxunl added a comment.
Ping. Tom, are you OK with this fix?
http://reviews.llvm.org/D17552
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
etienneb updated this revision to Diff 51969.
etienneb marked 5 inline comments as done.
etienneb added a comment.
address alexfh@ comments.
http://reviews.llvm.org/D18457
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/SuspiciousMissingCommaCheck.
etienneb added inline comments.
Comment at: clang-tidy/misc/SuspiciousMissingCommaCheck.cpp:42
@@ +41,3 @@
+ const auto *ConcatenatedLiteral = Result.Nodes.getNodeAs("str");
+ if (InitializerList && ConcatenatedLiteral) {
+// Skip small arrays as they often generate false-po
rjmccall added inline comments.
Comment at: lib/Sema/SemaType.cpp:1569
@@ +1568,3 @@
+// Mark them as invalid.
+attr.setInvalid();
+ }
It's not generally a good idea to set things as invalid if you're just emitting
a warning. It might be dif
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
http://reviews.llvm.org/D17861
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
Author: betulb
Date: Tue Mar 29 15:44:09 2016
New Revision: 264783
URL: http://llvm.org/viewvc/llvm-project?rev=264783&view=rev
Log:
[PGO] Move the instrumentation point closer to the value site.
For terminator instructions, the value profiling instrumentation
happens in a basic block other than
Author: bruno
Date: Tue Mar 29 15:47:09 2016
New Revision: 264784
URL: http://llvm.org/viewvc/llvm-project?rev=264784&view=rev
Log:
[Sema] Attempt [2] to fix tests for utf-8 invalid format string specifiers
Some buildbots still complain. Followup from r264752 and 264765.
Modified:
cfe/trunk/
hintonda created this revision.
hintonda added a reviewer: alexfh.
hintonda added a subscriber: cfe-commits.
This checker allows users to replace deprecated throw()
specifications with noexcept.
It also allows users to replace an arbitrary list of macros with
either noexcept or a user defined mac
manmanren added a comment.
Cheers,
Manman
Comment at: lib/Sema/SemaType.cpp:1569
@@ +1568,3 @@
+// Mark them as invalid.
+attr.setInvalid();
+ }
rjmccall wrote:
> It's not generally a good idea to set things as invalid if you're just
> emit
Author: ed
Date: Tue Mar 29 16:13:53 2016
New Revision: 264787
URL: http://llvm.org/viewvc/llvm-project?rev=264787&view=rev
Log:
Enable the SafeStack sanitizer on CloudABI by default.
Over the last month we've been testing SafeStack extensively. As far as
we know, it works perfectly fine. That wh
Author: bruno
Date: Tue Mar 29 16:30:58 2016
New Revision: 264788
URL: http://llvm.org/viewvc/llvm-project?rev=264788&view=rev
Log:
[Sema] Attempt [3] to fix tests for utf-8 invalid format string specifiers
Make the tests darwin only. The bots complaining already output UTF-8
invalid specifiers,
jlebar updated this revision to Diff 51988.
jlebar added a comment.
Fix typo in wrapper header. (How did this ever work??)
http://reviews.llvm.org/D18539
Files:
lib/Headers/CMakeLists.txt
lib/Headers/__clang_cuda_math_forward_declares.h
lib/Headers/__clang_cuda_runtime_wrapper.h
Index:
Hi,
FYI, cxx-indirect-call.cpp test fails on platforms with different
alignment. It may help to either use specific target or change your
patterns to accommodate other targets.
--Artem
TEST 'Clang :: Profile/cxx-indirect-call.cpp' FAILED
Script:
--
/usr/
Author: betulb
Date: Tue Mar 29 17:17:52 2016
New Revision: 264795
URL: http://llvm.org/viewvc/llvm-project?rev=264795&view=rev
Log:
[PGO] Test case fix for r264783
Modified:
cfe/trunk/test/Profile/cxx-indirect-call.cpp
Modified: cfe/trunk/test/Profile/cxx-indirect-call.cpp
URL:
http://ll
Hi Artem,
I’ve uploaded a patch to remove the alignment.
Thanks,
-Betul
From: Artem Belevich [mailto:t...@google.com]
Sent: Tuesday, March 29, 2016 3:15 PM
To: Betul Buyukkurt
Cc: cfe-commits
Subject: Re: r264783 - [PGO] Move the instrumentation point closer to the value
site.
Thanks for the quick fix. The test works on x86_64-unknown-linux-gnu now.
--Artem
On Tue, Mar 29, 2016 at 3:24 PM, Betul Buyukkurt
wrote:
> Hi Artem,
>
>
>
> I’ve uploaded a patch to remove the alignment.
>
>
>
> Thanks,
>
> -Betul
>
>
>
> *From:* Artem Belevich [mailto:t...@google.com]
> *Sent
rsmith added a comment.
Thanks, the change itself LGTM, but please add your testcase, perhaps to
test/PCH/__va_list_tag.c
Repository:
rL LLVM
http://reviews.llvm.org/D18557
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: alexfh, LegalizeAdulthood, aaron.ballman,
sbenza, etienne.bergeron.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Descriptions of checks were extracted from docu
Yunzhong Gao writes:
> ygao created this revision.
> ygao added subscribers: craig.topper, bogner, cfe-commits.
>
> Hi,
> The addcarry and subborrow variants of the builtins do not require the
> adx target attribute. Only the addcarryx variants require them.
> This patch attempts to remove the tar
Author: ygao
Date: Tue Mar 29 17:59:20 2016
New Revision: 264801
URL: http://llvm.org/viewvc/llvm-project?rev=264801&view=rev
Log:
Fixing PR26558: remove the adx target attribute requirement from adc builtins.
The addcarry and subborrow variants of the builtins do not require the adx
target attri
This revision was automatically updated to reflect the committed changes.
Closed by commit rL264801: Fixing PR26558: remove the adx target attribute
requirement from adc builtins. (authored by ygao).
Changed prior to commit:
http://reviews.llvm.org/D18533?vs=51857&id=52000#toc
Repository:
rL
ygao added a comment.
> Yep, only the ADCX instruction needs adx. This LGTM, but please just
> remove "-target-feature +adx" from the run line instead of adding a
> second run line.
Thanks, Justin.
Committed r264801 and updated the test as you suggested.
Repository:
rL LLVM
http://revie
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Please add information about this check in docs/ReleaseNotes.rst.
http://reviews.llvm.org/D18575
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D18210
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
zaks.anna added a comment.
Once tested, this can land.
http://reviews.llvm.org/D17253
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zaks.anna added a comment.
> > Also, we should not duplicate all of our tests. Instead, we should add a
> > single test per added API checking that it is modeling the operation we
> > think it
>
> > should model.
>
>
> So should I dump the _dbg versions from the tests?
No but do not
rsmith added inline comments.
Comment at: include/clang/AST/Expr.h:541-546
@@ -540,1 +540,8 @@
+/// \brief Whether the evaluation was unable to reduce a construct to a
+/// value.
+///
+/// For example, in foo(bar, baz, qux), if evaluating bar fails, we may
+
Author: bruno
Date: Tue Mar 29 18:47:40 2016
New Revision: 264808
URL: http://llvm.org/viewvc/llvm-project?rev=264808&view=rev
Log:
[CrashReproducer] Cleanup and move functionality around in
ModuleDependencyCollector. NFC
- Make ModuleDependencyCollector use the DependencyCollector interface
- M
bruno created this revision.
bruno added a reviewer: benlangmuir.
bruno added a subscriber: cfe-commits.
The current ModuleDependencyCollector has a AST listener to collect
header files present in loaded modules, but this isn't enough to collect
all headers needed in the crash reproducer. On
David Blaikie writes:
> On Tue, Mar 22, 2016 at 10:50 AM, Justin Bogner via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: bogner
>> Date: Tue Mar 22 12:50:05 2016
>> New Revision: 264071
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=264071&view=rev
>> Log:
>> StaticAnalyzer:
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
One nit. LGTM otherwise.
Comment at: lib/Headers/__clang_cuda_math_forward_declares.h:1
@@ +1,2 @@
+/*=== __clang_cuda_cmath.h - Device-side CUDA cmath support ===
+
Author: bruno
Date: Tue Mar 29 19:25:57 2016
New Revision: 264813
URL: http://llvm.org/viewvc/llvm-project?rev=264813&view=rev
Log:
[Driver] Quote clang full version in dwarf producer when invoking cc1as
Convenience to allow easy copy-n-paste from clang -v output when
reproducing cc1as comandline
ABataev added a comment.
Thinking more about this patch I think it is a right solution to override void
`llvm::Value *emitParallelOrTeamsOutlinedFunction()` and `void emitTeamsCall()`
for `CGOpenMPRuntimeNVPTX` class:
llvm::Value *CGOpenMPRuntimeNVPTX::emitParallelOrTeamsOutlinedFunction() {
ABataev added a comment.
Update patch to the latest version. It is not allowed to override CodeGen
sequemces in runtime. They must be universal and all must be defined in
CGStmtOpenMP.cpp only
Repository:
rL LLVM
http://reviews.llvm.org/D18470
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4257
@@ +4256,3 @@
+hasEnclosingOpenMPDirective(const Stmt *Body) {
+ const SK *S = nullptr;
+ // keep iterating until we find an LF or not an SK or a nullptr
You don't need `SK`, because
ABataev added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:816-822
@@ -801,6 +815,9 @@
+
+ // A DSA refers to this captured region if the parent contexts match.
+ auto *ParentContext = RSI->TheCapturedDecl->getParent();
for (auto I = Stack.rbegin(), EE = Stack.rend();
Author: pxl
Date: Tue Mar 29 23:46:32 2016
New Revision: 264825
URL: http://llvm.org/viewvc/llvm-project?rev=264825&view=rev
Log:
[OpenCL] Fix pipe builtin bugs
Summary:
1. Diag should be output if types are not the same.
2. Should compare using canonical type.
3. Refine the diag to be more clear
This revision was automatically updated to reflect the committed changes.
Closed by commit rL264825: [OpenCL] Fix pipe builtin bugs (authored by pxl).
Changed prior to commit:
http://reviews.llvm.org/D17955?vs=51629&id=52021#toc
Repository:
rL LLVM
http://reviews.llvm.org/D17955
Files:
cf
On Tue, Mar 29, 2016 at 12:03 PM, Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
> > On Mar 29, 2016, at 12:00 PM, Joerg Sonnenberger <
> jo...@britannica.bec.de> wrote:
> >
> > On Tue, Mar 29, 2016 at 06:47:24PM +, Adrian Prantl via cfe-commits
> wrote:
> >> This code in
Author: sberg
Date: Wed Mar 30 01:27:31 2016
New Revision: 264841
URL: http://llvm.org/viewvc/llvm-project?rev=264841&view=rev
Log:
For MS ABI, emit dllexport friend functions defined inline in class
...as that is apparently what MSVC does. This is an updated version of r263738,
which had to be
This revision was automatically updated to reflect the committed changes.
Closed by commit rL264841: For MS ABI, emit dllexport friend functions defined
inline in class (authored by sberg).
Changed prior to commit:
http://reviews.llvm.org/D18430?vs=51517&id=52024#toc
Repository:
rL LLVM
htt
baloghadamsoftware updated this revision to Diff 52023.
baloghadamsoftware added a comment.
Faulty line deleted.
http://reviews.llvm.org/D18265
Files:
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/misc/AssignOperatorCheck.cpp
clang-tidy/misc/AssignOperatorCheck.h
baloghadamsoftware marked an inline comment as done.
Comment at: clang-tidy/misc/AssignOperatorCheck.cpp:75
@@ +74,3 @@
+static const char *const Messages[][2] = {
+{"ReturnType", "operator=() should return '%0&'"},
+{"ArgumentType", "operator=() should take '%
a.sidorin added a comment.
Is this patch OK to submit?
http://reviews.llvm.org/D14286
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
LegalizeAdulthood added inline comments.
Comment at: clang-tidy/readability/DuplicateIncludeCheck.cpp:62
@@ +61,3 @@
+StringRef SearchPath, StringRef RelativePath, const Module *Imported) {
+ if (!SM_.isInMainFile(HashLoc)) {
+return;
LegalizeAdulthood wr
dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.
LGTM
Sorry for missing this when it was first posted. I've also been away for
roughly half of the two weeks since Petar added me to the review.
http://reviews.llvm.org/D17378
DmitryPolukhin created this revision.
DmitryPolukhin added reviewers: ABataev, aaron.ballman.
DmitryPolukhin added subscribers: cfe-commits, fraggamuffin.
Add parsing, sema analysis for 'declare target' construct for OpenMP 4.0
(4.5 support will be added in separate patch).
The declare target dir
1 - 100 of 112 matches
Mail list logo
