uweigand added a comment.

> This patch has been reworked, and aims to specify which features systemz 
> builtins require. The way of doing this has been taken from the X86 Target 
> (with a '#define TARGET_BUILTIN')

> 

> If a builtin is used by the programmer for a target that does not include a 
> required feature, the FE will abort early with an error message.

>  This includes vector and transactional memory builtins.


Ah, very nice.

> Three new tests: One for z13, which pass, and two for the generic target, 
> which are supposed to fail (therefore I put them in separate files). The 
> correct error messages are generated by clang, and recognized by Filecheck, 
> but the tests are still reported as failing. I am not sure what to do to get 
> around this, and would appreciate a hint on this. I tried expected-error{{}}, 
> but that did not work.


In order to use expected-error, you have to build with -verify.  See e.g. 
tools/clang/test/CodeGen/target-builtin-error.c


http://reviews.llvm.org/D17142



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to