See the v2 implementation of this patch.
I replaced:
---
@@ -328,7 +328,8 @@ static void intel_igd_setup(struct pci_device *dev, void
*arg)
pci_config_writel(bdf, 0x5C, cpu_to_le32((u32)addr));
dprintf(1, "Intel IGD BDSM enabled at 0x%08x, size %lldMB, dev "
- "00:02.0\n", (u32)addr, bdsm_size >> 20);
+ "%02x:%02x.%x\n", (u32)addr, bdsm_size >> 20,
+ 0, 2, 0);
}
}
---
So it will look like the format string a few lines above:
dprintf(1, "Intel IGD OpRegion enabled at 0x%08x, size %dKB, dev “
"%02x:%02x.%x\n", (u32)addr, opregion->size >> 10,
pci_bdf_to_bus(bdf), pci_bdf_to_dev(bdf), pci_bdf_to_fn(bdf));
This solves the version problem
Sam
> On 20 May 2019, at 5:10, Kevin O'Connor <[email protected]> wrote:
>
> On Sat, May 18, 2019 at 09:58:59PM +0300, Sam Eiderman wrote:
>> I wanted it to look more consistent with a dprintf just a few lines above:
>>
>> dprintf(1, "Intel IGD OpRegion enabled at 0x%08x, size %dKB, dev "
>> "%02x:%02x.%x\n", (u32)addr, opregion->size >> 10,
>> pci_bdf_to_bus(bdf), pci_bdf_to_dev(bdf), pci_bdf_to_fn(bdf));
>>
>> What do you think?
>
> I'd use the dprintf(1, "%pP", dev) form instead.
>
> -Kevin
_______________________________________________
SeaBIOS mailing list -- [email protected]
To unsubscribe send an email to [email protected]
