I wanted it to look more consistent with a dprintf just a few lines above:
dprintf(1, "Intel IGD OpRegion enabled at 0x%08x, size %dKB, dev "
"%02x:%02x.%x\n", (u32)addr, opregion->size >> 10,
pci_bdf_to_bus(bdf), pci_bdf_to_dev(bdf), pci_bdf_to_fn(bdf));
What do you think?
Sam
> On 18 May 2019, at 21:28, Carl-Daniel Hailfinger
> <[email protected]> wrote:
>
> What about this?
>
> diff --git a/src/fw/pciinit.c b/src/fw/pciinit.c
> index c0634bcb..4ab9b724 100644
> --- a/src/fw/pciinit.c
> +++ b/src/fw/pciinit.c
> @@ -328,7 +328,7 @@ static void intel_igd_setup(struct pci_device *dev,
> void *arg)
> pci_config_writel(bdf, 0x5C, cpu_to_le32((u32)addr));
>
> dprintf(1, "Intel IGD BDSM enabled at 0x%08x, size %lldMB, dev "
> - "00:02.0\n", (u32)addr, bdsm_size >> 20);
> + "%s\n", (u32)addr, bdsm_size >> 20, "00:02.0");
> }
> }
>
>
> Regards,
> Carl-Daniel
>
> Am 18.05.19 um 13:26 schrieb Shmuel Eiderman:
>> Or better yet, replacing the numbers with format string specifiers,
>> not changing the string at all.
>>
>> Sam
>>
>> On May 18, 2019 14:20, Shmuel Eiderman <[email protected]> wrote:
>>
>> True, "device" is a good option.
>> What about "size: , dev:" (with colon - grepping for "dev " will
>> still not work) or "dev " (two spaces - grepping will work but
>> debug string looks a bit weird).
>>
>> Sam
>>
>>
>
_______________________________________________
SeaBIOS mailing list -- [email protected]
To unsubscribe send an email to [email protected]
