no problem. Do what you need to get it in. On Tue, Nov 23, 2021 at 6:58 AM Marc Haber <mh+screen-de...@zugschlus.de> wrote:
> Hi David, > > I can confirm that this patch seems to work as advertised. Thank you. > > It didn't show up in the bug tracker though, are you ok with me > forwarding the patches there? > > Greetings > Marc > > On Sun, Nov 21, 2021 at 12:59:22PM -0700, david kerns wrote: > > From: david kerns <david.t.ke...@gmail.com> > > Subject: Re: [screen-devel] [bug #23952] Screen can't set stop/parity > bits > > on serial > > To: Screen development <screen-devel@gnu.org> > > Cc: Micah Cowan <mi...@addictivecode.org>, Marc Haber > > <mh+savannah-gnu-...@zugschlus.de>, Benedikt Wildenhain > > <savan...@benedikt-wildenhain.de>, scr...@uni-erlangen.de > > Date: Sun, 21 Nov 2021 12:59:22 -0700 > > X-Spam-Score: (-) -1.3 > > X-Spam-Report: torres.zugschlus.de Content analysis details: (-1.3 > > points, 5.0 required) pts rule name description ---- > > ---------------------- ------------------------------------------- -1.9 > > BAYES_00 BODY: Bayes spam probability is 0 to 1% > > [score: 0.0000] -0.0 RCVD_IN_DNSWL_NONE > > RBL: Sender listed at https://www.dnswl.org/, > > no trust > > [2607:f8b0:4864:20:0:0:0:333 listed in] > > [list.dnswl.org] 0.0 T_SPF_TEMPERROR > > SPF: test of record failed (temperror) 0.0 T_SPF_HELO_TEMPERROR > > SPF: test of HELO record failed (temperror) 0.0 FREEMAIL_FROM > > Sender email is commonly abused enduser mail > > provider (david.t.kerns[at]gmail.com) 0.0 > > HTML_MESSAGE BODY: HTML included in message 0.1 DKIM_SIGNED > > Message has a DKIM or DK signature, not necessarily > > valid 0.5 DKIM_INVALID DKIM or DK > > signature exists, but is not valid > > > > Here's a quick and dirty patch for 4.8.0 ... I didn't investigate if the > > BSD side allows those settings (it's BSD, screw'em) > > > > > > > > On Sun, Nov 21, 2021 at 7:54 AM Marc Haber <invalid.nore...@gnu.org> > wrote: > > > > > Follow-up Comment #1, bug #23952 (project screen): > > > > > > This has been lying around in the bug tracker for 13 years now. I'd > like to > > > elaborate a bit on this: > > > > > > The cereal program (https://tracker.debian.org/pkg/cereal) uses > screen as > > > a > > > terminal emulator to access serial devices such as routers, switches > etc. > > > cereal's unique usage of screens allow device output to be captured > > > unattendedly, so that you can see the device's last output when > attaching > > > to > > > the session. This is a huge help when debugging on devices that > usually run > > > unattended for months and then suddenly need attention. > > > > > > Unfortunately, screen's handling of serial ports is somewhat > incomplete: > > > You > > > can set the baud rate and the word length (cs7), but not the number of > stop > > > bits and/or the parity settings. > > > > > > Since the OS calls are readily available, adding this to a future > version > > > of > > > screen would proably be easy enough to do inside tty.sh. Sadly, my C > skills > > > lack to handle this code which is liberally sprinkled with portability > > > #ifdefs, so I cannot submit a patch. > > > > > > > > > _______________________________________________________ > > > > > > Reply to this item at: > > > > > > <https://savannah.gnu.org/bugs/?23952> > > > > > > _______________________________________________ > > > Message sent via Savannah > > > https://savannah.gnu.org/ > > > > > > > > > > > > > -- > > ----------------------------------------------------------------------------- > Marc Haber | "I don't trust Computers. They | Mailadresse im Header > Leimen, Germany | lose things." Winona Ryder | Fon: *49 6224 1600402 > Nordisch by Nature | How to make an American Quilt | Fax: *49 6224 1600421 >
