On Sat, Jul 15, 2017 at 07:58:54AM -0400, Ineiev wrote:
> > 5.
> > There are several very large commits titled "review localized strings",
...
> > It would be easier to understand if those were broken down per topic
> > (i.e. if "localization" - then only touching lines that actually
> > use localized text, and and having separate commits for breaking lines / 
> > re-indentation / etc).
> 
> I'll try to separate them.

Probably it would be unreasonably much work to rewrite these commits;
however, I'll try to make future commits more separated.

> ...
> > Would be nice to explain what was fixed, or (since it isn't in 'master' 
> > yet) - rebase+squash.
> 
> I wanted to to avoid forced pushes in that branch.
> 
> I'll push another one.

I've just pushed i18n-2017-07-13-bis: just merged the fixes and added
more detailed commit logs.

Attachment: signature.asc
Description: Digital signature

Reply via email to