On 14/03/2013 16:23, Paul Menzel wrote:
> Dear Stef,
>
>
> Am Freitag, den 08.03.2013, 21:55 +0100 schrieb Stef:
>
> [?]
>
>> I really think this test program should be added, it doesn't add
>> extra dependency and helps testing a lot. For instance while adding a
>> test case for the problem Olaf spotted (not setting usb context to
>> null), it allowed me to find I also forgot to reset device_number to 0
>> in sane_exit().
> I agree with your reasoning.
>
> I think I spotted some small things. Could you please resend the patch
> inlined, so I can answer inline with my email client? That would be
> awesome.
>
> You can do
>
> $ git format-patch -1
>
> as you already did and copy that to the commit message body and make
> sure to turn of automatic line wrapping in Thunderbird.
>
>
> Thanks,
>
> Paul
Hello,
it is a handy format that ease the review process. I'll consider it
for another occasion if there is a consensus on receiving sometimes
about 12 mails and on raising the mail size limit (one of the patches is
~40k if inlined).
For this time I'd appreciate that you comment on the patches with their
current form.
Thanks,
Stef
