Stef writes:
> On 06/03/2013 22:22, Stef wrote:
> [... details about the test program ...]
> I really think this test program should be added, it doesn't add
> extra dependency and helps testing a lot. For instance while adding a
> test case for the problem Olaf spotted (not setting usb context to
> null), it allowed me to find I also forgot to reset device_number to 0
> in sane_exit().
As I already/just mentioned in my review, I'm in favour of adding
tests. If they are run as part of `make check` that's even better.
# And shame on me for not spotting the missing device_number reset!
# I'd probably have written that as a count-down loop on device_number
# so the reset becomes part of the resource release logic. Anyways.
Hope this helps,
--
Olaf Meeuwissen, LPIC-2 FLOSS Engineer -- AVASYS CORPORATION
FSF Associate Member #1962 Help support software freedom
http://www.fsf.org/jf?referrer=1962
