2010/11/30 Gernot Hassenpflug <aikishugyo at gmail.com> > On Tue, Nov 30, 2010 at 5:53 AM, Nicolas Martin > <nicolas0martin at gmail.com> wrote: > > Le lundi 29 novembre 2010 ? 19:54 +0100, Tomas Pospisek a ?crit : > >> On Mon, 29 Nov 2010, Tom?? Posp??ek wrote: > >> > >> [...] > >> > >> The same patch seems also to have broken Canon Pixma MP160 [1] and Pixma > >> MP780 [2]. > > > > Could you try first to change, in the current git version of Sane, the > > following line in backend/pixma_mp150.c, at line 683: > > > > if (s->cfg->pid == MP460_PID || s->cfg->pid == MP510_PID) > > pixma_set_be32 (s->param->x - s->param->xs, data + 0x08); > > > > Take out the if condition, and leave only the second line: > > > > pixma_set_be32 (s->param->x - s->param->xs, data + 0x08); > > > Hi Nicolas, > That is quite strange. This is one of the patches which I believe I > submitted during testing of various scanners, including the MP760/780. > The MP460 and MP510 required a new addition (condition) which only > have applied to them (for now) and no other devices, so I do not > understand exactly how this affects unrelated devices. Unfortunately I > now no longer have any of these machines, but I will compare the code > I still have. > Regards, > Gernot Hassenpflug >
Originaly, the patch provided by Christian Scholtz for fine cropping adjustment, and uploaded in January 2010, was designed and tested on gen 3 devices, but I guess not on gen 2 devices, and was probably not working for any gen 2 devices. You probably noticed it when testing MP460 and MP510, that's why you fixed the above line (s->param->x - s->param->xs instead of s->param->x) but added a restriction for those 2 models. I'm just guessing here this fix is necessary for any gen 2 device as well. nicolas -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.alioth.debian.org/pipermail/sane-devel/attachments/20101130/b79419b8/attachment-0001.htm>
