On Monday, April 30, 2018 at 11:01:49 AM UTC-7, Erik Bray wrote: > > And that's exactly what I'm advocating. Would it be useful? Who > knows!? I doubt it but it would be nice to be proven wrong. > > The most complicated thing is to make a special-purpose github account to run this on (because no-one in their right mind is going to give some shady startup access to their actual github account, right? Then it runs quite nicely. It reports 88 warnings. They seem based on some rather superficial pattern matching.
Some are bogus and are just learned from bad changes in other repositories. Supposedly a change for Python3 support: - single_counts = *dict*( *zip*(reps, *[*0.]*nreps ) ) + single_counts = dict( *list*(*zip*(reps, *[*0.]*nreps )) ) I would hope that Py3's dict still accepts iterables? But one for threejs would be worth checking: *- _.renderer.setClearColor(*'white', *1)*; *+ _.renderer.setClearColor(*0x000000, *0)*; (I have no idea what the second parameter is, but apparently some projects made the change above). If someone feels like it, they could run this and track the alerts. You'll get pointers to code it thought was similar in other repositories, with the changes made there, so it might detect common problematic points. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
