On Thu, Nov 17, 2016 at 5:25 PM, Jean-Pierre Flori <jpfl...@gmail.com> wrote: > > > On Thursday, November 17, 2016 at 5:11:23 PM UTC+1, Erik Bray wrote: >> >> Hi, >> >> I'm in the process of patching a couple spkgs that use autotools build >> systems. I've done this in the past in Sage but it's never been quite >> clear to me what the correct process should be. In this particular >> case I am patching both confgure.ac and Makefile.am files. >> >> Should I add just patches for the input files, or should I also >> include patches for the output files (configure, Makefile(.in), etc.)? > > I'd say both... >> >> Should I merge them all together or keep them separate? >> > ...in separate patches, the one to "source" files not being applied.
Ok, that's what I thought. I think in the past I was asked to do the same. >> Further, for patching the generated files, what's a good way to go >> about that? If I don't have the exact versions of autoconf and >> automake as were used in the upstream sources then I can wind up with >> a lot of unrelated changes in the generated files. How are you >> normally dealing with that? >> > There is a autotools spkg. > If you autoreconf from a sage shell it should then use matching versions of > the autostuff. Hmm, okay. I am using my system's autoreconf. For the sage autotools is that just an optional package I need to install? -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.