Yes, but 'reduce' doesn't really make sense except on homogeneous 2 var polynomials. So I think under that logic it would better fit in multivariable polynomials (which we considered). That avoids the whole binary form class versus qudaratic forms class issue. Would that be preferable?
On Thursday, August 11, 2016 at 2:26:27 PM UTC-5, John Cremona wrote: > > On 11 August 2016 at 20:03, Ben Hutz <bn4...@gmail.com <javascript:>> > wrote: > > Yes we see that the quadratic form folder contains all the quadratic > > implementations. inside that there is some specific functionality for > binary > > quadratic forms (binary_qf.py). However, Lauren's function is for > binary > > forms of *any* degree. As such, it doesn't really belong under the > > 'quadratic_form' folder. However, there doesn't seem to be a more > > appropriate place for it. She could add it to the binary_qf.py file and > > rename that binary.py, but it is still under the quadratic form code. As > you > > say it seems overkill to restructure things for a single function, but > it > > doesn't really seem to fit anywhere. Suggestions? > > > > What do you think of putting a more general binary form class in > > binary_qf.py and renaming the file to binary.py or binary_forms.py but > > leaving the directory structure untouched? > > An alternative would be to have a .reduce() function on univariate > polynomials over ZZ or QQ. The implementation will use the real and > complex roots anyway, and if the input is really homogeneous in 2 > varaibles one will have to dehomogenise to get to the roots anyway. > This would also have the advantage of not having to worry about what > to call a global function whose purpose is to take a binary form and > reduce it. > > John > > > > > > Ben > > > > > > On Sunday, August 7, 2016 at 5:15:17 PM UTC-5, Justin C. Walker wrote: > >> > >> Hi, Rebecca, > >> > >> On Aug 7, 2016, at 14:02 , Rebecca Miller wrote: > >> > >> > I am implementing Cremona and Stoll's Binary Form Reduction > Algorithm. > >> > I'm just not sure where it should live. I had some houghts but would > like > >> > opinions. Currently there is just a Quadratic Forms folder. I could > create > >> > a folder containing just this algorithm, or I could rename the > quadratic > >> > form folder and put it in there because binary quadratic forms should > >> > inherit form this algorithm. Any other ideas? > >> > >> Binary forms have two incarnations, both, I think, in the > quadratic_forms > >> directory. One is part of the general implementation, but John Hanke > and > >> others, and one is specific to binary forms. Check there to see where > your > >> implementation would best fit. > >> > >> Renaming an existing directory is a fairly big step, given what's > there. > >> If you have implemented a full class for this, you may have gone too > far :-} > >> > >> But check what's there. Write here if you have questions, suggestions, > >> complaints, brick-bats, ... > >> > >> HTH > >> > >> Justin > >> > >> -- > >> Justin C. Walker, Curmudgeon at Large > >> Institute for the Absorption of Federal Funds > >> ----------- > >> If it weren't for carbon-14, I wouldn't date at all. > >> ----------- > >> > >> > > -- > > You received this message because you are subscribed to the Google > Groups > > "sage-devel" group. > > To unsubscribe from this group and stop receiving emails from it, send > an > > email to sage-devel+...@googlegroups.com <javascript:>. > > To post to this group, send email to sage-...@googlegroups.com > <javascript:>. > > Visit this group at https://groups.google.com/group/sage-devel. > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
