There is a binary quadratic forms and a general quadratic forms, but no general binary form that I can find. I don't think this algorithm fits in any of the existing files. Creating a class does seem like overkill, but there doesn't seem to be a place to put it.
Rebecca Lauren On Monday, August 8, 2016 at 3:12:15 AM UTC-5, John Cremona wrote: > > On 7 August 2016 at 23:13, Justin C. Walker <jus...@mac.com <javascript:>> > wrote: > > Hi, Rebecca, > > > > On Aug 7, 2016, at 14:02 , Rebecca Miller wrote: > > > >> I am implementing Cremona and Stoll's Binary Form Reduction Algorithm. > I'm just not sure where it should live. I had some houghts but would like > opinions. Currently > > Thanks for doing this. I think many people will find it useful. I > myself only implemented it in the easier case of degrees 3 and 4 (in > C++: it is in eclib). For our paper Stoll certainly computed some > examples, almost certainly using Magma, and he might be willing to > donate that code. I also think that Marco Streng might have an > implementation. > > John > > there is just a Quadratic Forms folder. I could create a folder > containing just this algorithm, or I could rename the quadratic form > folder and put it in there because binary quadratic forms should > inherit form this algorithm. Any other ideas? > > > > Binary forms have two incarnations, both, I think, in the > quadratic_forms directory. One is part of the general implementation, but > John Hanke and others, and one is specific to binary forms. Check there to > see where your implementation would best fit. > > > > Renaming an existing directory is a fairly big step, given what's there. > If you have implemented a full class for this, you may have gone too far > :-} > > > > But check what's there. Write here if you have questions, suggestions, > complaints, brick-bats, ... > > > > HTH > > > > Justin > > > > -- > > Justin C. Walker, Curmudgeon at Large > > Institute for the Absorption of Federal Funds > > ----------- > > If it weren't for carbon-14, I wouldn't date at all. > > ----------- > > > > > > -- > > You received this message because you are subscribed to the Google > Groups "sage-devel" group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to sage-devel+...@googlegroups.com <javascript:>. > > To post to this group, send email to sage-...@googlegroups.com > <javascript:>. > > Visit this group at https://groups.google.com/group/sage-devel. > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
