> Because there is no ticket-DAG and there is no immutable history of > tickets.
I don't see why there couldn't be. Once a ticket is closed, it is immutable. While a ticket is open, its position in the DAG is mutable: it will always depend on the tip of develop, as well as tickets that it explicitly depends on. > Ticket dependencies are informational but don't change what code > is being added. Which is precisely why they can be mutable. I'm suggesting modifying a tool that makes it more clear to reviewers what the logical diff of a given ticket it. Not the diff off the ticket plus its dependencies, which is usually not what a reviewer is interested in. This is a user-thing, not a backend-thing. Say someone is working on ticket A. A is huge so I suggest breaking off a part of it into its own ticket B. As a reviewer, I'll naturally be looking at the diff of both A and of B, even if I'm formally beginning my review at A. When I'm asking trac to show me the diff of B, it's unhelpful that it shows me the diff of A+B. Do you disagree that this is unhelpful? Or do you believe it's (close to) impossible to make Git show me the information I really want, in (almost) all instances? Or am I not understanding your objection to my suggestion at all? > If it >> wasn't for the stupid git-behaviour of throwing-away-single-commits-info >> when you do commit-squasing, I would suggest squashing all commits to >> single tickets upon merging. > > > It seems that you want to erase history yet have it, too. In a sense. I think Git should have a possibility of "meta-squashing" commits so that, in most commands it would treat a group of commits as one commit. But it is possible to "open it" and get the detailed commit history, if I needed it. I think this would be useful outside of Sage. And I don't see a technical reason that this shouldn't be possible in exactly the same set of cases that squashing is currently possible. > You basically want a pre-commit review workflow, whereas we currently do > post-commit review. Both are feasible but developers definitely need more > experience with git in the former. I'm not sure what you mean. But I don't want to change the review workflow at all. I've raised two points so far: 1) it would be nice if the diff button showed me only the diff of the current ticket. Currently I get ticket + deps which is user-unfriendly. 2) When I do git-blame, or other similar commands, I can easily get a commit message or commit hash, but I can't get a ticket number. Which is usually what I want (to look up e.g. why a change had been done). That's user-unfriendly. Best, Johan -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
