> What if they would be willing to systematically > review my revisions according to the usual conventions (e.g., > http://doc.sagemath.org/html/en/developer/reviewer_checklist.html#chapter-review)? > Does this seem like a reasonable way to proceed?
Yes, there is nothing wrong with that. Anybody can review a ticket. This being said, splitting your ticket into smaller ones is a way to simplify the reviewer's work, and the problem is not magically solved if the reviewer is a former student of yours. They just have less freedom to refuse. The way we usually do things here is the following: we open a ticket on the trac server, and then wait for somebody who is willing to review them. That can take time, and this is why we try to make our tickets as appealing as possible to a potential reviewer. On the 'practical' side: git makes it relatively easy to split a commit into smaller ones. Some commands that you may need: - git reset HEAD~1 'breaks' the latest commit; its changes become unstaged changes again - git add -p <filename> Lets you decide bit-by-bit which changes of 'filename' you want to stage - git rebase -i develop Lets you reorder commits, and merge commits together. Useful if you want to make change to an 'old commit'. Can be tricky at first, but very useful: https://www.atlassian.com/git/tutorials/rewriting-history/git-rebase We can also help you if you have problem, and you can of course find a LOT of information on internet, as git is a very famous software (and we all have problems with it from time to time :-P). If you chose to split this branch into several tickets, you will have definitely learned a lot of useful things about git. https://www.atlassian.com/git/tutorials/ Good luck, Nathann -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at http://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
