> > > The guideline is not a rule, but it has not been put there for no > reason either. I have had to do *very* long reviews of a diff that > wasn't half as long as yours. I certainly would not start another one > when, from the look of your diff file, the changes are so unrelated > that you could have split it in 5 different tickets easily. Though > Karl-Dieter is more optimistic, and may have more time for it. > > I don't know anything about sandpiles except the ones at our beach. But in this case I would not be surprised if there were people who cared enough about it - and about accurate code - that this could get reviewed.
David (P.), one thing you could do to help that is to make a comment on your ticket (or edit the description) to make it clear which line numbers etc. would be self-contained review units. Then someone could review a piece at a time, at least mentally. There is also "git add -p" which apparently allows you to decide which hunks (in the patch sense) you want to add to a commit, and you could break your branch up into smaller "bite-sized" chunks that way. See https://cbx33.github.io/gitt/afterhours5-1.html for a pretty informative post that continues to affirm my contention that git does way too many things with way too few commands :) But I am not a git expert and have never tried this, so I can't say how annoying that might be. Still, it could be a way to at least break this ticket into more easily reviewable commits without actually making separate branches. - kcrisman -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at http://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
