On 2014-01-02, Simon King <[email protected]> wrote: > But you try to convince us that with git there is no such notion as "ticket to > which a commit belongs". And since git is good (that's an axiom) we have to > accept that the reviewer of ticket 2 has to review commit A, and we also > have to accept that a positive review of ticket 2 should qualify commit A for > being merged, even though the reviewer of ticket 1 (who supposedly is more > expert for the topic of ticket 1 than the reviewer of ticket 2!!) says that > commit A can't be accepted.
Oops, in your example it was B (not A) that reviewer 2 gives an implicit review, even though reviewer 1 gives it a negative review. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/groups/opt_out.
