Oops. This email was send too early. I wanted to add that the doctests I read in your patch make it look a bit like the current AdditiveAbelianGroup and IntegerModRing from outside, aaaaaand that I am not familiar enough with the current code and your patch's code to notice the internal differences... Though definitely the current IntegerModRing could work better with CartesianProduct :-P
Nathann On 12 November 2013 12:25, Nathann Cohen <nathann.co...@gmail.com> wrote: > Hellooooooooooooooooooooooo !! > > > I've been to hell and back. The situation is as bad as it sounds. > > O_O_O_O_O_O_O;;;;;; > > > #9773 builds on William's finitely-generated free-module-over-PID code to > > implement additive and multiplicative finitely generated groups in a > unified > > and extendable way. Mostly just a pretty face on top of free modules > over > > ZZ. > > > > The code should be solid. Patch applies, with one obsolete hunk failing > > (just ignore it). Passes the tests that are there. It needs a big > effort > > to be fully documented and then we'd want to decide if it is a useful > > replacement for what currently exists. Mea culpa for not finishing the > job. > > > > KDC's group of multiplicative units mod n is a good demonstration of how > to > > extend the abstract classes. There is a cyclic group (maybe one fairly > > concrete and one more presentational). Take it for a spin and see if it > > solves your original complaint. Poke around in the (new) fg_abelian > > directory. > > HMmmmmm... Well, Volker more or less made me give up using > AdditiveAbelianGroup for Z/nZ and I now use IntegerModRing in this > case. Which (#15369 just got updated) is now available as > "groups.misc.AdditiveCyclic" for whoever is looking for it. > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at http://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/groups/opt_out.
