On 2/21/12 1:03 PM, Christopher Swenson wrote:
I agree with a lot of what was just said.
My only possible issue with the github workflow: I'm not sure how it
interacts with having multiple people who have control of the "master"
(central) repo. When a pull request comes in, can anyone who has push
access to the repo take control of that pull request?
Yes. A pull request is just a remote branch. Anyone with commit access
to the repository can merge the remote branch and push to the github
repository.
Also, in my vastly finite experience with github, I've had problems with
the fact that pull requests seem to be immutable: once a request has
been created, it doesn't seem to be easy to add more commits to it, or
change the commits. (This may just be my naïvety.)
Again, a pull request is just a remote branch. If I have submitted a
pull request, that just means that I've submitted a certain branch for
merging. If I push more commits to that branch, they automatically show
up in the pull request. In fact, I can rebase the branch and push -f
the branch and the new commits will overwrite whatever was there.
One thing I like about github is that it is so close to the underlying
git philosophy, so that once you understand git, it's easy to understand
github.
But other than, I think github does have a great model. Is github on the
table for a future platform to move to?
Yes. We've already moved the Sage notebook and the Sage Cell server to
github.
I think gerrit is definitely a heavy-handed approach to reviews that
seems to work better with larger products (like Android), since you do
sort of have to adapt to its style of reviews. And I don't know if it
is the right tool for Sage (not sure if anything is), but it is
certainly worth looking at.
Thanks again for your help with understanding gerrit better!
Jason
--
To post to this group, send an email to sage-devel@googlegroups.com
To unsubscribe from this group, send an email to
sage-devel+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org
