Reviewed changes should be very small so that they are easy to verify and review. Also, most changes are bugfixes or minor feature adds, so it should not create large, hard to merge commits.
If you have such a large change, you should probably be splitting into multiple reviews anyway. I know the authors of gerrit, and would be willing to ask them a few questions if people had specific concerns. --Christopher On Feb 16, 2012 8:31 AM, "Keshav Kini" <keshav.k...@gmail.com> wrote: > Jason Grout <jason-s...@creativetrax.com> writes:: > > Kini is working on an SEP for moving to git for revision control. > > What experience/feelings do people have for gerrit [1]? > > After looking into it a bit, I've found some things that I really don't > like, for example the following admonition from `a wiki page about > gerrit workflows`_:: > > > If the master repository has changed since you started, you should > > rebase your changes to the current state. And if you have made many > > small commits, you should squash them so that they do not show up in > > the public repository. Remember: each commit will become a change in > > Gerrit, and need to be approved separately. If you are making one > > "change" to the project, squash your many "checkpoint" commits into > > one commit for public consumption. > > This strikes me as very bad. Rebasing, OK, though personally I think > merging is usually a better strategy, especially since it preserves > history more nicely. Squashing commits is definitely a bad idea, though, > as it makes future rebasing harder when you have large single commits > instead of many small commits, which is in fact one of the problems with > our current patch-based system. > > .. _a wiki page about gerrit workflows: > http://wiki.openstack.org/GerritWorkflow#Long-lived_Topic_Branches > > -Keshav > > ---- > Join us in #sagemath on irc.freenode.net ! > > -- > To post to this group, send an email to sage-devel@googlegroups.com > To unsubscribe from this group, send an email to > sage-devel+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/sage-devel > URL: http://www.sagemath.org > -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
