On May 13, 7:18 pm, Thomas Feulner <thomas.feul...@uni-bayreuth.de> wrote: > Hi, > > On 7 Mai, 07:04, Dima Pasechnik <dimp...@gmail.com> wrote: > > > > > > > On May 6, 9:12 pm, David Joyner <wdjoy...@gmail.com> wrote: > > > > Hi: > > > > The contribution at #10153 byThomasFeulneris huge and, > > > IMHO, important. It basically generalizes what Robert Miller did for > > > automorphisms of codes in the binary case to the non-binary > > > case. Robert himself has run the valgrind on the doctests for #10153 > > > and says that none of the doctests in the code_can.pyx file seem to be > > > causing > > > any memory leaks. > > > > Is it possible for others to look at > > > http://trac.sagemath.org/sage_trac/ticket/10153 > > > and comment on it? I know reviewing something so immense > > > is very time consuming but maybe with more people > > > looking at it, the workload can be divided up in a > > > reasonable way? > > > It is 400Kb (!) of mostly C++ code. > > Few parts seem to come directly from Boost (and probably can be > > replaced with Sage's Boost subset, or > > placed there is needed), some parts from an apparently > > large collection of routines written by Ralf Gugisch. > > The files fdstream.hpp does not come directly from Boost. Something > equivalent within Boost seems to be boost/iostreams/device/ > file_descriptor.hpp. I think, this is not contained in Sage's standard > Boost. Should I make my code depend on the optional package > boost_1_34_1.spkg?
no harm in this... Eventually one can add the needed things to the "standard" Sage part of Boost. > > I need this class in order to use pipes for some 'conversation' with > GAP. Maybe someone knows some better way? well, there is a Sage-GAP interface available (not too fast though, the better one is in the works). Do you mean to say that your package has its own way to communicate with GAP? > > The files written by Ralf Gugisch do not contain the stuff on oriented > matroids. They just provide permutation groups and their action on STL > containers and a base class for building up a backtrack tree. > Therefore, I think, there is no reason for factoring out these files? It looks like a sufficiently interesting piece of functionality on its own. Which looks like a jolly valid reason to me to factor it out. Dmitrii > > > > > A minor detail, that can potentially cause a headache, is that the > > line endings are inconsistent across the patch (Unix/Windows). > > This will be changed, I did not realize that I have mixed them up. > > > > > This certainly can become an experimental package, IMHO. > > Thomas > > > > > > > Dima > > > > BTW,Thomashas a version of his program which calls > > > MAGMA:http://www.algorithm.uni-bayreuth.de/en/research/Coding_Theory/index.... > > > > - David Joyner -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
