On May 6, 9:12 pm, David Joyner <wdjoy...@gmail.com> wrote: > Hi: > > The contribution at #10153 by Thomas Feulner is huge and, > IMHO, important. It basically generalizes what Robert Miller did for > automorphisms of codes in the binary case to the non-binary > case. Robert himself has run the valgrind on the doctests for #10153 > and says that none of the doctests in the code_can.pyx file seem to be > causing > any memory leaks. > > Is it possible for others to look at > http://trac.sagemath.org/sage_trac/ticket/10153 > and comment on it? I know reviewing something so immense > is very time consuming but maybe with more people > looking at it, the workload can be divided up in a > reasonable way?
It is 400Kb (!) of mostly C++ code. Few parts seem to come directly from Boost (and probably can be replaced with Sage's Boost subset, or placed there is needed), some parts from an apparently large collection of routines written by Ralf Gugisch. A minor detail, that can potentially cause a headache, is that the line endings are inconsistent across the patch (Unix/Windows). This certainly can become an experimental package, IMHO. Dima > > BTW, Thomas has a version of his program which calls > MAGMA:http://www.algorithm.uni-bayreuth.de/en/research/Coding_Theory/index.... > > - David Joyner -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
