On Wed, Mar 16, 2011 at 11:51 PM, Simon King <simon.k...@uni-jena.de> wrote: > Hi, > > it happened again, although I perfectly know that closing a trac > ticket is the job of the release manager.
The only reason as far as I know that closing a ticket is the job of the release manager is to make sure the code is actually merged (it is left open 'till that point). I don't see any reason other's can't close duplicate, won't fix, invalid, or otherwise resolved tickets where no further action needs to be taken. > So, let me ask: What should a reviewer do if s/he thinks that the > ticket is a "wontfix" etc.? Unless the reviewer happens to be the > release manager, s/he is not supposed to choose a resolution. > > "Needs work" seems inappropriate, since "wontfix" means that there > should be no further work on the ticket. > > "Positive review" seems inappropriate, because "wontfix" is not > positive, unless you define that "wontfix" is a positive review to the > empty patch. > > "Leave as new" seems inappropriate, because in that way the release > manager will hardly become aware that the ticket may be closed. > > Cheers, > Simon > > -- > To post to this group, send an email to sage-devel@googlegroups.com > To unsubscribe from this group, send an email to > sage-devel+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/sage-devel > URL: http://www.sagemath.org > -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
