On 12 November 2010 23:49, John H Palmieri <jhpalmier...@gmail.com> wrote: > This question came up on a trac ticket recently: when working on an > spkg, in the patches directory there might be files like > > file.py > file.py.patch > > Then the spkg-install file copies file.py to the appropriate place in > src, while file.py.patch documents the changes. Certainly > file.py.patch should be tracked in the Mercurial repo for the spkg. > > * Should file.py also be tracked, or should it be in the .hgignore > file? > > (Personally, I think it should be tracked, but this is not a strongly > held opinion. One argument the other way: if it's in .hgignore, then > the spkg will be smaller, and besides, the relevant information is > already available in the patch file.) > > -- > John
I don't have a strong opinion on the matter either, though my slight preference is to track them, 1) I don't however believe the disk space argument for not tracking individual files is very strong, as normally the patches are such a small fraction of the actual package, it's not going to make much practical difference. 2) A somewhat stronger argument for tracking the patched files too, is that without doing that, you would be unable to look at an older version of the file without downloading the source code for that older version. So if I'm updating version N of a program, and want to know how we patched version N-2, I need to download the source for N-2 in order to see how that was patched. I have on occasions wanted to see how previous versions were patched, but this is only because I'm sometimes suspicious someone has just overwritten a file when the upstream source has changed. The current system is so error prone, that debugging patches can take some time and so having all the information available can be useful. Dave -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
