Thanks for the quick response. I'd say it's ready to go with the additional changes.
Kind regards, Maarten Derickx On Sep 13, 11:25 am, Minh Nguyen <nguyenmi...@gmail.com> wrote: > Hi koffie, > > On Mon, Sep 13, 2010 at 3:45 PM, koffie <m.derickx.stud...@gmail.com> wrote: > > I definitely like the new compatible lay-out. > > > When I looked > > athttp://trac.sagemath.org/sage_trac/attachment/ticket/9850/walkthrough... > > my eye spotted some details which leave room for some more > > improvement. > > > 1. The grey background of the search button (with the tekst "GO" on > > it) should be a darker shade of the "blue/purple" used all over sage > > docs. > > I have changed that to a pale, light grayish blue to be consistent > with the colour of the header and footer. The hex code is #B8B9F6. > > > 2. I really like the change of the ugly pale green to pale yellow for > > the background of the code blocks. The lines above and below these > > boxes however should also change their color, from green to a darker > > shade of yellow. > > Done. I have changed the border colour from green to a pale, light > grayish amber. The corresponding hex code is #E8D898. > > > 3. Locations like "SAGE_ROOT/blah/blahblah" and "/home/bla/di/ > > blahblah" have a light grey background which is very similar but not > > the same as the pale shade of purple/blue used all over in sage. This > > should be exactly the same color, or a significant different color > > still fitting the color scheme. > > Done. The colour used for shading commands or code within text is now > consistent with the colour used for the background of the navigation > bar. It is a light bluish gray with hex code #EAEAF8. > > > 4. The grey lines, (one is right of the navigation bar and the others > > are below the section headers) sort of only half fit the color scheme. > > I don't think it's very ugly right now, but maybe the darker shade of > > purple used in the background on the top of the page, or the color of > > the purple line around the search box would fit better. > > This is something I'm unable to fix. > > > I think the style issues 1 and 2 really should get adressed. I find 3 > > and 4 less important because they are less eye catching. > > See ticket #9850 [1] for a patch that addresses your comments above. > The generated documentation can be found at > > http://sage.math.washington.edu/home/mvngu/patch/9850-docstyle/doc/ > > [1]http://trac.sagemath.org/sage_trac/ticket/9850 > > -- > Regards > Minh Van Nguyen -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
