On 06/24/10 05:28 PM, Robert Miller wrote:
I guess someone should open a ticket for this to be added as a standard
package, then it tested extensively before being committed.
A few things should happen before we make this a standard spkg. First,
I think we should merge all the newly-positive-reviewed graph theory
tickets using LP, to make sure that they all play well together. Next
I think we should (after some testing) move your spkg to optional,
i.e. have GLPK-4.44 be optional for a short time first, to shake out
any issues that might crop up. Finally, once the dust has settled it
will be time to move the updated spkg to standard.
That sounds logical.
I'm sorry I needed to make so many changes to it, but the package was seriously
deficient - it needed a lot more than the SAGE64 sorted out.
* It did not test if the 'configure' script had failed
* If did not test if the 'make' had failed,
* It did not test if 'make install' had failed
* It did not test if 'python setup.py install'' had failed.
* There was no spkg-check to run the test suite.
etc etc.
I think it's pretty clear they were essential changes
The other changes, like linking in gmp and zlib seemed logical for performance
reasons, as stated in the source code of the package.
Given the number of changes I made, it would seem sensible this undergoes a
period as an optional package.
Dave
--
To post to this group, send an email to sage-devel@googlegroups.com
To unsubscribe from this group, send an email to
sage-devel+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org
