On Jul 8, 2009, at 11:17 AM, Nicolas M. Thiery wrote: > > On Wed, Jul 08, 2009 at 11:03:21AM -0700, Craig Citro wrote: >> >>> What's the status on this one? I though that the bottom line of the >>> discussion at SD15 for this one (not to be mixed up with #5986) >>> was that: >>> >>> - Apart from importing the cPickle sources into the Sage tree, the >>> patch was essentially trivial (a 5 lines change to the cPickle >>> code) and therefore easy to review >>> - It had some reasonable chances to be merged into Python at >>> some point. >>> - Craig was going to push this upstream >>> - There were no simple alternatives >>> >>> And that in view of all this it was good to go in Sage, and would >>> get >>> a positive review shortly. Which did not occur.
No one who had looked at it was comfortable giving it a positive review, but I said I'd take a look and expected to give it a positive review. I wasn't comfortable with the idea of shipping our own, separate copy of cpickle either, so that's where it sat. The change was fine, and given that we're trying to push this upstream a better place seems to be as a patch to the Python spkg, which Craig Citro posted to the ticket just today. - Robert --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to sage-devel@googlegroups.com To unsubscribe from this group, send email to sage-devel-unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URLs: http://www.sagemath.org -~----------~----~----~----~------~----~------~--~---
