I've updated my review patches (categories-framework-ref-dr.patch and the small categories-tensorial_rename-dr.patch). Unfortunately, I won't be able to work on this much more in the next month and a half. categories-framework is quite close to getting a positive review; the following are the main things that need to be remedied first.
* 100% doctests. I wrote some doctests, but not as many as I'd hoped. This probably constitutes the major portion of the remaining reviewing work. * Have some pickling tests, but make sure that it's comprehensive. * The function Hom in sage.categories.homset could use some cleaning up, though it works currently. * Find a better name for sage.categories.map.Map.category_for * Delete sage.categories.morphism.SetMorphismPython, or give a reason it shouldn't be deleted. Notes: * construction is unneeded for categories (used by the coercion system for parents). I commented out the definitions of construction Discussion: we currently have CategoryObject._base as a C attribute because some elements want fast access to a "base." Is CategoryObject the right place to put this? Maybe we should generalize the examples of sage.rings.integer_mod.NativeIntStruct and sage.rings.padics.pow_computer.PowComputer_class? Nicolas: Can the comment at the top of category.py "# Ugly temporary? workaround; see doc of UniqueRepresentation" describe why this hack is needed? Discussion: what's the right inheritance structure for homsets? Also, how should one specify that a category's homsets are enriched in another category? Via a method like "enriched_in()" on the category? By extra_super_categories() in a custom HomCategory? * Currently ParentGens.__init__ does not call ParentWithBase.__init__. This should presumably change at some point. * I added a new weakref version of cachefunc, and source introspection for dynamic classes. Someone should review these (along with the rest of my changes) Nicolas: can you clarify the use of sage.categories.morphism.Morphism.register_as_coercion I will be accessible on e-mail, but don't have time to work on this anytime soon. Good luck! I want to see this incorporated into Sage. David P.S. I don't think I have permission to post to sage-combinat-devel; Nicolas, do you want to forward this to that list? On Wed, Jul 8, 2009 at 10:59 AM, Nicolas M. Thiery <nicolas.thi...@u-psud.fr > wrote: > > Hi David (K), > > On Wed, Jul 08, 2009 at 12:41:40PM +0200, David R. Kohel wrote: > > I think the sage-combinat build should help. During Sage Days 16 in > > Barcelona I tried naively applying the one patch you or William asked > > me to review but it failed to apply. > > Hmm, did you receive the instructions I sent you for how to install > the patches? In short, just do: > > sage -combinat install > > assuming your .hgrc includes the following lines: > > [extensions] > hgext.mq = > > > On: > > http://sagetrac.org/sage_trac/wiki/CategoriesRoadMap > > Is the main issue #5891? > > Yes. And for you categories-categories-nt.patch. > > > Afterwards David Roe took the lead; so I need to know what he has > > done. > > I am waiting for his feedback; but he is only working on > categories-framework-nt.patch, so this is independent. In fact, the > only interaction with the other reviewers about > categories-categories-nt.patch is about the special methods __add__ > and __mul__ that Robert is supposed to work on. Just ignore them. > > > Just to verify: David refers (still) to me not David Roe? > > Yes. I updated this page with the last names to clear up the ambiguity. > > > Are the patches now at 100% doctests? If I remember or understood > > correctly, think this is a point with which David Roe was helping > > out and this work should be incorporated. > > I think categories-categories-nt.patch is up to speed (but I may have > missed some: please let me know!). In any cases this part was not > touched by David R. > > > P.S. As a remark, although this doesn't seem to play a role in the > > improvements to the categories framework, I make a distinction > > between the class hierarchy and the (default) categories to which > > they belong. E.g. "Get nice category graph pictures!" > > Definitely! > > Best, > Nicolas > -- > Nicolas M. Thiéry "Isil" <nthi...@users.sf.net> > http://Nicolas.Thiery.name/ > > > > --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to sage-devel@googlegroups.com To unsubscribe from this group, send email to sage-devel-unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URLs: http://www.sagemath.org -~----------~----~----~----~------~----~------~--~---
