Hi Nick, On Wed, Jun 3, 2009 at 6:56 AM, Nick Alexander <ncalexan...@gmail.com> wrote: >
<SNIP> > First, I really appreciate the human edited release tour! > > However, the examples you give for some of the work I did (the number > field relativize) include "improved" timings that are likely just > noise. The real benefit only comes in for fields where computing a > pari nf is costly. I think this is a better example (one that > wouldn't terminate in reasonable time in earlier versions -- for > example, I killed it after 5 seconds in a pari nfinit call on > sage.math): <SNIP> Thanks for the example. I think it really illustrates the efficiency gain that your patch at #6013 introduces. I took an example from that patch, as the ticket hardly contains any code to really showcase the features introduced by the patch. I'm currently updating the developers' guide, expanding it with observations written by Michael Abshoff about the trac guideline. But one of the main points that I like to point out when working on tickets is this: If a patch somehow results in speed efficiency, then there should be code examples to show the running time on at least the latest (stable) release, and similar or exact code performing under the development release. It's like a "before" and "after" thing. -- Regards Minh Van Nguyen --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to sage-devel@googlegroups.com To unsubscribe from this group, send email to sage-devel-unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URLs: http://www.sagemath.org -~----------~----~----~----~------~----~------~--~---
