On Dec 23, 2:07 am, "Georg S. Weber" <georgswe...@googlemail.com>
wrote:
> Hi sage-devel,
Hi Georg,
<SNIP>
> It's way from being perfect, so any comments are welcome!
>
-1 on the that example, it is way too complicated and introduces many
constructs that we don't have and IMHO plainly don't need. In detail:
* At the very top level: This is a cython/python library with a
little code thrown in and should use setuptools. No point in
reinventing the wheel - I know, you use them in "scripts/setup.py",
but why not use them directly?
* every file in src is checked into the repo. Don't do that.
* Most importantly: This is not KISS.
Sprocketer:exampleclib-1.0.0 michaelabshoff$ wc -l spkg-install
156 spkg-install
Maybe two spkg-installs are so long (gmp which contains numerous
crap things which will be gone one we switch to eMPIRe) and Singular,
which builds quite a bit of software.
* patches-install is also against everything we have been doing:
#if the file local/bin/extlibs-commit does not exist, copy it over
if [ ! -f "$SAGE_ROOT/local/bin/extlibs-commit" ]; then
$CP -p ./extlibs-commit "$SAGE_ROOT/local/bin/"
fi
The point is that (a) patches-install is about patching vanilla
sources in src and (b) that it is forced since that way one could
downgrade to another spkg.
* You dump things into $SAGE_ROOT/devel where nothing like that
belongs. A -bdist will break this trivially and I don't feel the need
to support random repos in Sage's devel. We are getting rid of extcode
as well as the doc repo, no need to add other repos back.
* SPKG.txt is not in the standard format:
== Changelog ==
* (see also "hg log")
* 2008-12-23: version 1.0.0 released
* 2008-11-29: first version with broad functionality
=== Release (Integrator, Date) ===
* (see also "hg log")
* SPKG Maintainer: version="1.0.0", date="2008-12-23"
And the point is exactly not to look into things with "hg log" -
there are other things wrong in SPKG.txt. For example: Your code
depends on Cython to build.
I am sure I can find plenty of other things that are wrong. This is
clearly the wrong way for something simple. I would much rather see
that you improve the documentation.
> @William:
> Hopefully the copyright notice I used throughout is OK for you?!
I don't understand why people add William to their copyright
statements. He didn't contribute to this code, so no need to add him.
> Cheers,
> gsw
PS: I am deleting the spkg as an attachment to the ticket and
sticking it somewhere else. This adds 100kb to *every* backup of trac
until the end of time, so I wasn't kidding when I told people not to
attach spkgs to trac tickets.
Cheers,
Michael
--~--~---------~--~----~------------~-------~--~----~
To post to this group, send email to sage-devel@googlegroups.com
To unsubscribe from this group, send email to
sage-devel-unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URLs: http://www.sagemath.org
-~----------~----~----~----~------~----~------~--~---
