I second that "needs review" and "needs work" are mostly obsolete and should be better handled by native github tools. Those labels were introduced when migrating to github to not change the workflow too much from the good old trac days. Besides the automatic transition "needs work" -> "needs review" after just merging develop, I also find it somewhat annoying to manually set the "needs work" label after just submitting a "request changes" review.
Perhaps as a transition period, those two labels could just reflect the github status. So: - There is a review with "Request changes" -> "needs work" - The PR is not a draft and not in "needs work" or "positive review" -> "needs review" If someone gives a "request changes" review and the PR author addresses the changes, one can re-request a new review (last point in https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/requesting-a-pull-request-review#requesting-reviews-from-collaborators-and-organization-members), which then removes the "request changes" status and thereby would automatically transition the PR into "needs review". The button is not there for new contributors, but those can either ping the original reviewer for a new review (or in the rare case that nobody is reacting to such a call, ping the core team to have the review invalidated.) The positive review label still needs to be there to signal Volker that the PR is ready to be merged. (The github way would be to replace the buildbots by the merge queue feature) On Wednesday, September 3, 2025 at 3:35:51 PM UTC+8 axio...@yahoo.de wrote: > > but this button removes the draft status. > > > I guess that I severely miscommunicated. I had the following process in > mind: > > 1. PR is opened, and automatically set to "draft" > 2. once it is ready for review, owner clicks "needs review", so the > "draft" is removed > 3. a developer with review privileges either selects "approve" or "request > changes" > > The labels "needs review", "needs work" and "positive review" are gone. > > However, this would only work if there is such a thing as "review > privilege". Moreover, I can imagine that there are further problems. In > particular, I am not sure how filtering by review status works, currently > "review:approved" gives no results. > > Martin > > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/sage-devel/760122be-1e59-4710-a064-50c298da3e8cn%40googlegroups.com.
