On Tue, Sep 2, 2025 at 7:21 AM 'Martin R' via sage-devel <[email protected]> wrote: > > PR's should be draft by default. As a reviewer, I cannot convert to draft. > > I agree that it might be better to get rid of the labels `positive review`, > `needs review`, `needs work` now.
how would one know that a draft PR needs review, without a "needs review" label? > > Martin > > On Tuesday, 2 September 2025 at 03:12:48 UTC+2 Kwankyu Lee wrote: >> >> On Tuesday, September 2, 2025 at 1:09:35 AM UTC+9 [email protected] wrote: >> >> Why should a PR go automagically (!) from needs work to needs review after a >> merge? >> >> >> We are expected to use the github interface. So to avoid the problem, first >> "convert to draft". > > -- > You received this message because you are subscribed to the Google Groups > "sage-devel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion visit > https://groups.google.com/d/msgid/sage-devel/bac3bd30-adc2-42c0-8a0a-b2091ce57ce3n%40googlegroups.com. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion visit https://groups.google.com/d/msgid/sage-devel/CAAWYfq264McN-jxQkDRL%2BQr5NwcXJqXfA9egrqywBGCdNfasmQ%40mail.gmail.com.
