We've already discussed this here: https://github.com/sagemath/sage/pull/36213#issuecomment-1711595430 and Tobias made a good argument for leaving it as is in https://github.com/sagemath/sage/pull/36213#issuecomment-1711640422.
What was the reason for rebasing a positively reviewed PR? Kwankyu Lee schrieb am Sonntag, 4. August 2024 um 13:10:07 UTC+2: > Hi > > It seems that synchronization script adds "needs review" label whenever a > new commit is uploaded to (non-draft) PR. > > If a merge (with develop branch) commit is uploaded to a PR that has > already got "positive review" label, then the "positive review" label is > replaced with "needs review" label. This is annoying. > > How about adding "needs review" label only when draft PR is converted to a > non-draft PR? > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/f2ae6083-56d3-413c-9035-73d17a5da144n%40googlegroups.com.
