We will continue with this next Tuesday (June 18th) with step four <https://github.com/sagemath/sage/issues/35927#issuecomment-2154204573>. After that the s: needs review label will be set automatically if you mark a draft as *ready for review* or push a new commit to a non draft PR.
seb....@gmail.com schrieb am Montag, 10. Juni 2024 um 12:08:51 UTC+2: > Currently ther are about 90 open PR's that are not drafts but don't have > any state label set (see this list > <https://github.com/sagemath/sage/pulls?page=2&q=is%3Aopen+is%3Apr+-label%3A%22s%3A+positive+review%22+-label%3A%22s%3A+needs+work%22+-label%3A%22s%3A+needs+info%22+-label%3A%22s%3A+needs+review%22+draft%3Afalse>). > > Obviously not all of them are authored by developers who cannot set these > labels because they are not members of Triage. If you are a member of > Triage and one of your PRs is among them, you should pay attention to what > will change tomorrow: > > 1. If you simply forgot to set the s: needs review label, then the bot > will do it for you in the future. > 2. If you intentionally didn't set s: needs review for your PR (for > example, because you want to check CI results first), then you should open > your PR as a *draft* in the future (see item 6 here > <https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request#creating-the-pull-request>) > > and change its status to r*eady for review* later on (see this page > <https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request>). > > Otherwise, the PR will have the s: needs review label from the start. > > seb....@gmail.com schrieb am Freitag, 7. Juni 2024 um 23:54:07 UTC+2: > >> *Sorry, typo in the headline: July -> June!* >> >> seb....@gmail.com schrieb am Freitag, 7. Juni 2024 um 23:49:54 UTC+2: >> >>> Dear Sage developers, >>> >>> We will now continue with a process that started last July >>> <https://groups.google.com/g/sage-devel/c/ElzW6XR4YAM/m/q9a0cEvgAQAJ>. >>> Unfortunately, this was blocked for many months while we waited for GitHub >>> to fix a bug in their web-interface. Although this bug is still not fixed >>> (see this comment on #35927 >>> <https://github.com/sagemath/sage/issues/35927#issuecomment-2152993322>), >>> parts of label sync that are less critical to this bug should continue. >>> >>> As before, the bot will be enabled in several steps. These are tracked >>> in issue #35927 <https://github.com/sagemath/sage/issues/35927>. We are >>> moving on to step 3 >>> <https://github.com/sagemath/sage/issues/35927#issuecomment-2154192483> >>> and 4 >>> <https://github.com/sagemath/sage/issues/35927#issuecomment-2154204573>, >>> the first of which will be enabled next Tuesday. These steps will allow >>> developers who are not members of the Triage team to have the s: needs >>> review label on their PRs. >>> >>> Please post comments, suggestions and bug reports on #35927 >>> <https://github.com/sagemath/sage/issues/35927>. >>> >>> Sebastian >>> >> -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/f54c9559-fc60-405f-9080-44c4b2747712n%40googlegroups.com.
